diff mbox series

[FFmpeg-devel] avformat/imf: s/++i/i++/g

Message ID 20220107091625.8831-1-zane@zanevaniperen.com
State Accepted
Commit 40766ae1da412f7a8f665fd49c0de905f856552e
Headers show
Series [FFmpeg-devel] avformat/imf: s/++i/i++/g | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_ppc success Make finished
andriy/make_fate_ppc success Make fate finished

Commit Message

Zane van Iperen Jan. 7, 2022, 9:16 a.m. UTC 
---
 libavformat/imfdec.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Comments

Paul B Mahol Feb. 4, 2022, 7:58 a.m. UTC | #1 
Never apply this. Very sorry state of project.
Pierre-Anthony Lemieux Feb. 4, 2022, 5:29 p.m. UTC | #2 
On Thu, Feb 3, 2022 at 11:58 PM Paul B Mahol <onemda@gmail.com> wrote:
>
> Never apply this.

I am not a maintainer and so cannot apply the patch.

There is another minor patch that has also been outstanding for some time now:

https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=5700

> Very sorry state of project.

Can you be more specific?

Are you referring to code style issues? If so, there is a draft patch at [1].

[1] https://github.com/sandflow/ffmpeg-imf/pull/85

I have been reluctant to propose it until:

(a) I am more confident in the expected coding style; and
(b) issues logged in trac are fixed.

Regarding (a), I asked the following question, which I never received
feedback on:

http://ffmpeg.org/pipermail/ffmpeg-devel/2022-January/290990.html

This prompted me to work on expanding the code style documentation,
which I mentioned on IRC and plan to proposed shortly:

https://github.com/sandflow/ffmpeg-imf/pull/95

Regarding (b), the following patch is up for review:

https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=5873

I can prioritize (a) if folks feel this is the right approach.

There is also an outstanding proposal [2] to refactor uuid
functionality. Have you had a chance to review?

[2] http://ffmpeg.org/pipermail/ffmpeg-devel/2022-January/291917.html

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Zane van Iperen Feb. 5, 2022, 2:05 a.m. UTC | #3 
On 4/2/22 17:58, Paul B Mahol wrote:
> Never apply this. Very sorry state of project.

Iirc, there was some discussion on IRC about it. If you're okay with it, then I'll apply it.
diff mbox series

Patch

diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
index 023f3556f6..3925462a26 100644
--- a/libavformat/imfdec.c
+++ b/libavformat/imfdec.c
@@ -263,7 +263,7 @@  static void imf_asset_locator_map_init(IMFAssetLocatorMap *asset_map)
  */
 static void imf_asset_locator_map_deinit(IMFAssetLocatorMap *asset_map)
 {
-    for (uint32_t i = 0; i < asset_map->asset_count; ++i)
+    for (uint32_t i = 0; i < asset_map->asset_count; i++)
         av_freep(&asset_map->assets[i].absolute_uri);
 
     av_freep(&asset_map->assets);
@@ -334,7 +334,7 @@  clean_up:
 
 static IMFAssetLocator *find_asset_map_locator(IMFAssetLocatorMap *asset_map, FFIMFUUID uuid)
 {
-    for (uint32_t i = 0; i < asset_map->asset_count; ++i) {
+    for (uint32_t i = 0; i < asset_map->asset_count; i++) {
         if (memcmp(asset_map->assets[i].uuid, uuid, 16) == 0)
             return &(asset_map->assets[i]);
     }
@@ -471,7 +471,7 @@  static int open_track_file_resource(AVFormatContext *s,
         return AVERROR(ENOMEM);
     track->resources = tmp;
 
-    for (uint32_t i = 0; i < track_file_resource->base.repeat_count; ++i) {
+    for (uint32_t i = 0; i < track_file_resource->base.repeat_count; i++) {
         IMFVirtualTrackResourcePlaybackCtx vt_ctx;
 
         vt_ctx.locator = asset_locator;
@@ -491,7 +491,7 @@  static int open_track_file_resource(AVFormatContext *s,
 
 static void imf_virtual_track_playback_context_deinit(IMFVirtualTrackPlaybackCtx *track)
 {
-    for (uint32_t i = 0; i < track->resource_count; ++i)
+    for (uint32_t i = 0; i < track->resource_count; i++)
         avformat_close_input(&track->resources[i].ctx);
 
     av_freep(&track->resources);
@@ -553,7 +553,7 @@  static int set_context_streams_from_tracks(AVFormatContext *s)
     IMFContext *c = s->priv_data;
     int ret = 0;
 
-    for (uint32_t i = 0; i < c->track_count; ++i) {
+    for (uint32_t i = 0; i < c->track_count; i++) {
         AVStream *asset_stream;
         AVStream *first_resource_stream;
 
@@ -600,7 +600,7 @@  static int open_cpl_tracks(AVFormatContext *s)
         }
     }
 
-    for (uint32_t i = 0; i < c->cpl->main_audio_track_count; ++i) {
+    for (uint32_t i = 0; i < c->cpl->main_audio_track_count; i++) {
         if ((ret = open_virtual_track(s, &c->cpl->main_audio_tracks[i], track_index++)) != 0) {
             av_log(s,
                    AV_LOG_ERROR,
@@ -718,7 +718,7 @@  static IMFVirtualTrackResourcePlaybackCtx *get_resource_context_for_timestamp(AV
            track->index,
            av_q2d(track->current_timestamp),
            av_q2d(track->duration));
-    for (uint32_t i = 0; i < track->resource_count; ++i) {
+    for (uint32_t i = 0; i < track->resource_count; i++) {
         cumulated_duration = av_add_q(cumulated_duration,
                                       av_make_q((int)track->resources[i].resource->base.duration
                                                     * edit_unit_duration.num,
@@ -843,7 +843,7 @@  static int imf_close(AVFormatContext *s)
     imf_asset_locator_map_deinit(&c->asset_locator_map);
     ff_imf_cpl_free(c->cpl);
 
-    for (uint32_t i = 0; i < c->track_count; ++i) {
+    for (uint32_t i = 0; i < c->track_count; i++) {
         imf_virtual_track_playback_context_deinit(c->tracks[i]);
         av_freep(&c->tracks[i]);
     }