diff mbox series

[FFmpeg-devel,09/19] avutil/fifo: Don't include avutil.h

Message ID AM7PR03MB666091B09C4CC50F2D950C948F349@AM7PR03MB6660.eurprd03.prod.outlook.com
State Accepted
Commit 0a1a8fcd56bf62da0d4b32da3e915860ba96684e
Headers show
Series [FFmpeg-devel] avutil/x86/emms: Don't unnecessarily include lavu/cpu.h | expand

Checks

Context Check Description
yinshiyou/configure_loongarch64 warning Failed to run configure
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_ppc success Make finished
andriy/make_fate_ppc success Make fate finished

Commit Message

Andreas Rheinhardt Feb. 15, 2022, 5:42 p.m. UTC
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavutil/fifo.c          | 5 ++++-
 libavutil/fifo.h          | 4 +++-
 libavutil/threadmessage.c | 2 ++
 3 files changed, 9 insertions(+), 2 deletions(-)

Comments

Martin Storsjö Feb. 23, 2022, 2:49 p.m. UTC | #1
On Tue, 15 Feb 2022, Andreas Rheinhardt wrote:

> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> libavutil/fifo.c          | 5 ++++-
> libavutil/fifo.h          | 4 +++-
> libavutil/threadmessage.c | 2 ++
> 3 files changed, 9 insertions(+), 2 deletions(-)

LGTM

// Martin
diff mbox series

Patch

diff --git a/libavutil/fifo.c b/libavutil/fifo.c
index 09c984143f..51a5af6f39 100644
--- a/libavutil/fifo.c
+++ b/libavutil/fifo.c
@@ -21,10 +21,13 @@ 
  */
 
 #include <stdint.h>
+#include <string.h>
 
 #include "avassert.h"
-#include "common.h"
+#include "error.h"
 #include "fifo.h"
+#include "macros.h"
+#include "mem.h"
 
 // by default the FIFO can be auto-grown to 1MB
 #define AUTO_GROW_DEFAULT_BYTES (1024 * 1024)
diff --git a/libavutil/fifo.h b/libavutil/fifo.h
index 4eb2ce42f8..4eed364afc 100644
--- a/libavutil/fifo.h
+++ b/libavutil/fifo.h
@@ -24,9 +24,11 @@ 
 #ifndef AVUTIL_FIFO_H
 #define AVUTIL_FIFO_H
 
+#include <stddef.h>
 #include <stdint.h>
-#include "avutil.h"
+
 #include "attributes.h"
+#include "version.h"
 
 typedef struct AVFifo AVFifo;
 
diff --git a/libavutil/threadmessage.c b/libavutil/threadmessage.c
index 6f25da76d7..f0e23f28fc 100644
--- a/libavutil/threadmessage.c
+++ b/libavutil/threadmessage.c
@@ -18,7 +18,9 @@ 
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
+#include <limits.h>
 #include "fifo.h"
+#include "mem.h"
 #include "threadmessage.h"
 #include "thread.h"