diff mbox series

[FFmpeg-devel,06/19] avformat/avio: Don't include common.h

Message ID AM7PR03MB66606B7DB0FD78BA6FFA49078F349@AM7PR03MB6660.eurprd03.prod.outlook.com
State Accepted
Commit 12a540352bc0fef439df6e1268751ffdb0cd5f6e
Headers show
Series [FFmpeg-devel] avutil/x86/emms: Don't unnecessarily include lavu/cpu.h | expand

Checks

Context Check Description
yinshiyou/configure_loongarch64 warning Failed to run configure
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_ppc success Make finished
andriy/make_fate_ppc success Make fate finished

Commit Message

Andreas Rheinhardt Feb. 15, 2022, 5:42 p.m. UTC
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavformat/avio.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Martin Storsjö Feb. 23, 2022, 2:46 p.m. UTC | #1
On Tue, 15 Feb 2022, Andreas Rheinhardt wrote:

> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> libavformat/avio.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/avio.h b/libavformat/avio.h
> index cd63322a62..ca970b1ce3 100644
> --- a/libavformat/avio.h
> +++ b/libavformat/avio.h
> @@ -27,8 +27,9 @@
>  */
>
> #include <stdint.h>
> +#include <stdio.h>
>
> -#include "libavutil/common.h"
> +#include "libavutil/attributes.h"
> #include "libavutil/dict.h"
> #include "libavutil/log.h"
>
> --

LGTM

// Martin
Andreas Rheinhardt Feb. 23, 2022, 4:07 p.m. UTC | #2
Martin Storsjö:
> On Tue, 15 Feb 2022, Andreas Rheinhardt wrote:
> 
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
>> ---
>> libavformat/avio.h | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/libavformat/avio.h b/libavformat/avio.h
>> index cd63322a62..ca970b1ce3 100644
>> --- a/libavformat/avio.h
>> +++ b/libavformat/avio.h
>> @@ -27,8 +27,9 @@
>>  */
>>
>> #include <stdint.h>
>> +#include <stdio.h>
>>
>> -#include "libavutil/common.h"
>> +#include "libavutil/attributes.h"
>> #include "libavutil/dict.h"
>> #include "libavutil/log.h"
>>
>> -- 
> 
> LGTM
> 
> // Martin
> 

Thanks for taking a look at this patchset. Will apply it tomorrow unless
there are objections.

- Andreas
diff mbox series

Patch

diff --git a/libavformat/avio.h b/libavformat/avio.h
index cd63322a62..ca970b1ce3 100644
--- a/libavformat/avio.h
+++ b/libavformat/avio.h
@@ -27,8 +27,9 @@ 
  */
 
 #include <stdint.h>
+#include <stdio.h>
 
-#include "libavutil/common.h"
+#include "libavutil/attributes.h"
 #include "libavutil/dict.h"
 #include "libavutil/log.h"