[FFmpeg-devel] MAINTAINERS: add Niklas Haas for vf_libplacebo.c

From: Niklas Haas <git@haasn.dev>

So I can merge my own changes to this filter after they pass peer
review, as well as keeping it in sync with upstream API changes / new
features.

Signed-off-by: Niklas Haas <git@haasn.dev>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

On 3/28/2022 3:33 PM, Niklas Haas wrote:
> From: Niklas Haas <git@haasn.dev>
> 
> So I can merge my own changes to this filter after they pass peer
> review, as well as keeping it in sync with upstream API changes / new
> features.
> 
> Signed-off-by: Niklas Haas <git@haasn.dev>
> ---
>   MAINTAINERS | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 931cf4bd2c..76e1332ad8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -354,6 +354,7 @@ Filters:
>     vf_il.c                               Paul B Mahol
>     vf_(t)interlace                       Thomas Mundt (CC <thomas.mundt@hr.de>)
>     vf_lenscorrection.c                   Daniel Oberhoff
> +  vf_libplacebo.c                       Niklas Haas
>     vf_mergeplanes.c                      Paul B Mahol
>     vf_mestimate.c                        Davinder Singh
>     vf_minterpolate.c                     Davinder Singh
> @@ -620,6 +621,7 @@ Loren Merritt                 ABD9 08F4 C920 3F65 D8BE 35D7 1540 DAA7 060F 56DE
>   Lynne                         FE50 139C 6805 72CA FD52 1F8D A2FE A5F0 3F03 4464
>   Michael Niedermayer           9FF2 128B 147E F673 0BAD F133 611E C787 040B 0FAB
>   Nicolas George                24CE 01CE 9ACC 5CEB 74D8 8D9D B063 D997 36E5 4C93
> +Niklas Haas (haasn)           1DDB 8076 B14D 5B48 32FC 99D9 EB52 DA9C 02BA 6FB4
>   Nikolay Aleksandrov           8978 1D8C FB71 588E 4B27 EAA8 C4F0 B5FC E011 13B1
>   Panagiotis Issaris            6571 13A3 33D9 3726 F728 AA98 F643 B12E ECF3 E029
>   Peter Ross                    A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B

Applied.

28 Mar 2022, 22:14 by jamrial@gmail.com:

> On 3/28/2022 3:33 PM, Niklas Haas wrote:
>
>> From: Niklas Haas <git@haasn.dev>
>>
>> So I can merge my own changes to this filter after they pass peer
>> review, as well as keeping it in sync with upstream API changes / new
>> features.
>>
>> Signed-off-by: Niklas Haas <git@haasn.dev>
>> ---
>>  MAINTAINERS | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 931cf4bd2c..76e1332ad8 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -354,6 +354,7 @@ Filters:
>>  vf_il.c                               Paul B Mahol
>>  vf_(t)interlace                       Thomas Mundt (CC <thomas.mundt@hr.de>)
>>  vf_lenscorrection.c                   Daniel Oberhoff
>> +  vf_libplacebo.c                       Niklas Haas
>>  vf_mergeplanes.c                      Paul B Mahol
>>  vf_mestimate.c                        Davinder Singh
>>  vf_minterpolate.c                     Davinder Singh
>> @@ -620,6 +621,7 @@ Loren Merritt                 ABD9 08F4 C920 3F65 D8BE 35D7 1540 DAA7 060F 56DE
>>  Lynne                         FE50 139C 6805 72CA FD52 1F8D A2FE A5F0 3F03 4464
>>  Michael Niedermayer           9FF2 128B 147E F673 0BAD F133 611E C787 040B 0FAB
>>  Nicolas George                24CE 01CE 9ACC 5CEB 74D8 8D9D B063 D997 36E5 4C93
>> +Niklas Haas (haasn)           1DDB 8076 B14D 5B48 32FC 99D9 EB52 DA9C 02BA 6FB4
>>  Nikolay Aleksandrov           8978 1D8C FB71 588E 4B27 EAA8 C4F0 B5FC E011 13B1
>>  Panagiotis Issaris            6571 13A3 33D9 3726 F728 AA98 F643 B12E ECF3 E029
>>  Peter Ross                    A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B
>>
>
> Applied.
>

I'm not okay with this. I don't mind anyone pushing approved patches,
but I still want to review and have final say on all Vulkan code. Could you
change that?
I think haasn was more of a maintainer on the film grain stuff.

On Mon, Mar 28, 2022 at 10:31 PM Lynne <dev@lynne.ee> wrote:
>
> 28 Mar 2022, 22:14 by jamrial@gmail.com:
>
> > On 3/28/2022 3:33 PM, Niklas Haas wrote:
> >
> >> From: Niklas Haas <git@haasn.dev>
> >>
> >> So I can merge my own changes to this filter after they pass peer
> >> review, as well as keeping it in sync with upstream API changes / new
> >> features.
> >>
> >> Signed-off-by: Niklas Haas <git@haasn.dev>
> >> ---
> >>  MAINTAINERS | 2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> >> index 931cf4bd2c..76e1332ad8 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -354,6 +354,7 @@ Filters:
> >>  vf_il.c                               Paul B Mahol
> >>  vf_(t)interlace                       Thomas Mundt (CC <thomas.mundt@hr.de>)
> >>  vf_lenscorrection.c                   Daniel Oberhoff
> >> +  vf_libplacebo.c                       Niklas Haas
> >>  vf_mergeplanes.c                      Paul B Mahol
> >>  vf_mestimate.c                        Davinder Singh
> >>  vf_minterpolate.c                     Davinder Singh
> >> @@ -620,6 +621,7 @@ Loren Merritt                 ABD9 08F4 C920 3F65 D8BE 35D7 1540 DAA7 060F 56DE
> >>  Lynne                         FE50 139C 6805 72CA FD52 1F8D A2FE A5F0 3F03 4464
> >>  Michael Niedermayer           9FF2 128B 147E F673 0BAD F133 611E C787 040B 0FAB
> >>  Nicolas George                24CE 01CE 9ACC 5CEB 74D8 8D9D B063 D997 36E5 4C93
> >> +Niklas Haas (haasn)           1DDB 8076 B14D 5B48 32FC 99D9 EB52 DA9C 02BA 6FB4
> >>  Nikolay Aleksandrov           8978 1D8C FB71 588E 4B27 EAA8 C4F0 B5FC E011 13B1
> >>  Panagiotis Issaris            6571 13A3 33D9 3726 F728 AA98 F643 B12E ECF3 E029
> >>  Peter Ross                    A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B
> >>
> >
> > Applied.
> >
>
> I'm not okay with this. I don't mind anyone pushing approved patches,
> but I still want to review and have final say on all Vulkan code. Could you
> change that?
> I think haasn was more of a maintainer on the film grain stuff.

He wrote this filter and maintains it, as it also interacts with his
library, I don't see the problem here.
The interaction with the Vulkan code in FFmpeg seems minimal, mostly
just using it through the public hwcontext interface and avfilter
hwframe support to read vulkan frames, which is basically public API.

- Hendrik

On Mon, 28 Mar 2022 22:31:36 +0200 Lynne <dev@lynne.ee> wrote:
> I'm not okay with this. I don't mind anyone pushing approved patches,
> but I still want to review and have final say on all Vulkan code. Could you
> change that?

The contents of vf_libplacebo is not "Vulkan code". The only thing
Vulkan about it is the minimal plumbing between AVFrame and libplacebo,
most of which is actually already happening inside libplacebo's codebase
(<utils/libav.h`) where I already have complete control over it.

If anything, I still want to move this filter away from being
Vulkan-exclusive in the future, which would make it even more decoupled
from your concern.

28 Mar 2022, 23:13 by ffmpeg@haasn.xyz:

> On Mon, 28 Mar 2022 22:31:36 +0200 Lynne <dev@lynne.ee> wrote:
>
>> I'm not okay with this. I don't mind anyone pushing approved patches,
>> but I still want to review and have final say on all Vulkan code. Could you
>> change that?
>>
>
> The contents of vf_libplacebo is not "Vulkan code". The only thing
> Vulkan about it is the minimal plumbing between AVFrame and libplacebo,
> most of which is actually already happening inside libplacebo's codebase
> (<utils/libav.h`) where I already have complete control over it.
>

Device creation's still done from the lavu-side of things.


> If anything, I still want to move this filter away from being
> Vulkan-exclusive in the future, which would make it even more decoupled
> from your concern.
>

I explicitly told you that's okay when the filter first got merged,
but you didn't change it back then, and I've been waiting for you
to enable it.

On Tue, 29 Mar 2022 01:12:36 +0200 Lynne <dev@lynne.ee> wrote:
> 28 Mar 2022, 23:13 by ffmpeg@haasn.xyz:
> 
> > On Mon, 28 Mar 2022 22:31:36 +0200 Lynne <dev@lynne.ee> wrote:
> >
> >> I'm not okay with this. I don't mind anyone pushing approved patches,
> >> but I still want to review and have final say on all Vulkan code. Could you
> >> change that?
> >>
> >
> > The contents of vf_libplacebo is not "Vulkan code". The only thing
> > Vulkan about it is the minimal plumbing between AVFrame and libplacebo,
> > most of which is actually already happening inside libplacebo's codebase
> > (<utils/libav.h`) where I already have complete control over it.
> >
> 
> Device creation's still done from the lavu-side of things.

Right, but this is outside the scope of vf_libplacebo which is what I'm
being added as the maintainer for.

With that being said, is there still any objection to me being added as
a maintainer for **vf_libplacebo** specifically?