diff mbox series

[FFmpeg-devel,v3,2/2] doc/examples/transcode_aac: Set decoder packet timebase

Message ID 72590313-f19e-8154-c596-c5b5efc2b82e@gmail.com
State New
Headers show
Series [FFmpeg-devel,v3,1/2] doc/examples/transcode_aac: Don't ignore last encoded frame | expand

Checks

Context Check Description
andriy/configure_armv7_RPi4 warning Failed to apply patch
yinshiyou/configure_loongarch64 warning Failed to apply patch
andriy/configure_x86 warning Failed to apply patch

Commit Message

Andreas Unterweger April 27, 2022, 1:35 p.m. UTC
Previously, the default timebase caused two warnings during decoding 
about not being able to update timestamps for skipped and discarded 
samples, respectively.

Signed-off-by: Andreas Unterweger <dustsigns@gmail.com>
---
  doc/examples/transcode_aac.c | 6 +++++-
  1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Andreas Unterweger April 27, 2022, 1:40 p.m. UTC | #1
Am 27.04.2022 um 15:35 schrieb Andreas Unterweger:
> Previously, the default timebase caused two warnings during decoding 
> about not being able to update timestamps for skipped and discarded 
> samples, respectively.
> 
> Signed-off-by: Andreas Unterweger <dustsigns@gmail.com>
> ---
>   doc/examples/transcode_aac.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c
> index c9b93f6439..6197369756 100644
> --- a/doc/examples/transcode_aac.c
> +++ b/doc/examples/transcode_aac.c
> @@ -1,5 +1,5 @@
>   /*
> - * Copyright (c) 2013-2018 Andreas Unterweger
> + * Copyright (c) 2013-2022 Andreas Unterweger
>    *
>    * This file is part of FFmpeg.
>    *
> @@ -120,6 +120,10 @@ static int open_input_file(const char *filename,
>           avformat_close_input(input_format_context);
>           return error;
>       }
> +    +    /* Set the packet timebase for the decoder. The input file's 
> sample
> +     * rate is used as the denominator for simplicity. */
> +    avctx->pkt_timebase = (AVRational) { 1, avctx->sample_rate };
>        /* Save the decoder context for easier access later. */
>       *input_codec_context = avctx;

I rebased the patch another one time onto the current master. Please apply.

Best,
Andreas
diff mbox series

Patch

diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c
index c9b93f6439..6197369756 100644
--- a/doc/examples/transcode_aac.c
+++ b/doc/examples/transcode_aac.c
@@ -1,5 +1,5 @@ 
  /*
- * Copyright (c) 2013-2018 Andreas Unterweger
+ * Copyright (c) 2013-2022 Andreas Unterweger
   *
   * This file is part of FFmpeg.
   *
@@ -120,6 +120,10 @@  static int open_input_file(const char *filename,
          avformat_close_input(input_format_context);
          return error;
      }
+    +    /* Set the packet timebase for the decoder. The input file's 
sample
+     * rate is used as the denominator for simplicity. */
+    avctx->pkt_timebase = (AVRational) { 1, avctx->sample_rate };
       /* Save the decoder context for easier access later. */
      *input_codec_context = avctx;
-- 
2.30.2