| Message ID | CAKp+PPoy5coryr7Qj4O2ZnupmrHi2dsVNLe76wLiRBJ1i0Xipw@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel,v7,1/4] doc/examples/transcode_aac: Don't ignore last encoded frame | expand |
| Context | Check | Description |
|---|---|---|
| andriy/configure_x86 | warning | Failed to apply patch |
| yinshiyou/configure_loongarch64 | warning | Failed to apply patch |
On Mon, 2 May 2022 at 09:31, Andreas Unterweger <dustsigns@gmail.com> wrote: > > Signed-off-by: Andreas Unterweger <dustsigns@gmail.com> > --- > doc/examples/transcode_aac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c > index 909aa1cb73..1b372782ab 100644 > --- a/doc/examples/transcode_aac.c > +++ b/doc/examples/transcode_aac.c > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2013-2018 Andreas Unterweger > + * Copyright (c) 2013-2022 Andreas Unterweger > * > * This file is part of FFmpeg. > * > -- > 2.30.2 > > Patchwork is again not happy with this (newly rebased) patch and it does not give any comprehensive indication why. I've been trying to get this patch in since February with minimal feedback and I have neither got the time nor the patience to pursue this for another month. Unfortunately, it seems that the documentation and examples of libav* are a very low priority. My repeated, mostly unanswered questions on IRC and on the FFmpeg user mailing list about how to access or build the documentation for any of the recent stable libav*/FFmpeg versions seem to support this. The most recent stable online libav* documentation is from 2018 (version 4.1); the build instructions for the documentation are insufficient and my questions about how to build the documentation without installing all dependencies have been effectively unanswered. All of the libav* are very complex already and it is next to impossible for beginners to get started without easily accessible documentation and up-to-date examples. I have been trying to keep the transcode_aac example up to date, but it seems like a futile effort. Please use or adapt this patch however you see fit. I will stay subscribed to this mailing list until the end of next week before moving on. Any further communication can be directed towards my e-mail address which is also in the transcode_aac header. I sincerely hope that libav*/FFmpeg will become more beginner-friendly again in the future. Best, Andreas
On 2022-05-02 01:49 pm, Andreas Unterweger wrote: > On Mon, 2 May 2022 at 09:31, Andreas Unterweger<dustsigns@gmail.com> wrote: >> Signed-off-by: Andreas Unterweger<dustsigns@gmail.com> >> --- >> doc/examples/transcode_aac.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c >> index 909aa1cb73..1b372782ab 100644 >> --- a/doc/examples/transcode_aac.c >> +++ b/doc/examples/transcode_aac.c >> @@ -1,5 +1,5 @@ >> /* >> - * Copyright (c) 2013-2018 Andreas Unterweger >> + * Copyright (c) 2013-2022 Andreas Unterweger >> * >> * This file is part of FFmpeg. >> * >> -- >> 2.30.2 >> >> > Patchwork is again not happy with this (newly rebased) patch and it > does not give any comprehensive indication why. I've been trying to > get this patch in since February with minimal feedback and I have > neither got the time nor the patience to pursue this for another > month. The error is error: patch fragment without header at line 6: @@ -675,18 +677,17 @@ static int encode_audio_frame(AVFrame *frame, The patch on PW only shows the first two hunks. Ideally, send your path using git send-email, or upload the mbox file generated by git format-patch. Since you already got a LGTM, I can push once I get a valid master-rebased patch. Regards, Gyan > Unfortunately, it seems that the documentation and examples of libav* > are a very low priority. My repeated, mostly unanswered questions on > IRC and on the FFmpeg user mailing list about how to access or build > the documentation for any of the recent stable libav*/FFmpeg versions > seem to support this. The most recent stable online libav* > documentation is from 2018 (version 4.1); the build instructions for > the documentation are insufficient and my questions about how to build > the documentation without installing all dependencies have been > effectively unanswered. > All of the libav* are very complex already and it is next to > impossible for beginners to get started without easily accessible > documentation and up-to-date examples. I have been trying to keep the > transcode_aac example up to date, but it seems like a futile effort. > Please use or adapt this patch however you see fit. I will stay > subscribed to this mailing list until the end of next week before > moving on. Any further communication can be directed towards my e-mail > address which is also in the transcode_aac header. I sincerely hope > that libav*/FFmpeg will become more beginner-friendly again in the > future. > > Best, > Andreas > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On Mon, 2 May 2022 at 10:39, Gyan Doshi <ffmpeg@gyani.pro> wrote: > The error is > > error: patch fragment without header at line 6: @@ -675,18 +677,17 @@ static int encode_audio_frame(AVFrame *frame, > > > The patch on PW only shows the first two hunks. > > Ideally, send your path using git send-email, or upload the mbox file > generated by git format-patch. > > Since you already got a LGTM, I can push once I get a valid > master-rebased patch. > > > Regards, > Gyan I uploaded the patchset to http://temp.andreas-unterweger.eu/patchset.tar.gz. The files have been generated as per the documented git format-patch command: git format-patch -s -o "outputfolder" --add-header "X-Unsent: 1" --suffix .eml --to ffmpeg-devel@ffmpeg.org -4 Best, Andreas
On 2022-05-02 02:23 pm, Andreas Unterweger wrote: > On Mon, 2 May 2022 at 10:39, Gyan Doshi <ffmpeg@gyani.pro> wrote: >> The error is >> >> error: patch fragment without header at line 6: @@ -675,18 +677,17 @@ static int encode_audio_frame(AVFrame *frame, >> >> >> The patch on PW only shows the first two hunks. >> >> Ideally, send your path using git send-email, or upload the mbox file >> generated by git format-patch. >> >> Since you already got a LGTM, I can push once I get a valid >> master-rebased patch. >> >> >> Regards, >> Gyan > I uploaded the patchset to http://temp.andreas-unterweger.eu/patchset.tar.gz. > The files have been generated as per the documented git format-patch > command: git format-patch -s -o "outputfolder" --add-header "X-Unsent: > 1" --suffix .eml --to ffmpeg-devel@ffmpeg.org -4 Removed whitespace errors in first two patches and pushed the set as e13429c9c4...40f2ea971f Gyan > > Best, > Andreas > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On Mon, 2 May 2022 at 11:38, Gyan Doshi <ffmpeg@gyani.pro> wrote: > Removed whitespace errors in first two patches and pushed the set as > > e13429c9c4...40f2ea971f Thank you. Any hints on how I can avoid these types of errors in the future? Best, Andreas
On 2022-05-02 03:13 pm, Andreas Unterweger wrote: > On Mon, 2 May 2022 at 11:38, Gyan Doshi <ffmpeg@gyani.pro> wrote: >> Removed whitespace errors in first two patches and pushed the set as >> >> e13429c9c4...40f2ea971f > Thank you. Any hints on how I can avoid these types of errors in the future? You had stray tabs on newlines. So I suspect your editor auto-indents on new lines. Shut that off. And the ffmpeg source code files only work with spaces, not tabs, so if your editor allows it, set it to insert 4 spaces when Tab key is pressed. Regards, Gyan > > Best, > Andreas > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c index 909aa1cb73..1b372782ab 100644 --- a/doc/examples/transcode_aac.c +++ b/doc/examples/transcode_aac.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2013-2018 Andreas Unterweger + * Copyright (c) 2013-2022 Andreas Unterweger * * This file is part of FFmpeg. *
Signed-off-by: Andreas Unterweger <dustsigns@gmail.com> --- doc/examples/transcode_aac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)