diff mbox series

[FFmpeg-devel] avfilter/geq: unbreak alpha processing

Message ID 20220507120439.6558-1-ffmpeg@gyani.pro
State Accepted
Commit b980d9e8ecf5d4bc5e39a74bdad98c7cc400da84
Headers show
Series [FFmpeg-devel] avfilter/geq: unbreak alpha processing | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Gyan Doshi May 7, 2022, 12:04 p.m. UTC 
d607af50fd broke alpha processing by always overwriting any supplied
alpha expression.
---
 libavfilter/vf_geq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Niedermayer May 7, 2022, 7:10 p.m. UTC | #1 
On Sat, May 07, 2022 at 05:34:39PM +0530, Gyan Doshi wrote:
> d607af50fd broke alpha processing by always overwriting any supplied
> alpha expression.
> ---
>  libavfilter/vf_geq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

LGTM

thx

[...]
Gyan Doshi May 8, 2022, 4:37 a.m. UTC | #2 
On 2022-05-08 12:40 am, Michael Niedermayer wrote:
> On Sat, May 07, 2022 at 05:34:39PM +0530, Gyan Doshi wrote:
>> d607af50fd broke alpha processing by always overwriting any supplied
>> alpha expression.
>> ---
>>   libavfilter/vf_geq.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> LGTM

Pushed as b980d9e8ecf5d4bc5e39a74bdad98c7cc400da84

Regards,
Gyan
diff mbox series

Patch

diff --git a/libavfilter/vf_geq.c b/libavfilter/vf_geq.c
index fd9e0fd80b..2b53980278 100644
--- a/libavfilter/vf_geq.c
+++ b/libavfilter/vf_geq.c
@@ -275,7 +275,7 @@  static av_cold int geq_init(AVFilterContext *ctx)
 
     if (!geq->expr_str[A] && geq->bps != 32) {
         geq->expr_str[A] = av_asprintf("%d", (1<<geq->bps) - 1);
-    } else {
+    } else if (!geq->expr_str[A]) {
         geq->expr_str[A] = av_asprintf("%f", 1.f);
     }
     if (!geq->expr_str[G])