diff mbox series

[FFmpeg-devel] avformat/img2: Add support for AVIF mux in image2

Message ID 20220516174021.3751941-1-vigneshv@google.com
State Accepted
Commit dd99d34d67e2612a8f133f8a86db9f64b4dfa20d
Headers show
Series [FFmpeg-devel] avformat/img2: Add support for AVIF mux in image2 | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Vignesh Venkat May 16, 2022, 5:40 p.m. UTC
Add support for AVIF muxing in the image2 muxer.

Tested with this example:
ffmpeg -lavfi testsrc=duration=1:size=320x320 -g 1 -flags global_header -c:v libaom-av1 -f image2 img-%2d.avif

Signed-off-by: Vignesh Venkatasubramanian <vigneshv@google.com>
---
 libavformat/img2enc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

James Zern May 17, 2022, 7:36 p.m. UTC | #1
On Mon, May 16, 2022 at 10:40 AM Vignesh Venkatasubramanian
<vigneshv-at-google.com@ffmpeg.org> wrote:
>
> Add support for AVIF muxing in the image2 muxer.
>
> Tested with this example:
> ffmpeg -lavfi testsrc=duration=1:size=320x320 -g 1 -flags global_header -c:v libaom-av1 -f image2 img-%2d.avif
>
> Signed-off-by: Vignesh Venkatasubramanian <vigneshv@google.com>
> ---
>  libavformat/img2enc.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>

lgtm.
Gyan Doshi May 19, 2022, 4:27 a.m. UTC | #2
On 2022-05-18 01:06 am, James Zern wrote:
> On Mon, May 16, 2022 at 10:40 AM Vignesh Venkatasubramanian
> <vigneshv-at-google.com@ffmpeg.org> wrote:
>> Add support for AVIF muxing in the image2 muxer.
>>
>> Tested with this example:
>> ffmpeg -lavfi testsrc=duration=1:size=320x320 -g 1 -flags global_header -c:v libaom-av1 -f image2 img-%2d.avif
>>
>> Signed-off-by: Vignesh Venkatasubramanian <vigneshv@google.com>
>> ---
>>   libavformat/img2enc.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
> lgtm.

Will apply.

Regards,
Gyan
Gyan Doshi May 19, 2022, 8:54 a.m. UTC | #3
On 2022-05-19 09:57 am, Gyan Doshi wrote:
>
>
> On 2022-05-18 01:06 am, James Zern wrote:
>> On Mon, May 16, 2022 at 10:40 AM Vignesh Venkatasubramanian
>> <vigneshv-at-google.com@ffmpeg.org> wrote:
>>> Add support for AVIF muxing in the image2 muxer.
>>>
>>> Tested with this example:
>>> ffmpeg -lavfi testsrc=duration=1:size=320x320 -g 1 -flags 
>>> global_header -c:v libaom-av1 -f image2 img-%2d.avif
>>>
>>> Signed-off-by: Vignesh Venkatasubramanian <vigneshv@google.com>
>>> ---
>>>   libavformat/img2enc.c | 4 +++-
>>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>> lgtm.
>
> Will apply.

Applied as dd99d34d67e2612a8f133f8a86db9f64b4dfa20d

Regards,
Gyan
Vignesh Venkat May 19, 2022, 4:10 p.m. UTC | #4
On Thu, May 19, 2022 at 1:55 AM Gyan Doshi <ffmpeg@gyani.pro> wrote:
>
>
>
> On 2022-05-19 09:57 am, Gyan Doshi wrote:
> >
> >
> > On 2022-05-18 01:06 am, James Zern wrote:
> >> On Mon, May 16, 2022 at 10:40 AM Vignesh Venkatasubramanian
> >> <vigneshv-at-google.com@ffmpeg.org> wrote:
> >>> Add support for AVIF muxing in the image2 muxer.
> >>>
> >>> Tested with this example:
> >>> ffmpeg -lavfi testsrc=duration=1:size=320x320 -g 1 -flags
> >>> global_header -c:v libaom-av1 -f image2 img-%2d.avif
> >>>
> >>> Signed-off-by: Vignesh Venkatasubramanian <vigneshv@google.com>
> >>> ---
> >>>   libavformat/img2enc.c | 4 +++-
> >>>   1 file changed, 3 insertions(+), 1 deletion(-)
> >>>
> >> lgtm.
> >
> > Will apply.
>
> Applied as dd99d34d67e2612a8f133f8a86db9f64b4dfa20d
>

Thank you!

> Regards,
> Gyan
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c
index 5ed97bb833..0015297ec2 100644
--- a/libavformat/img2enc.c
+++ b/libavformat/img2enc.c
@@ -58,6 +58,8 @@  static int write_header(AVFormatContext *s)
         img->muxer = "gif";
     } else if (st->codecpar->codec_id == AV_CODEC_ID_FITS) {
         img->muxer = "fits";
+    } else if (st->codecpar->codec_id == AV_CODEC_ID_AV1) {
+        img->muxer = "avif";
     } else if (st->codecpar->codec_id == AV_CODEC_ID_RAWVIDEO) {
         const char *str = strrchr(s->url, '.');
         img->split_planes =     str
@@ -265,7 +267,7 @@  const AVOutputFormat ff_image2_muxer = {
     .long_name      = NULL_IF_CONFIG_SMALL("image2 sequence"),
     .extensions     = "bmp,dpx,exr,jls,jpeg,jpg,jxl,ljpg,pam,pbm,pcx,pfm,pgm,pgmyuv,"
                       "png,ppm,sgi,tga,tif,tiff,jp2,j2c,j2k,xwd,sun,ras,rs,im1,im8,"
-                      "im24,sunras,vbn,xbm,xface,pix,y",
+                      "im24,sunras,vbn,xbm,xface,pix,y,avif",
     .priv_data_size = sizeof(VideoMuxData),
     .video_codec    = AV_CODEC_ID_MJPEG,
     .write_header   = write_header,