| Message ID | 20220519204215.3140970-1-izadi@google.com |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel] Add YCOCG colorspace to input arguments of vf_colorspace. | expand |
| Context | Check | Description |
|---|---|---|
| andriy/commit_msg_x86 | warning | The first line of the commit message must start with a context terminated by a colon and a space, for example "lavu/opt: " or "doc: ". |
| yinshiyou/commit_msg_loongarch64 | warning | The first line of the commit message must start with a context terminated by a colon and a space, for example "lavu/opt: " or "doc: ". |
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
FYI On Thu, May 19, 2022 at 1:42 PM Mohammad Izadi <izadi@google.com> wrote: > ffmpeg support YCOCG (YCOCG=YCGCO). However, vf_colorspace is only support > YCGCO as input. Added YCOCG to the inputs. > --- > libavfilter/vf_colorspace.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c > index 3c8b3b20eb..bccd04528e 100644 > --- a/libavfilter/vf_colorspace.c > +++ b/libavfilter/vf_colorspace.c > @@ -906,6 +906,7 @@ static const AVOption colorspace_options[] = { > ENUM("smpte170m", AVCOL_SPC_SMPTE170M, "csp"), > ENUM("smpte240m", AVCOL_SPC_SMPTE240M, "csp"), > ENUM("ycgco", AVCOL_SPC_YCGCO, "csp"), > + ENUM("ycocg", AVCOL_SPC_YCOCG, "csp"), > ENUM("gbr", AVCOL_SPC_RGB, "csp"), > ENUM("bt2020nc", AVCOL_SPC_BT2020_NCL, "csp"), > ENUM("bt2020ncl", AVCOL_SPC_BT2020_NCL, "csp"), > -- > 2.36.1.124.g0e6072fb45-goog > >
Hi, On Thu, May 19, 2022 at 4:42 PM Mohammad Izadi < izadi-at-google.com@ffmpeg.org> wrote: > ffmpeg support YCOCG (YCOCG=YCGCO). However, vf_colorspace is only support > YCGCO as input. Added YCOCG to the inputs. > --- > libavfilter/vf_colorspace.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c > index 3c8b3b20eb..bccd04528e 100644 > --- a/libavfilter/vf_colorspace.c > +++ b/libavfilter/vf_colorspace.c > @@ -906,6 +906,7 @@ static const AVOption colorspace_options[] = { > ENUM("smpte170m", AVCOL_SPC_SMPTE170M, "csp"), > ENUM("smpte240m", AVCOL_SPC_SMPTE240M, "csp"), > ENUM("ycgco", AVCOL_SPC_YCGCO, "csp"), > + ENUM("ycocg", AVCOL_SPC_YCOCG, "csp"), > ENUM("gbr", AVCOL_SPC_RGB, "csp"), > ENUM("bt2020nc", AVCOL_SPC_BT2020_NCL, "csp"), > ENUM("bt2020ncl", AVCOL_SPC_BT2020_NCL, "csp"), > -- > 2.36.1.124.g0e6072fb45-goog > Could you elaborate on why you think AVCOL_SPC_YCGCO might be missing from the LumaCoefficients table? Is this a typo/mixup? Should it be added? Ronald
On Tue, May 31, 2022 at 7:17 PM Ronald S. Bultje <rsbultje@gmail.com> wrote: > Hi, > > On Thu, May 19, 2022 at 4:42 PM Mohammad Izadi < > izadi-at-google.com@ffmpeg.org> wrote: > > > ffmpeg support YCOCG (YCOCG=YCGCO). However, vf_colorspace is only > support > > YCGCO as input. Added YCOCG to the inputs. > > --- > > libavfilter/vf_colorspace.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c > > index 3c8b3b20eb..bccd04528e 100644 > > --- a/libavfilter/vf_colorspace.c > > +++ b/libavfilter/vf_colorspace.c > > @@ -906,6 +906,7 @@ static const AVOption colorspace_options[] = { > > ENUM("smpte170m", AVCOL_SPC_SMPTE170M, "csp"), > > ENUM("smpte240m", AVCOL_SPC_SMPTE240M, "csp"), > > ENUM("ycgco", AVCOL_SPC_YCGCO, "csp"), > > + ENUM("ycocg", AVCOL_SPC_YCOCG, "csp"), > > ENUM("gbr", AVCOL_SPC_RGB, "csp"), > > ENUM("bt2020nc", AVCOL_SPC_BT2020_NCL, "csp"), > > ENUM("bt2020ncl", AVCOL_SPC_BT2020_NCL, "csp"), > > -- > > 2.36.1.124.g0e6072fb45-goog > > > > Could you elaborate on why you think AVCOL_SPC_YCGCO might be missing from > the LumaCoefficients table? Is this a typo/mixup? Should it be added? > from pixfmt.h AVCOL_SPC_YCGCO = 8, ///< used by Dirac / VC-2 and H.264 FRext, see ITU-T SG16 AVCOL_SPC_YCOCG = AVCOL_SPC_YCGCO, this input option seems redundant, in which use case do you strictly need it? thanks
diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c index 3c8b3b20eb..bccd04528e 100644 --- a/libavfilter/vf_colorspace.c +++ b/libavfilter/vf_colorspace.c @@ -906,6 +906,7 @@ static const AVOption colorspace_options[] = { ENUM("smpte170m", AVCOL_SPC_SMPTE170M, "csp"), ENUM("smpte240m", AVCOL_SPC_SMPTE240M, "csp"), ENUM("ycgco", AVCOL_SPC_YCGCO, "csp"), + ENUM("ycocg", AVCOL_SPC_YCOCG, "csp"), ENUM("gbr", AVCOL_SPC_RGB, "csp"), ENUM("bt2020nc", AVCOL_SPC_BT2020_NCL, "csp"), ENUM("bt2020ncl", AVCOL_SPC_BT2020_NCL, "csp"),