| Message ID | 20161228130338.GA4749@nb4 |
|---|---|
| State | Not Applicable |
| Headers | show |
On Wed, Dec 28, 2016 at 5:03 AM, Michael Niedermayer <michael@niedermayer.cc > wrote: > On Tue, Dec 27, 2016 at 09:47:47PM -0800, Michael Bradshaw wrote: > > From: Michael Bradshaw <mjbshaw@google.com> > > > > Signed-off-by: Michael Bradshaw <mjbshaw@google.com> > > --- > > libavformat/matroskaenc.c | 38 +++++++++++++++++++++++++++++++------- > > 1 file changed, 31 insertions(+), 7 deletions(-) > > breaks fate > [...] I've looked into this and it's expected behavior. -codec copy is also copying timing information (including time base), and with this patch the Matroska/WebM muxers are respecting that. I could update the fate files, but before doing that I'd like to ensure that this change in behavior for -codec copy is correct and desirable.
On Fri, Jan 13, 2017 at 08:48:01AM -0800, Michael Bradshaw wrote: > On Wed, Dec 28, 2016 at 5:03 AM, Michael Niedermayer <michael@niedermayer.cc > > wrote: > > > On Tue, Dec 27, 2016 at 09:47:47PM -0800, Michael Bradshaw wrote: > > > From: Michael Bradshaw <mjbshaw@google.com> > > > > > > Signed-off-by: Michael Bradshaw <mjbshaw@google.com> > > > --- > > > libavformat/matroskaenc.c | 38 +++++++++++++++++++++++++++++++------- > > > 1 file changed, 31 insertions(+), 7 deletions(-) > > > > breaks fate > > [...] > > > I've looked into this and it's expected behavior. -codec copy is also > copying timing information (including time base), and with this patch the > Matroska/WebM muxers are respecting that. > > I could update the fate files, but before doing that I'd like to ensure > that this change in behavior for -codec copy is correct and desirable. i think the patch is a good idea it has some other issues though (see the other mail in this thread i just posted) thx [...]
--- ./tests/ref/fate/binsub-mksenc 2016-12-25 00:40:20.261173589 +0100 +++ tests/data/fate/binsub-mksenc 2016-12-28 14:01:40.073216831 +0100 @@ -1 +1 @@ -f80f42e646fce972e73aa6d99dcfa470 +6de7786a1c66b7c1be9c9a481ea5651a Test binsub-mksenc failed. Look at tests/data/fate/binsub-mksenc.err for details. make: *** [fate-binsub-mksenc] Error 1 --- ./tests/ref/fate/rgb24-mkv 2016-12-25 00:40:20.301173590 +0100 +++ tests/data/fate/rgb24-mkv 2016-12-28 14:01:41.505216862 +0100 @@ -1,5 +1,5 @@ -94cce0d7d5b14b4c86e74a1ca454c5aa *tests/data/fate/rgb24-mkv.matroska -58361 tests/data/fate/rgb24-mkv.matroska +cfc097705746aa2d8543ba217ef08237 *tests/data/fate/rgb24-mkv.matroska +58362 tests/data/fate/rgb24-mkv.matroska #tb 0: 1/10 #media_type 0: video #codec_id 0: rawvideo