diff mbox series

[FFmpeg-devel,1/4] avformat/mxf: Use AVUUID for uids

Message ID DB6PR0101MB221474D33354AA922B53D18B8FAB9@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com
State Accepted
Commit 41365fdf5c9ed96f299939a89dea7e4e257253cf
Headers show
Series [FFmpeg-devel,1/4] avformat/mxf: Use AVUUID for uids | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt June 13, 2022, 11:21 p.m. UTC
This is in preparation for using av_uuid functions directly.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavformat/mxf.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Andreas Rheinhardt June 16, 2022, 9:49 a.m. UTC | #1
Andreas Rheinhardt:
> This is in preparation for using av_uuid functions directly.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavformat/mxf.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/libavformat/mxf.h b/libavformat/mxf.h
> index d53a16df51..4d9f5119a3 100644
> --- a/libavformat/mxf.h
> +++ b/libavformat/mxf.h
> @@ -25,8 +25,9 @@
>  #include "libavutil/log.h"
>  #include "libavutil/pixfmt.h"
>  #include "libavutil/rational.h"
> +#include "libavutil/uuid.h"
>  
> -typedef uint8_t UID[16];
> +typedef AVUUID UID;
>  
>  enum MXFMetadataSetType {
>      AnyType,

Will apply this patchset later tonight unless there are objections.

- Andreas
Tomas Härdin June 16, 2022, 12:03 p.m. UTC | #2
tor 2022-06-16 klockan 11:49 +0200 skrev Andreas Rheinhardt:
> Andreas Rheinhardt:
> > This is in preparation for using av_uuid functions directly.
> > 
> > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> > ---
> >  libavformat/mxf.h | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/libavformat/mxf.h b/libavformat/mxf.h
> > index d53a16df51..4d9f5119a3 100644
> > --- a/libavformat/mxf.h
> > +++ b/libavformat/mxf.h
> > @@ -25,8 +25,9 @@
> >  #include "libavutil/log.h"
> >  #include "libavutil/pixfmt.h"
> >  #include "libavutil/rational.h"
> > +#include "libavutil/uuid.h"
> >  
> > -typedef uint8_t UID[16];
> > +typedef AVUUID UID;
> >  
> >  enum MXFMetadataSetType {
> >      AnyType,
> 
> Will apply this patchset later tonight unless there are objections.

I looked at it yesterday and it looks fine to me. Didn't remember to
email however, sorry

/Tomas
diff mbox series

Patch

diff --git a/libavformat/mxf.h b/libavformat/mxf.h
index d53a16df51..4d9f5119a3 100644
--- a/libavformat/mxf.h
+++ b/libavformat/mxf.h
@@ -25,8 +25,9 @@ 
 #include "libavutil/log.h"
 #include "libavutil/pixfmt.h"
 #include "libavutil/rational.h"
+#include "libavutil/uuid.h"
 
-typedef uint8_t UID[16];
+typedef AVUUID UID;
 
 enum MXFMetadataSetType {
     AnyType,