| Message ID | 20220628114432.52656-1-lq@chinaffmpeg.org |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel] avcodec/encode: remove the = from assert0(ret <= 0) | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | fail | Make fate failed |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | fail | Make fate failed |
| andriy/make_armv7_RPi4 | success | Make finished |
| andriy/make_fate_armv7_RPi4 | fail | Make fate failed |
Steven Liu: > Because the codec->cb.encode return 0 is successed, > so should only check negative error code. > > Signed-off-by: Steven Liu <lq@chinaffmpeg.org> > --- > libavcodec/encode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/encode.c b/libavcodec/encode.c > index b68bf1e184..5cd9615da0 100644 > --- a/libavcodec/encode.c > +++ b/libavcodec/encode.c > @@ -217,7 +217,7 @@ static int encode_simple_internal(AVCodecContext *avctx, AVPacket *avpkt) > avpkt->pts = avpkt->dts = frame->pts; > } > > - av_assert0(ret <= 0); > + av_assert0(ret < 0); > > emms_c(); > I presume you didn't test this, did you? - Andreas
diff --git a/libavcodec/encode.c b/libavcodec/encode.c index b68bf1e184..5cd9615da0 100644 --- a/libavcodec/encode.c +++ b/libavcodec/encode.c @@ -217,7 +217,7 @@ static int encode_simple_internal(AVCodecContext *avctx, AVPacket *avpkt) avpkt->pts = avpkt->dts = frame->pts; } - av_assert0(ret <= 0); + av_assert0(ret < 0); emms_c();
Because the codec->cb.encode return 0 is successed, so should only check negative error code. Signed-off-by: Steven Liu <lq@chinaffmpeg.org> --- libavcodec/encode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)