diff mbox series

[FFmpeg-devel] add HDR image format test coverage

Message ID CAPYw7P6rFFeibEmZLb+j65TOZ4HWfYWejm6zmZsJa347e3WBbg@mail.gmail.com
State New
Headers show
Series [FFmpeg-devel] add HDR image format test coverage | expand

Checks

Context Check Description
yinshiyou/configure_loongarch64 warning Failed to apply patch
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Paul B Mahol July 17, 2022, 2:51 p.m. UTC
Patch attached.

Comments

Anton Khirnov July 18, 2022, 11:16 a.m. UTC | #1
Quoting Paul B Mahol (2022-07-17 16:51:20)
> Patch attached.
> 
> From 7080795a572f8f741d4a00b2db02c8e00ce6aaf2 Mon Sep 17 00:00:00 2001
> From: Paul B Mahol <onemda@gmail.com>
> Date: Sun, 17 Jul 2022 15:12:12 +0200
> Subject: [PATCH] fate: add Radiance HDR image test
> 
> Signed-off-by: Paul B Mahol <onemda@gmail.com>
> ---
>  tests/fate/lavf-image.mak | 1 +
>  tests/ref/lavf/hdr        | 3 +++
>  2 files changed, 4 insertions(+)
>  create mode 100644 tests/ref/lavf/hdr
> 
> diff --git a/tests/fate/lavf-image.mak b/tests/fate/lavf-image.mak
> index 38d3689abf..6a87ad25a4 100644
> --- a/tests/fate/lavf-image.mak
> +++ b/tests/fate/lavf-image.mak
> @@ -52,6 +52,7 @@ FATE_LAVF_IMAGES-$(call LAVF_IMAGES,         XWD) += rgb8.xwd
>  FATE_LAVF_IMAGES-$(call LAVF_IMAGES,         XWD) += rgb4_byte.xwd
>  FATE_LAVF_IMAGES-$(call LAVF_IMAGES,         XWD) += gray.xwd
>  FATE_LAVF_IMAGES-$(call LAVF_IMAGES,         XWD) += monow.xwd
> +FATE_LAVF_IMAGES-$(call LAVF_IMAGES,         HDR) += hdr
>  
>  FATE_LAVF_IMAGES = $(FATE_LAVF_IMAGES-yes:%=fate-lavf-%)
>  
> diff --git a/tests/ref/lavf/hdr b/tests/ref/lavf/hdr
> new file mode 100644
> index 0000000000..129c309197
> --- /dev/null
> +++ b/tests/ref/lavf/hdr
> @@ -0,0 +1,3 @@
> +95961d2136160b39d71858305226f5f2 *tests/data/images/hdr/02.hdr
> +tests/data/images/hdr/%02d.hdr CRC=0x1a5ee73b
> +326788 tests/data/images/hdr/02.hdr
> -- 
> 2.36.1

The codec seems to be floating point, will this be bitexact everywhere?
Paul B Mahol July 18, 2022, 11:50 a.m. UTC | #2
On Mon, Jul 18, 2022 at 1:16 PM Anton Khirnov <anton@khirnov.net> wrote:

> Quoting Paul B Mahol (2022-07-17 16:51:20)
> > Patch attached.
> >
> > From 7080795a572f8f741d4a00b2db02c8e00ce6aaf2 Mon Sep 17 00:00:00 2001
> > From: Paul B Mahol <onemda@gmail.com>
> > Date: Sun, 17 Jul 2022 15:12:12 +0200
> > Subject: [PATCH] fate: add Radiance HDR image test
> >
> > Signed-off-by: Paul B Mahol <onemda@gmail.com>
> > ---
> >  tests/fate/lavf-image.mak | 1 +
> >  tests/ref/lavf/hdr        | 3 +++
> >  2 files changed, 4 insertions(+)
> >  create mode 100644 tests/ref/lavf/hdr
> >
> > diff --git a/tests/fate/lavf-image.mak b/tests/fate/lavf-image.mak
> > index 38d3689abf..6a87ad25a4 100644
> > --- a/tests/fate/lavf-image.mak
> > +++ b/tests/fate/lavf-image.mak
> > @@ -52,6 +52,7 @@ FATE_LAVF_IMAGES-$(call LAVF_IMAGES,         XWD) +=
> rgb8.xwd
> >  FATE_LAVF_IMAGES-$(call LAVF_IMAGES,         XWD) += rgb4_byte.xwd
> >  FATE_LAVF_IMAGES-$(call LAVF_IMAGES,         XWD) += gray.xwd
> >  FATE_LAVF_IMAGES-$(call LAVF_IMAGES,         XWD) += monow.xwd
> > +FATE_LAVF_IMAGES-$(call LAVF_IMAGES,         HDR) += hdr
> >
> >  FATE_LAVF_IMAGES = $(FATE_LAVF_IMAGES-yes:%=fate-lavf-%)
> >
> > diff --git a/tests/ref/lavf/hdr b/tests/ref/lavf/hdr
> > new file mode 100644
> > index 0000000000..129c309197
> > --- /dev/null
> > +++ b/tests/ref/lavf/hdr
> > @@ -0,0 +1,3 @@
> > +95961d2136160b39d71858305226f5f2 *tests/data/images/hdr/02.hdr
> > +tests/data/images/hdr/%02d.hdr CRC=0x1a5ee73b
> > +326788 tests/data/images/hdr/02.hdr
> > --
> > 2.36.1
>
> The codec seems to be floating point, will this be bitexact everywhere?
>
>
Look at results on patchwork.


> --
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
diff mbox series

Patch

From 7080795a572f8f741d4a00b2db02c8e00ce6aaf2 Mon Sep 17 00:00:00 2001
From: Paul B Mahol <onemda@gmail.com>
Date: Sun, 17 Jul 2022 15:12:12 +0200
Subject: [PATCH] fate: add Radiance HDR image test

Signed-off-by: Paul B Mahol <onemda@gmail.com>
---
 tests/fate/lavf-image.mak | 1 +
 tests/ref/lavf/hdr        | 3 +++
 2 files changed, 4 insertions(+)
 create mode 100644 tests/ref/lavf/hdr

diff --git a/tests/fate/lavf-image.mak b/tests/fate/lavf-image.mak
index 38d3689abf..6a87ad25a4 100644
--- a/tests/fate/lavf-image.mak
+++ b/tests/fate/lavf-image.mak
@@ -52,6 +52,7 @@  FATE_LAVF_IMAGES-$(call LAVF_IMAGES,         XWD) += rgb8.xwd
 FATE_LAVF_IMAGES-$(call LAVF_IMAGES,         XWD) += rgb4_byte.xwd
 FATE_LAVF_IMAGES-$(call LAVF_IMAGES,         XWD) += gray.xwd
 FATE_LAVF_IMAGES-$(call LAVF_IMAGES,         XWD) += monow.xwd
+FATE_LAVF_IMAGES-$(call LAVF_IMAGES,         HDR) += hdr
 
 FATE_LAVF_IMAGES = $(FATE_LAVF_IMAGES-yes:%=fate-lavf-%)
 
diff --git a/tests/ref/lavf/hdr b/tests/ref/lavf/hdr
new file mode 100644
index 0000000000..129c309197
--- /dev/null
+++ b/tests/ref/lavf/hdr
@@ -0,0 +1,3 @@ 
+95961d2136160b39d71858305226f5f2 *tests/data/images/hdr/02.hdr
+tests/data/images/hdr/%02d.hdr CRC=0x1a5ee73b
+326788 tests/data/images/hdr/02.hdr
-- 
2.36.1