diff mbox series

[FFmpeg-devel] avcodec/mpegvideo_dec: Don't sync AVCodecContext fields manually

Message ID DB6PR0101MB2214BCE4702315DE7987846C8F689@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com
State Accepted
Commit afd9da24d9da6b4a194c03779e8863b8a66ed745
Headers show
Series [FFmpeg-devel] avcodec/mpegvideo_dec: Don't sync AVCodecContext fields manually | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt Aug. 15, 2022, 4:31 p.m. UTC 
They are already synced generically in update_context_from_thread()
in pthread_frame.c.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/mpegvideo_dec.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Andreas Rheinhardt Aug. 18, 2022, 2:57 p.m. UTC | #1 
Andreas Rheinhardt:
> They are already synced generically in update_context_from_thread()
> in pthread_frame.c.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/mpegvideo_dec.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/libavcodec/mpegvideo_dec.c b/libavcodec/mpegvideo_dec.c
> index 7566fe69f9..fd706070b2 100644
> --- a/libavcodec/mpegvideo_dec.c
> +++ b/libavcodec/mpegvideo_dec.c
> @@ -92,11 +92,6 @@ int ff_mpeg_update_thread_context(AVCodecContext *dst,
>              return ret;
>      }
>  
> -    s->avctx->coded_height  = s1->avctx->coded_height;
> -    s->avctx->coded_width   = s1->avctx->coded_width;
> -    s->avctx->width         = s1->avctx->width;
> -    s->avctx->height        = s1->avctx->height;
> -
>      s->quarter_sample       = s1->quarter_sample;
>  
>      s->coded_picture_number = s1->coded_picture_number;

Will apply this patch tonight unless there are objections.

- Andreas
diff mbox series

Patch

diff --git a/libavcodec/mpegvideo_dec.c b/libavcodec/mpegvideo_dec.c
index 7566fe69f9..fd706070b2 100644
--- a/libavcodec/mpegvideo_dec.c
+++ b/libavcodec/mpegvideo_dec.c
@@ -92,11 +92,6 @@  int ff_mpeg_update_thread_context(AVCodecContext *dst,
             return ret;
     }
 
-    s->avctx->coded_height  = s1->avctx->coded_height;
-    s->avctx->coded_width   = s1->avctx->coded_width;
-    s->avctx->width         = s1->avctx->width;
-    s->avctx->height        = s1->avctx->height;
-
     s->quarter_sample       = s1->quarter_sample;
 
     s->coded_picture_number = s1->coded_picture_number;