diff mbox series

[FFmpeg-devel] sws: Don't compile yuv2yuvX for mmx

Message ID 20220819084547.2127869-1-alankelly@google.com
State New
Headers show
Series [FFmpeg-devel] sws: Don't compile yuv2yuvX for mmx | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Alan Kelly Aug. 19, 2022, 8:45 a.m. UTC
---
 libswscale/x86/yuv2yuvX.asm | 2 --
 1 file changed, 2 deletions(-)

Comments

Andreas Rheinhardt Aug. 19, 2022, 8:52 a.m. UTC | #1
Alan Kelly:
> ---
>  libswscale/x86/yuv2yuvX.asm | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/libswscale/x86/yuv2yuvX.asm b/libswscale/x86/yuv2yuvX.asm
> index b6294cb919..d5b03495fd 100644
> --- a/libswscale/x86/yuv2yuvX.asm
> +++ b/libswscale/x86/yuv2yuvX.asm
> @@ -124,8 +124,6 @@ cglobal yuv2yuvX, 7, 7, 8, filter, filterSize, src, dest, dstW, dither, offset
>      REP_RET
>  %endmacro
>  
> -INIT_MMX mmx
> -YUV2YUVX_FUNC
>  INIT_MMX mmxext
>  YUV2YUVX_FUNC
>  INIT_XMM sse3

Already sent exactly the same patch:
https://ffmpeg.org/pipermail/ffmpeg-devel/2022-August/300247.html
(I wanted to remove this function in
a05f22eaf393177b94432431c145cbc5ba10390a, but noticed that you used it
for unaligned data and tail processing and I did not know whether this
was intentional or not.)

- Andreas
Alan Kelly Aug. 19, 2022, 11:07 a.m. UTC | #2
Thanks for doing this!

On Fri, Aug 19, 2022 at 10:53 AM Andreas Rheinhardt <
andreas.rheinhardt@outlook.com> wrote:

> Alan Kelly:
> > ---
> >  libswscale/x86/yuv2yuvX.asm | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/libswscale/x86/yuv2yuvX.asm b/libswscale/x86/yuv2yuvX.asm
> > index b6294cb919..d5b03495fd 100644
> > --- a/libswscale/x86/yuv2yuvX.asm
> > +++ b/libswscale/x86/yuv2yuvX.asm
> > @@ -124,8 +124,6 @@ cglobal yuv2yuvX, 7, 7, 8, filter, filterSize, src,
> dest, dstW, dither, offset
> >      REP_RET
> >  %endmacro
> >
> > -INIT_MMX mmx
> > -YUV2YUVX_FUNC
> >  INIT_MMX mmxext
> >  YUV2YUVX_FUNC
> >  INIT_XMM sse3
>
> Already sent exactly the same patch:
> https://ffmpeg.org/pipermail/ffmpeg-devel/2022-August/300247.html
> (I wanted to remove this function in
> a05f22eaf393177b94432431c145cbc5ba10390a, but noticed that you used it
> for unaligned data and tail processing and I did not know whether this
> was intentional or not.)
>
> - Andreas
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
diff mbox series

Patch

diff --git a/libswscale/x86/yuv2yuvX.asm b/libswscale/x86/yuv2yuvX.asm
index b6294cb919..d5b03495fd 100644
--- a/libswscale/x86/yuv2yuvX.asm
+++ b/libswscale/x86/yuv2yuvX.asm
@@ -124,8 +124,6 @@  cglobal yuv2yuvX, 7, 7, 8, filter, filterSize, src, dest, dstW, dither, offset
     REP_RET
 %endmacro
 
-INIT_MMX mmx
-YUV2YUVX_FUNC
 INIT_MMX mmxext
 YUV2YUVX_FUNC
 INIT_XMM sse3