[FFmpeg-devel] ffmpeg.c: Add output file index and stream index to vstats file.

Signed-off-by: Sasi Inguva <isasi@google.com>
---
 ffmpeg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

On Thu, Jan 19, 2017 at 02:34:14PM -0800, Sasi Inguva wrote:
> Signed-off-by: Sasi Inguva <isasi@google.com>
> ---
>  ffmpeg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ffmpeg.c b/ffmpeg.c
> index 977708c069..a566c3fe2a 100644
> --- a/ffmpeg.c
> +++ b/ffmpeg.c
> @@ -1347,7 +1347,7 @@ static void do_video_stats(OutputStream *ost, int frame_size)
>      enc = ost->enc_ctx;
>      if (enc->codec_type == AVMEDIA_TYPE_VIDEO) {
>          frame_number = ost->st->nb_frames;
> -        fprintf(vstats_file, "frame= %5d q= %2.1f ", frame_number,
> +        fprintf(vstats_file, "out= %2d st= %2d frame= %5d q= %2.1f ", ost->file_index, ost->index, frame_number,
>                  ost->quality / (float)FF_QP2LAMBDA);

Should this be under a check for vstats version ?
So as not to break any code using the vstats file or is there some
declaration in our docs that the format may change at any time ?

[...]

Couldn't find any version that relates to vstats. There is nothing that
says format may change any time , but there is no defined format either.
Let me know the version enum I have to update if I need to.

On Fri, Jan 20, 2017 at 4:18 PM, Michael Niedermayer <michaelni@gmx.at>
wrote:

> On Thu, Jan 19, 2017 at 02:34:14PM -0800, Sasi Inguva wrote:
> > Signed-off-by: Sasi Inguva <isasi@google.com>
> > ---
> >  ffmpeg.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/ffmpeg.c b/ffmpeg.c
> > index 977708c069..a566c3fe2a 100644
> > --- a/ffmpeg.c
> > +++ b/ffmpeg.c
> > @@ -1347,7 +1347,7 @@ static void do_video_stats(OutputStream *ost, int
> frame_size)
> >      enc = ost->enc_ctx;
> >      if (enc->codec_type == AVMEDIA_TYPE_VIDEO) {
> >          frame_number = ost->st->nb_frames;
> > -        fprintf(vstats_file, "frame= %5d q= %2.1f ", frame_number,
> > +        fprintf(vstats_file, "out= %2d st= %2d frame= %5d q= %2.1f ",
> ost->file_index, ost->index, frame_number,
> >                  ost->quality / (float)FF_QP2LAMBDA);
>
> Should this be under a check for vstats version ?
> So as not to break any code using the vstats file or is there some
> declaration in our docs that the format may change at any time ?
>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> In a rich man's house there is no place to spit but his face.
> -- Diogenes of Sinope
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>

On Fri, Jan 20, 2017 at 07:31:09PM -0800, Sasi Inguva wrote:
> Couldn't find any version that relates to vstats. There is nothing that
> says format may change any time , but there is no defined format either.
> Let me know the version enum I have to update if I need to.

i dont think theres a enum
I think the way to resolve this is to send a patch that updates the
docs and either state that vstats format can change at any time or
that it cannot in which case something like a -vtstats_version
parameter would need to be added

When the docs patch passes review, that is everyone is happy with the
solution it describes then the change with or without a version
check which either way then matches the docs can be pushed

thx

[...]

Thanks. I have sent a patch introducing -vstats_version option. PTAL.

On Sat, Jan 21, 2017 at 3:52 AM, Michael Niedermayer <michaelni@gmx.at>
wrote:

> On Fri, Jan 20, 2017 at 07:31:09PM -0800, Sasi Inguva wrote:
> > Couldn't find any version that relates to vstats. There is nothing that
> > says format may change any time , but there is no defined format either.
> > Let me know the version enum I have to update if I need to.
>
> i dont think theres a enum
> I think the way to resolve this is to send a patch that updates the
> docs and either state that vstats format can change at any time or
> that it cannot in which case something like a -vtstats_version
> parameter would need to be added
>
> When the docs patch passes review, that is everyone is happy with the
> solution it describes then the change with or without a version
> check which either way then matches the docs can be pushed
>
> thx
>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Dictatorship: All citizens are under surveillance, all their steps and
> actions recorded, for the politicians to enforce control.
> Democracy: All politicians are under surveillance, all their steps and
> actions recorded, for the citizens to enforce control.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>