Message ID | 1484980334-15017-1-git-send-email-thomastdt@googlemail.com |
---|---|
State | New |
Headers | show |
On Fri, Jan 20, 2017 at 10:32:14PM -0800, Thomas Turner wrote: > If als_07_2ch192k32bF.mp4 isn't already located in fate-suite/lossless-audio/, you can download at: > > http://standards.iso.org/ittf/PubliclyAvailableStandards/ISO_IEC_14496-26_2010_Bitstreams/DVD1/mpeg4audio-conformance/compressedMp4/als_07_2ch192k32bF.mp4 > > Reference file can be found at: > > https://dl.dropboxusercontent.com/u/1519724/als_07_2ch192k32bF.f32 is the (8mb) length needed to achive full coverage ? or would a shorter reference be enough ? it seems to pass on qemu mips & arm, mingw32/64 and linux32/64 thx [...]
Am 21.01.17 um 13:33 schrieb Michael Niedermayer: > On Fri, Jan 20, 2017 at 10:32:14PM -0800, Thomas Turner wrote: >> If als_07_2ch192k32bF.mp4 isn't already located in fate-suite/lossless-audio/, you can download at: >> >> http://standards.iso.org/ittf/PubliclyAvailableStandards/ISO_IEC_14496-26_2010_Bitstreams/DVD1/mpeg4audio-conformance/compressedMp4/als_07_2ch192k32bF.mp4 >> >> Reference file can be found at: >> >> https://dl.dropboxusercontent.com/u/1519724/als_07_2ch192k32bF.f32 > > is the (8mb) length needed to achive full coverage ? > or would a shorter reference be enough ? A shorter one should work but IIRC we also use other (large) ALS conformance files for FATE. There are especially issues with unspecified behavior during the last frames which is why I'd like to keep these files for regression tests. So this one should also be taken as is if at all possible. -Thilo
On Sun, Jan 22, 2017 at 01:17:20PM +0100, Thilo Borgmann wrote: > Am 21.01.17 um 13:33 schrieb Michael Niedermayer: > > On Fri, Jan 20, 2017 at 10:32:14PM -0800, Thomas Turner wrote: > >> If als_07_2ch192k32bF.mp4 isn't already located in fate-suite/lossless-audio/, you can download at: > >> > >> http://standards.iso.org/ittf/PubliclyAvailableStandards/ISO_IEC_14496-26_2010_Bitstreams/DVD1/mpeg4audio-conformance/compressedMp4/als_07_2ch192k32bF.mp4 > >> > >> Reference file can be found at: > >> > >> https://dl.dropboxusercontent.com/u/1519724/als_07_2ch192k32bF.f32 > > > > is the (8mb) length needed to achive full coverage ? > > or would a shorter reference be enough ? > > A shorter one should work but IIRC we also use other (large) ALS conformance files for FATE. > > There are especially issues with unspecified behavior during the last frames which is why I'd like to keep these files for regression tests. So this one should also be taken as is if at all possible. ok, uploaded as it was in the link above the issue with large files and growing fatesamples is that some fate clients will run out of space if the samples grow too much. As far as my fate clients are concerned its not a real problem, just some work setting bigger VMs up and maybe getting a bigger SSD eventually. [...]
diff --git a/tests/fate/als.mak b/tests/fate/als.mak index ff2badf..1f4c88f 100644 --- a/tests/fate/als.mak +++ b/tests/fate/als.mak @@ -7,5 +7,9 @@ endef $(foreach N,$(ALS_SUITE),$(eval $(call FATE_ALS_SUITE,$(N)))) +FATE_ALS += fate-mpeg4-als-conformance-07 +fate-mpeg4-als-conformance-07: CMD = ffmpeg -i $(TARGET_SAMPLES)/lossless-audio/als_07_2ch192k32bF.mp4 -af atrim=end_sample=958446 -f f32le - +fate-mpeg4-als-conformance-07: REF = $(TARGET_SAMPLES)/audio-reference/als_07_2ch192k32bF.f32 + FATE_SAMPLES_AVCONV-$(call DEMDEC, MOV, ALS) += $(FATE_ALS) fate-als: $(FATE_ALS)
If als_07_2ch192k32bF.mp4 isn't already located in fate-suite/lossless-audio/, you can download at: http://standards.iso.org/ittf/PubliclyAvailableStandards/ISO_IEC_14496-26_2010_Bitstreams/DVD1/mpeg4audio-conformance/compressedMp4/als_07_2ch192k32bF.mp4 Reference file can be found at: https://dl.dropboxusercontent.com/u/1519724/als_07_2ch192k32bF.f32 Signed-off-by: Thomas Turner <thomastdt@googlemail.com> --- tests/fate/als.mak | 4 ++++ 1 file changed, 4 insertions(+)