mbox

[FFmpeg-devel,0/8] rewrite avpriv_find_start_code() for clarity

Message ID 20220201212056.29712-1-scott.the.elm@gmail.com
Headers show

Message

Scott Theisen Feb. 1, 2022, 9:20 p.m. UTC 
I am endeavoring to reduce MythTV’s downstream changes to FFmpeg.
avpriv_find_start_code() is one of the internal FFmpeg functions that
MythTV uses.

I was planning on copying it into MythTV to eventually eliminate all
uses of internal FFmpeg headers; however, what avpriv_find_start_code()
actually does was not very clear.  Therefore, I rewrote it and added
comments to make its purpose and effects clearer.

Comments

Scott Theisen Sept. 16, 2022, 6:26 p.m. UTC | #1 
On 9/16/22 14:19, Scott Theisen wrote:
> My modified versions of avpriv_find_start_code were accepted into MythTV,
> which caused clang-tidy to raise a bugprone-branch-clone warning.  The
> for loop's if statement has therefore been modified to not duplicate

This should say while loop.

> the branch payload.
>
> There are no other changes from v3.
>
> Regards,
>
> Scott Theisen
>
>
>