| Message ID | 20220926083449.70287-1-wenbin.chen@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel,1/2] libavcodec/qsvenc: Let runtime to set default parameter. | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
Wenbin Chen: > Unset qsv_h264 and qsv_hevc's default settings. Let runtime to decide > these parameters, so that it can choose the best parameter and ffmpeg-qsv > can keep up with runtime's update. > > Signed-off-by: Wenbin Chen <wenbin.chen@intel.com> > --- > libavcodec/qsvenc_h264.c | 4 ++-- > libavcodec/qsvenc_hevc.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/qsvenc_h264.c b/libavcodec/qsvenc_h264.c > index 85826ae4be..fe777a6ae3 100644 > --- a/libavcodec/qsvenc_h264.c > +++ b/libavcodec/qsvenc_h264.c > @@ -177,8 +177,8 @@ static const FFCodecDefault qsv_enc_defaults[] = { > { "b", "1M" }, > { "refs", "0" }, > // same as the x264 default > - { "g", "250" }, > - { "bf", "3" }, > + { "g", "-1" }, > + { "bf", "-1" }, > { "qmin", "-1" }, > { "qmax", "-1" }, > { "trellis", "-1" }, > diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c > index 6ec6230999..0c5bec231d 100644 > --- a/libavcodec/qsvenc_hevc.c > +++ b/libavcodec/qsvenc_hevc.c > @@ -290,7 +290,7 @@ static const FFCodecDefault qsv_enc_defaults[] = { > { "b", "1M" }, > { "refs", "0" }, > // same as the x264 default These comments are now wrong. > - { "g", "248" }, > + { "g", "-1" }, > { "bf", "-1" }, > { "qmin", "-1" }, > { "qmax", "-1" },
> Wenbin Chen: > > Unset qsv_h264 and qsv_hevc's default settings. Let runtime to decide > > these parameters, so that it can choose the best parameter and ffmpeg-qsv > > can keep up with runtime's update. > > > > Signed-off-by: Wenbin Chen <wenbin.chen@intel.com> > > --- > > libavcodec/qsvenc_h264.c | 4 ++-- > > libavcodec/qsvenc_hevc.c | 2 +- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/libavcodec/qsvenc_h264.c b/libavcodec/qsvenc_h264.c > > index 85826ae4be..fe777a6ae3 100644 > > --- a/libavcodec/qsvenc_h264.c > > +++ b/libavcodec/qsvenc_h264.c > > @@ -177,8 +177,8 @@ static const FFCodecDefault qsv_enc_defaults[] = { > > { "b", "1M" }, > > { "refs", "0" }, > > // same as the x264 default > > - { "g", "250" }, > > - { "bf", "3" }, > > + { "g", "-1" }, > > + { "bf", "-1" }, > > { "qmin", "-1" }, > > { "qmax", "-1" }, > > { "trellis", "-1" }, > > diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c > > index 6ec6230999..0c5bec231d 100644 > > --- a/libavcodec/qsvenc_hevc.c > > +++ b/libavcodec/qsvenc_hevc.c > > @@ -290,7 +290,7 @@ static const FFCodecDefault qsv_enc_defaults[] = { > > { "b", "1M" }, > > { "refs", "0" }, > > // same as the x264 default > > These comments are now wrong. Forget these comments. I will update them in new patchset. Thanks Wenbin > > > - { "g", "248" }, > > + { "g", "-1" }, > > { "bf", "-1" }, > > { "qmin", "-1" }, > > { "qmax", "-1" }, > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff --git a/libavcodec/qsvenc_h264.c b/libavcodec/qsvenc_h264.c index 85826ae4be..fe777a6ae3 100644 --- a/libavcodec/qsvenc_h264.c +++ b/libavcodec/qsvenc_h264.c @@ -177,8 +177,8 @@ static const FFCodecDefault qsv_enc_defaults[] = { { "b", "1M" }, { "refs", "0" }, // same as the x264 default - { "g", "250" }, - { "bf", "3" }, + { "g", "-1" }, + { "bf", "-1" }, { "qmin", "-1" }, { "qmax", "-1" }, { "trellis", "-1" }, diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c index 6ec6230999..0c5bec231d 100644 --- a/libavcodec/qsvenc_hevc.c +++ b/libavcodec/qsvenc_hevc.c @@ -290,7 +290,7 @@ static const FFCodecDefault qsv_enc_defaults[] = { { "b", "1M" }, { "refs", "0" }, // same as the x264 default - { "g", "248" }, + { "g", "-1" }, { "bf", "-1" }, { "qmin", "-1" }, { "qmax", "-1" },
Unset qsv_h264 and qsv_hevc's default settings. Let runtime to decide these parameters, so that it can choose the best parameter and ffmpeg-qsv can keep up with runtime's update. Signed-off-by: Wenbin Chen <wenbin.chen@intel.com> --- libavcodec/qsvenc_h264.c | 4 ++-- libavcodec/qsvenc_hevc.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)