| Message ID | 20221005144355.958665-1-tmatth@videolan.org |
|---|---|
| State | Accepted |
| Commit | eb9153b4a73f4d6e313206588eb7c03d1f4c12b8 |
| Headers | show |
| Series | [FFmpeg-devel] avformat/hls: fix spelling and grammar on wrap warning | expand |
| Context | Check | Description |
|---|---|---|
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
Tristan Matthews <tmatth@videolan.org> 于2022年10月5日周三 22:44写道： > > --- > libavformat/hls.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index e622425e80..402eb2b5a0 100644 > --- a/libavformat/hls.c > +++ b/libavformat/hls.c > @@ -1527,7 +1527,7 @@ reload: > return AVERROR_EOF; > } > } else { > - av_log(v->parent, AV_LOG_WARNING, "maybe the m3u8 list sequence have been wraped.\n"); > + av_log(v->parent, AV_LOG_WARNING, "The m3u8 list sequence may have been wrapped.\n"); > } > if (v->cur_seq_no >= v->start_seq_no + v->n_segments) { > if (v->finished) > -- > 2.34.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". English is not my native language, but this look ok to me. Waiting for familiarity with English reviewer comments. Thanks Steven
On 2022-10-05 08:59 pm, Steven Liu wrote: > Tristan Matthews <tmatth@videolan.org> 于2022年10月5日周三 22:44写道： >> --- >> libavformat/hls.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavformat/hls.c b/libavformat/hls.c >> index e622425e80..402eb2b5a0 100644 >> --- a/libavformat/hls.c >> +++ b/libavformat/hls.c >> @@ -1527,7 +1527,7 @@ reload: >> return AVERROR_EOF; >> } >> } else { >> - av_log(v->parent, AV_LOG_WARNING, "maybe the m3u8 list sequence have been wraped.\n"); >> + av_log(v->parent, AV_LOG_WARNING, "The m3u8 list sequence may have been wrapped.\n"); >> } >> if (v->cur_seq_no >= v->start_seq_no + v->n_segments) { >> if (v->finished) >> -- >> 2.34.1 >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > English is not my native language, but this look ok to me. > Waiting for familiarity with English reviewer comments. LGTM. Regards, Gyan
On Fri, Oct 7, 2022 at 1:41 AM Gyan Doshi <ffmpeg@gyani.pro> wrote: > > > On 2022-10-05 08:59 pm, Steven Liu wrote: > > Tristan Matthews <tmatth@videolan.org> 于2022年10月5日周三 22:44写道： > >> --- > >> libavformat/hls.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/libavformat/hls.c b/libavformat/hls.c > >> index e622425e80..402eb2b5a0 100644 > >> --- a/libavformat/hls.c > >> +++ b/libavformat/hls.c > >> @@ -1527,7 +1527,7 @@ reload: > >> return AVERROR_EOF; > >> } > >> } else { > >> - av_log(v->parent, AV_LOG_WARNING, "maybe the m3u8 list > sequence have been wraped.\n"); > >> + av_log(v->parent, AV_LOG_WARNING, "The m3u8 list sequence > may have been wrapped.\n"); > >> } > >> if (v->cur_seq_no >= v->start_seq_no + v->n_segments) { > >> if (v->finished) > >> -- > >> 2.34.1 > >> > >> _______________________________________________ > >> ffmpeg-devel mailing list > >> ffmpeg-devel@ffmpeg.org > >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >> > >> To unsubscribe, visit link above, or email > >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > English is not my native language, but this look ok to me. > > Waiting for familiarity with English reviewer comments. > > LGTM. > Ping? Best, -t
On 2022-10-19 08:33 pm, Tristan Matthews wrote: > On Fri, Oct 7, 2022 at 1:41 AM Gyan Doshi <ffmpeg@gyani.pro> wrote: > >> >> On 2022-10-05 08:59 pm, Steven Liu wrote: >>> Tristan Matthews <tmatth@videolan.org> 于2022年10月5日周三 22:44写道： >>>> --- >>>> libavformat/hls.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/libavformat/hls.c b/libavformat/hls.c >>>> index e622425e80..402eb2b5a0 100644 >>>> --- a/libavformat/hls.c >>>> +++ b/libavformat/hls.c >>>> @@ -1527,7 +1527,7 @@ reload: >>>> return AVERROR_EOF; >>>> } >>>> } else { >>>> - av_log(v->parent, AV_LOG_WARNING, "maybe the m3u8 list >> sequence have been wraped.\n"); >>>> + av_log(v->parent, AV_LOG_WARNING, "The m3u8 list sequence >> may have been wrapped.\n"); >>>> } >>>> if (v->cur_seq_no >= v->start_seq_no + v->n_segments) { >>>> if (v->finished) >>>> -- >>>> 2.34.1 >>>> >>>> _______________________________________________ >>>> ffmpeg-devel mailing list >>>> ffmpeg-devel@ffmpeg.org >>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>>> >>>> To unsubscribe, visit link above, or email >>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >>> English is not my native language, but this look ok to me. >>> Waiting for familiarity with English reviewer comments. >> LGTM. >> > Ping? Will push. Regards, Gyan
diff --git a/libavformat/hls.c b/libavformat/hls.c index e622425e80..402eb2b5a0 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -1527,7 +1527,7 @@ reload: return AVERROR_EOF; } } else { - av_log(v->parent, AV_LOG_WARNING, "maybe the m3u8 list sequence have been wraped.\n"); + av_log(v->parent, AV_LOG_WARNING, "The m3u8 list sequence may have been wrapped.\n"); } if (v->cur_seq_no >= v->start_seq_no + v->n_segments) { if (v->finished)