diff mbox series

[FFmpeg-devel,8/9] checkasm/vp8dsp: Use declare_func_emms only when needed

Message ID GV1P250MB07378CAD9A289989F3AA36A18F5E9@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM
State Accepted
Commit bcfa427c8f91581c30ce2bd00f836e670d8bb365
Headers show
Series [FFmpeg-devel,1/9] checkasm/vc1dsp: Use declare_func_emms only when needed | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt Oct. 8, 2022, 1:24 a.m. UTC 
There is no MMX code for loop filters since commit
6a551f14050674fb685920eb1b0640810cacccf9, so use declare_func
instead of declare_func_emms() to also test that we are not
in MMX mode after return.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 tests/checkasm/vp8dsp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Ronald S. Bultje Oct. 8, 2022, 2:01 a.m. UTC | #1 
Hi,

On Fri, Oct 7, 2022 at 9:25 PM Andreas Rheinhardt <
andreas.rheinhardt@outlook.com> wrote:

> There is no MMX code for loop filters since commit
> 6a551f14050674fb685920eb1b0640810cacccf9, so use declare_func
> instead of declare_func_emms() to also test that we are not
> in MMX mode after return.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  tests/checkasm/vp8dsp.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>

LGTM.

Ronald
diff mbox series

Patch

diff --git a/tests/checkasm/vp8dsp.c b/tests/checkasm/vp8dsp.c
index c3af54fbfd..87b03d71d5 100644
--- a/tests/checkasm/vp8dsp.c
+++ b/tests/checkasm/vp8dsp.c
@@ -384,7 +384,7 @@  static void check_loopfilter_16y(void)
     VP8DSPContext d;
     int dir, edge, force_hev;
     int flim_E = 20, flim_I = 10, hev_thresh = 7;
-    declare_func_emms(AV_CPU_FLAG_MMX, void, uint8_t *, ptrdiff_t, int, int, int);
+    declare_func(void, uint8_t *, ptrdiff_t, int, int, int);
 
     ff_vp8dsp_init(&d);
 
@@ -430,7 +430,7 @@  static void check_loopfilter_8uv(void)
     VP8DSPContext d;
     int dir, edge, force_hev;
     int flim_E = 20, flim_I = 10, hev_thresh = 7;
-    declare_func_emms(AV_CPU_FLAG_MMX, void, uint8_t *, uint8_t *, ptrdiff_t, int, int, int);
+    declare_func(void, uint8_t *, uint8_t *, ptrdiff_t, int, int, int);
 
     ff_vp8dsp_init(&d);
 
@@ -481,7 +481,7 @@  static void check_loopfilter_simple(void)
     VP8DSPContext d;
     int dir;
     int flim_E = 20, flim_I = 30, hev_thresh = 0;
-    declare_func_emms(AV_CPU_FLAG_MMX, void, uint8_t *, ptrdiff_t, int);
+    declare_func(void, uint8_t *, ptrdiff_t, int);
 
     ff_vp8dsp_init(&d);