| Message ID | 20230102155028.13815-1-ting.fu@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel,V2,1/2] lavfi/dnn: Modify error message for incorrect backend_type | expand |
| Context | Check | Description |
|---|---|---|
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
> -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > Ting Fu > Sent: Monday, January 2, 2023 11:50 PM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH V2 1/2] lavfi/dnn: Modify error message for > incorrect backend_type > > Signed-off-by: Ting Fu <ting.fu@intel.com> > --- > libavfilter/dnn/dnn_interface.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/dnn/dnn_interface.c b/libavfilter/dnn/dnn_interface.c > index 554a36b0dc..fa484c0905 100644 > --- a/libavfilter/dnn/dnn_interface.c > +++ b/libavfilter/dnn/dnn_interface.c > @@ -71,7 +71,7 @@ DNNModule *ff_get_dnn_module(DNNBackendType > backend_type) > #endif > break; > default: > - av_log(NULL, AV_LOG_ERROR, "Module backend_type is not native or > tensorflow\n"); > + av_log(NULL, AV_LOG_ERROR, "Module backend_type is not > + supported or enabled.\n"); We need to remove "case DNN_NATIVE:" in this patch, and so native backend will go here 'default:'. > av_freep(&dnn_module); > return NULL; > } Please also update doc/filters.texi in this commit, thanks.
> -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Guo, > Yejun > Sent: Thursday, January 5, 2023 09:07 AM > To: FFmpeg development discussions and patches <ffmpeg- > devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH V2 1/2] lavfi/dnn: Modify error message > for incorrect backend_type > > > > > -----Original Message----- > > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > Ting > > Fu > > Sent: Monday, January 2, 2023 11:50 PM > > To: ffmpeg-devel@ffmpeg.org > > Subject: [FFmpeg-devel] [PATCH V2 1/2] lavfi/dnn: Modify error message > > for incorrect backend_type > > > > Signed-off-by: Ting Fu <ting.fu@intel.com> > > --- > > libavfilter/dnn/dnn_interface.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavfilter/dnn/dnn_interface.c > > b/libavfilter/dnn/dnn_interface.c index 554a36b0dc..fa484c0905 100644 > > --- a/libavfilter/dnn/dnn_interface.c > > +++ b/libavfilter/dnn/dnn_interface.c > > @@ -71,7 +71,7 @@ DNNModule *ff_get_dnn_module(DNNBackendType > > backend_type) > > #endif > > break; > > default: > > - av_log(NULL, AV_LOG_ERROR, "Module backend_type is not native or > > tensorflow\n"); > > + av_log(NULL, AV_LOG_ERROR, "Module backend_type is not > > + supported or enabled.\n"); > > We need to remove "case DNN_NATIVE:" in this patch, and so native > backend will go here 'default:'. Hi Yejun, Updated it in PATCH V3. > > > av_freep(&dnn_module); > > return NULL; > > } > > Please also update doc/filters.texi in this commit, thanks. Sure, I delete the native part in doc/filers.texi and its related files in tools/python/, and make it three commits. Hope this make sense. Thank you Ting Fu > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org > with subject "unsubscribe".
diff --git a/libavfilter/dnn/dnn_interface.c b/libavfilter/dnn/dnn_interface.c index 554a36b0dc..fa484c0905 100644 --- a/libavfilter/dnn/dnn_interface.c +++ b/libavfilter/dnn/dnn_interface.c @@ -71,7 +71,7 @@ DNNModule *ff_get_dnn_module(DNNBackendType backend_type) #endif break; default: - av_log(NULL, AV_LOG_ERROR, "Module backend_type is not native or tensorflow\n"); + av_log(NULL, AV_LOG_ERROR, "Module backend_type is not supported or enabled.\n"); av_freep(&dnn_module); return NULL; }
Signed-off-by: Ting Fu <ting.fu@intel.com> --- libavfilter/dnn/dnn_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)