diff mbox series

[FFmpeg-devel,V3,1/3] lavfi/dnn: Mark native backend as deprecated

Message ID 20230106090142.28445-1-ting.fu@intel.com
State New
Headers show
Series [FFmpeg-devel,V3,1/3] lavfi/dnn: Mark native backend as deprecated | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Ting Fu Jan. 6, 2023, 9:01 a.m. UTC
Mark native as deprecated for backed_type option. Modify realted error
message.

Signed-off-by: Ting Fu <ting.fu@intel.com>
---
 libavfilter/dnn/dnn_interface.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

Comments

Ting Fu Jan. 6, 2023, 9:38 a.m. UTC | #1
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Ting
> Fu
> Sent: Friday, January 6, 2023 05:02 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH V3 1/3] lavfi/dnn: Mark native backend as
> deprecated
> 
> Mark native as deprecated for backed_type option. Modify realted error
> message.
> 
> Signed-off-by: Ting Fu <ting.fu@intel.com>
> ---
>  libavfilter/dnn/dnn_interface.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
Sorry for the incorrect patch, please omit V3 and check V4.
[...]
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org
> with subject "unsubscribe".
diff mbox series

Patch

diff --git a/libavfilter/dnn/dnn_interface.c b/libavfilter/dnn/dnn_interface.c
index 554a36b0dc..12d36f7fed 100644
--- a/libavfilter/dnn/dnn_interface.c
+++ b/libavfilter/dnn/dnn_interface.c
@@ -24,7 +24,6 @@ 
  */
 
 #include "../dnn_interface.h"
-#include "dnn_backend_native.h"
 #include "dnn_backend_tf.h"
 #include "dnn_backend_openvino.h"
 #include "libavutil/mem.h"
@@ -40,12 +39,9 @@  DNNModule *ff_get_dnn_module(DNNBackendType backend_type)
 
     switch(backend_type){
     case DNN_NATIVE:
-        dnn_module->load_model = &ff_dnn_load_model_native;
-        dnn_module->execute_model = &ff_dnn_execute_model_native;
-        dnn_module->get_result = &ff_dnn_get_result_native;
-        dnn_module->flush = &ff_dnn_flush_native;
-        dnn_module->free_model = &ff_dnn_free_model_native;
-        break;
+        av_log(NULL, AV_LOG_ERROR, "Native backend is deprecated, please use other supported DNN backends.\n");
+        av_freep(&dnn_module);
+        return NULL;
     case DNN_TF:
     #if (CONFIG_LIBTENSORFLOW == 1)
         dnn_module->load_model = &ff_dnn_load_model_tf;
@@ -71,7 +67,7 @@  DNNModule *ff_get_dnn_module(DNNBackendType backend_type)
     #endif
         break;
     default:
-        av_log(NULL, AV_LOG_ERROR, "Module backend_type is not native or tensorflow\n");
+        av_log(NULL, AV_LOG_ERROR, "Module backend_type is not supported or enabled.\n");
         av_freep(&dnn_module);
         return NULL;
     }