diff mbox series

[FFmpeg-devel,1/2] lavfi/coreimage: suppress OpenGL deprecation warning

Message ID 20230225152658.3086653-1-mypopydev@gmail.com
State New
Headers show
Series [FFmpeg-devel,1/2] lavfi/coreimage: suppress OpenGL deprecation warning | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Jun Zhao Feb. 25, 2023, 3:26 p.m. UTC 
From: Jun Zhao <barryjzhao@tencent.com>

suppress OpenGL deprecation warning.

Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
---
 libavfilter/vf_coreimage.m | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Thilo Borgmann Feb. 25, 2023, 5:48 p.m. UTC | #1 
Am 25.02.23 um 16:26 schrieb Jun Zhao:
> From: Jun Zhao <barryjzhao@tencent.com>
> 
> suppress OpenGL deprecation warning.
> 
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> ---
>   libavfilter/vf_coreimage.m | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/libavfilter/vf_coreimage.m b/libavfilter/vf_coreimage.m
> index b1959861de..17b2cde6fe 100644
> --- a/libavfilter/vf_coreimage.m
> +++ b/libavfilter/vf_coreimage.m
> @@ -22,7 +22,8 @@
>    * @file
>    * Video processing based on Apple's CoreImage API
>    */
> -
> +#define GL_SILENCE_DEPRECATION
> +#define CI_SILENCE_GL_DEPRECATION
>   #import <CoreImage/CoreImage.h>
>   #import <AppKit/AppKit.h>

Why do you want to silence a framework warning?

-Thilo
Jun Zhao Feb. 26, 2023, 1:42 a.m. UTC | #2 
On Sun, Feb 26, 2023 at 1:48 AM Thilo Borgmann <thilo.borgmann@mail.de> wrote:
>
> Am 25.02.23 um 16:26 schrieb Jun Zhao:
> > From: Jun Zhao <barryjzhao@tencent.com>
> >
> > suppress OpenGL deprecation warning.
> >
> > Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> > ---
> >   libavfilter/vf_coreimage.m | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavfilter/vf_coreimage.m b/libavfilter/vf_coreimage.m
> > index b1959861de..17b2cde6fe 100644
> > --- a/libavfilter/vf_coreimage.m
> > +++ b/libavfilter/vf_coreimage.m
> > @@ -22,7 +22,8 @@
> >    * @file
> >    * Video processing based on Apple's CoreImage API
> >    */
> > -
> > +#define GL_SILENCE_DEPRECATION
> > +#define CI_SILENCE_GL_DEPRECATION
> >   #import <CoreImage/CoreImage.h>
> >   #import <AppKit/AppKit.h>
>
> Why do you want to silence a framework warning?
>
Ok, will drop the fix
diff mbox series

Patch

diff --git a/libavfilter/vf_coreimage.m b/libavfilter/vf_coreimage.m
index b1959861de..17b2cde6fe 100644
--- a/libavfilter/vf_coreimage.m
+++ b/libavfilter/vf_coreimage.m
@@ -22,7 +22,8 @@ 
  * @file
  * Video processing based on Apple's CoreImage API
  */
-
+#define GL_SILENCE_DEPRECATION
+#define CI_SILENCE_GL_DEPRECATION
 #import <CoreImage/CoreImage.h>
 #import <AppKit/AppKit.h>