diff mbox series

[FFmpeg-devel,1/2] avcodec/libvpxdec: remove unnecessary init_static_data function

Message ID 20230228120650.1539-1-jamrial@gmail.com
State Accepted
Commit 8d226fb9786f34760e80e0d6b403bd63e9ac4ddd
Headers show
Series [FFmpeg-devel,1/2] avcodec/libvpxdec: remove unnecessary init_static_data function | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

James Almer Feb. 28, 2023, 12:06 p.m. UTC 
It's used only by the encoder.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavcodec/libvpxdec.c | 1 -
 1 file changed, 1 deletion(-)

Comments

James Zern Feb. 28, 2023, 8:40 p.m. UTC | #1 
On Tue, Feb 28, 2023 at 4:07 AM James Almer <jamrial@gmail.com> wrote:
>
> It's used only by the encoder.
>

It sets AVCodec.pix_fmts, but maybe the values reported aren't used
meaningfully.

> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavcodec/libvpxdec.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c
> index 0ae19c3f72..8e6291fe20 100644
> --- a/libavcodec/libvpxdec.c
> +++ b/libavcodec/libvpxdec.c
> @@ -391,6 +391,5 @@ FFCodec ff_libvpx_vp9_decoder = {
>      FF_CODEC_DECODE_CB(vpx_decode),
>      .caps_internal  = FF_CODEC_CAP_NOT_INIT_THREADSAFE |
>                        FF_CODEC_CAP_AUTO_THREADS,
> -    .init_static_data = ff_vp9_init_static,
>  };
>  #endif /* CONFIG_LIBVPX_VP9_DECODER */
> --
> 2.39.2
>
James Almer Feb. 28, 2023, 8:49 p.m. UTC | #2 
On 2/28/2023 5:40 PM, James Zern wrote:
> On Tue, Feb 28, 2023 at 4:07 AM James Almer <jamrial@gmail.com> wrote:
>>
>> It's used only by the encoder.
>>
> 
> It sets AVCodec.pix_fmts, but maybe the values reported aren't used
> meaningfully.

Indeed, they aren't. AVCodec.pix_fmts is a list of formats an encoder 
accepts as input. Decoders don't use that array.

> 
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>>   libavcodec/libvpxdec.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c
>> index 0ae19c3f72..8e6291fe20 100644
>> --- a/libavcodec/libvpxdec.c
>> +++ b/libavcodec/libvpxdec.c
>> @@ -391,6 +391,5 @@ FFCodec ff_libvpx_vp9_decoder = {
>>       FF_CODEC_DECODE_CB(vpx_decode),
>>       .caps_internal  = FF_CODEC_CAP_NOT_INIT_THREADSAFE |
>>                         FF_CODEC_CAP_AUTO_THREADS,
>> -    .init_static_data = ff_vp9_init_static,
>>   };
>>   #endif /* CONFIG_LIBVPX_VP9_DECODER */
>> --
>> 2.39.2
>>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
James Zern Feb. 28, 2023, 9:20 p.m. UTC | #3 
On Tue, Feb 28, 2023 at 12:49 PM James Almer <jamrial@gmail.com> wrote:
>
> On 2/28/2023 5:40 PM, James Zern wrote:
> > On Tue, Feb 28, 2023 at 4:07 AM James Almer <jamrial@gmail.com> wrote:
> >>
> >> It's used only by the encoder.
> >>
> >
> > It sets AVCodec.pix_fmts, but maybe the values reported aren't used
> > meaningfully.
>
> Indeed, they aren't. AVCodec.pix_fmts is a list of formats an encoder
> accepts as input. Decoders don't use that array.
>

lgtm. The documentation for that field maybe could use some
clarification. A few other decoders look to set this, h263dec being
one.

> >
> >> Signed-off-by: James Almer <jamrial@gmail.com>
> >> ---
> >>   libavcodec/libvpxdec.c | 1 -
> >>   1 file changed, 1 deletion(-)
> >>
> >> diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c
> >> index 0ae19c3f72..8e6291fe20 100644
> >> --- a/libavcodec/libvpxdec.c
> >> +++ b/libavcodec/libvpxdec.c
> >> @@ -391,6 +391,5 @@ FFCodec ff_libvpx_vp9_decoder = {
> >>       FF_CODEC_DECODE_CB(vpx_decode),
> >>       .caps_internal  = FF_CODEC_CAP_NOT_INIT_THREADSAFE |
> >>                         FF_CODEC_CAP_AUTO_THREADS,
> >> -    .init_static_data = ff_vp9_init_static,
> >>   };
> >>   #endif /* CONFIG_LIBVPX_VP9_DECODER */
> >> --
> >> 2.39.2
> >>
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
James Zern March 2, 2023, 8:53 p.m. UTC | #4 
On Tue, Feb 28, 2023 at 1:20 PM James Zern <jzern@google.com> wrote:
>
> On Tue, Feb 28, 2023 at 12:49 PM James Almer <jamrial@gmail.com> wrote:
> >
> > On 2/28/2023 5:40 PM, James Zern wrote:
> > > On Tue, Feb 28, 2023 at 4:07 AM James Almer <jamrial@gmail.com> wrote:
> > >>
> > >> It's used only by the encoder.
> > >>
> > >
> > > It sets AVCodec.pix_fmts, but maybe the values reported aren't used
> > > meaningfully.
> >
> > Indeed, they aren't. AVCodec.pix_fmts is a list of formats an encoder
> > accepts as input. Decoders don't use that array.
> >
>
> lgtm. The documentation for that field maybe could use some
> clarification. A few other decoders look to set this, h263dec being
> one.
>

For what it's worth, prior to this patch -h decoder=libvpx-vp9 would
display the supported formats:
Supported pixel formats: yuv420p yuva420p yuv422p yuv440p yuv444p
yuv420p10le yuv422p10le yuv440p10le yuv444p10le yuv420p12le
yuv422p12le yuv440p12le yuv444p12le gbrp gbrp10le gbrp12le
We used this in libvpx tests as one signal that --enable-vp9-bitdepth
builds were integrated correctly with ffmpeg. libaom has a similar
check. This is easy to update, though. The main point of those tests
is to ensure the build doesn't break.

> > >
> > >> Signed-off-by: James Almer <jamrial@gmail.com>
> > >> ---
> > >>   libavcodec/libvpxdec.c | 1 -
> > >>   1 file changed, 1 deletion(-)
> > >>
> > >> diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c
> > >> index 0ae19c3f72..8e6291fe20 100644
> > >> --- a/libavcodec/libvpxdec.c
> > >> +++ b/libavcodec/libvpxdec.c
> > >> @@ -391,6 +391,5 @@ FFCodec ff_libvpx_vp9_decoder = {
> > >>       FF_CODEC_DECODE_CB(vpx_decode),
> > >>       .caps_internal  = FF_CODEC_CAP_NOT_INIT_THREADSAFE |
> > >>                         FF_CODEC_CAP_AUTO_THREADS,
> > >> -    .init_static_data = ff_vp9_init_static,
> > >>   };
> > >>   #endif /* CONFIG_LIBVPX_VP9_DECODER */
> > >> --
> > >> 2.39.2
> > >>
> > > _______________________________________________
> > > ffmpeg-devel mailing list
> > > ffmpeg-devel@ffmpeg.org
> > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > >
> > > To unsubscribe, visit link above, or email
> > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c
index 0ae19c3f72..8e6291fe20 100644
--- a/libavcodec/libvpxdec.c
+++ b/libavcodec/libvpxdec.c
@@ -391,6 +391,5 @@  FFCodec ff_libvpx_vp9_decoder = {
     FF_CODEC_DECODE_CB(vpx_decode),
     .caps_internal  = FF_CODEC_CAP_NOT_INIT_THREADSAFE |
                       FF_CODEC_CAP_AUTO_THREADS,
-    .init_static_data = ff_vp9_init_static,
 };
 #endif /* CONFIG_LIBVPX_VP9_DECODER */