| Message ID | 20230306135548.23001-1-ting.fu@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel,V6,1/3] lavfi/dnn: Mark native backend as unsupported | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
> -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Ting > Fu > Sent: Monday, March 6, 2023 09:56 PM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH V6 1/3] lavfi/dnn: Mark native backend as > unsupported > > Native is deprecated value for backed_type option. Modify related error > message. > > Signed-off-by: Ting Fu <ting.fu@intel.com> > --- > libavfilter/dnn/dnn_interface.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > [...] Compared with PATCH V5, only restored some content incorrectly deleted in doc/filters.texi, and rebase commit on latest code. > -- > 2.17.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org > with subject "unsubscribe".
> -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > Ting Fu > Sent: Monday, March 6, 2023 9:56 PM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH V6 1/3] lavfi/dnn: Mark native backend as > unsupported > > Native is deprecated value for backed_type option. Modify related error Native backend will be removed, and so change the interface first. > message. > > Signed-off-by: Ting Fu <ting.fu@intel.com> > --- > libavfilter/dnn/dnn_interface.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/libavfilter/dnn/dnn_interface.c b/libavfilter/dnn/dnn_interface.c > index 554a36b0dc..5b1695a1dd 100644 > --- a/libavfilter/dnn/dnn_interface.c > +++ b/libavfilter/dnn/dnn_interface.c > @@ -24,7 +24,6 @@ > */ > > #include "../dnn_interface.h" > -#include "dnn_backend_native.h" > #include "dnn_backend_tf.h" > #include "dnn_backend_openvino.h" > #include "libavutil/mem.h" > @@ -39,13 +38,6 @@ DNNModule *ff_get_dnn_module(DNNBackendType > backend_type) > } > > switch(backend_type){ > - case DNN_NATIVE: > - dnn_module->load_model = &ff_dnn_load_model_native; > - dnn_module->execute_model = &ff_dnn_execute_model_native; > - dnn_module->get_result = &ff_dnn_get_result_native; > - dnn_module->flush = &ff_dnn_flush_native; > - dnn_module->free_model = &ff_dnn_free_model_native; > - break; > case DNN_TF: > #if (CONFIG_LIBTENSORFLOW == 1) > dnn_module->load_model = &ff_dnn_load_model_tf; @@ -71,7 +63,7 > @@ DNNModule *ff_get_dnn_module(DNNBackendType backend_type) > #endif > break; > default: > - av_log(NULL, AV_LOG_ERROR, "Module backend_type is not native or > tensorflow\n"); > + av_log(NULL, AV_LOG_ERROR, "Module backend_type is not > + supported or enabled.\n"); > av_freep(&dnn_module); > return NULL; > } > -- > 2.17.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org > with subject "unsubscribe".
> -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Guo, > Yejun > Sent: Thursday, April 27, 2023 11:24 AM > To: FFmpeg development discussions and patches <ffmpeg- > devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH V6 1/3] lavfi/dnn: Mark native backend > as unsupported > > > > > -----Original Message----- > > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > Ting > > Fu > > Sent: Monday, March 6, 2023 9:56 PM > > To: ffmpeg-devel@ffmpeg.org > > Subject: [FFmpeg-devel] [PATCH V6 1/3] lavfi/dnn: Mark native backend > > as unsupported > > > > Native is deprecated value for backed_type option. Modify related > > error > > Native backend will be removed, and so change the interface first. > > > message. > > Hi Yejun, Thank you for review, modified commit message in PATCH V7. [...] > > -- > > 2.17.1 > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org > with subject "unsubscribe".
diff --git a/libavfilter/dnn/dnn_interface.c b/libavfilter/dnn/dnn_interface.c index 554a36b0dc..5b1695a1dd 100644 --- a/libavfilter/dnn/dnn_interface.c +++ b/libavfilter/dnn/dnn_interface.c @@ -24,7 +24,6 @@ */ #include "../dnn_interface.h" -#include "dnn_backend_native.h" #include "dnn_backend_tf.h" #include "dnn_backend_openvino.h" #include "libavutil/mem.h" @@ -39,13 +38,6 @@ DNNModule *ff_get_dnn_module(DNNBackendType backend_type) } switch(backend_type){ - case DNN_NATIVE: - dnn_module->load_model = &ff_dnn_load_model_native; - dnn_module->execute_model = &ff_dnn_execute_model_native; - dnn_module->get_result = &ff_dnn_get_result_native; - dnn_module->flush = &ff_dnn_flush_native; - dnn_module->free_model = &ff_dnn_free_model_native; - break; case DNN_TF: #if (CONFIG_LIBTENSORFLOW == 1) dnn_module->load_model = &ff_dnn_load_model_tf; @@ -71,7 +63,7 @@ DNNModule *ff_get_dnn_module(DNNBackendType backend_type) #endif break; default: - av_log(NULL, AV_LOG_ERROR, "Module backend_type is not native or tensorflow\n"); + av_log(NULL, AV_LOG_ERROR, "Module backend_type is not supported or enabled.\n"); av_freep(&dnn_module); return NULL; }
Native is deprecated value for backed_type option. Modify related error message. Signed-off-by: Ting Fu <ting.fu@intel.com> --- libavfilter/dnn/dnn_interface.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)