diff mbox series

[FFmpeg-devel,2/2] fftools: enable long path support on Windows

Message ID 20230308212715.82861-2-rcombs@rcombs.me
State New
Headers show
Series [FFmpeg-devel,1/2] fftools: set process code page to UTF-8 on Windows | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

rcombs March 8, 2023, 9:27 p.m. UTC 
This allows use of filesystem paths longer than MAX_PATH (260 characters)
on Windows 10 version 1607 and later.

This _may_ be a no-op if a "LongPathsEnabled" isn't set in the registry.
---
 fftools/fftools.manifest | 1 +
 1 file changed, 1 insertion(+)

Comments

Martin Storsjö March 8, 2023, 9:35 p.m. UTC | #1 
On Wed, 8 Mar 2023, rcombs wrote:

> This allows use of filesystem paths longer than MAX_PATH (260 characters)
> on Windows 10 version 1607 and later.
>
> This _may_ be a no-op if a "LongPathsEnabled" isn't set in the registry.
> ---
> fftools/fftools.manifest | 1 +
> 1 file changed, 1 insertion(+)

Are you aware of the changes in c5aba39a041fdaac267fc8c6a2ef745a94a2b0da 
last year? That was supposed to make this change redundant, and make long 
paths usable even on versions of Windows older than that.

// Martin
rcombs March 8, 2023, 9:43 p.m. UTC | #2 
> On Mar 8, 2023, at 15:35, Martin Storsjö <martin@martin.st> wrote:
> 
> On Wed, 8 Mar 2023, rcombs wrote:
> 
>> This allows use of filesystem paths longer than MAX_PATH (260 characters)
>> on Windows 10 version 1607 and later.
>> 
>> This _may_ be a no-op if a "LongPathsEnabled" isn't set in the registry.
>> ---
>> fftools/fftools.manifest | 1 +
>> 1 file changed, 1 insertion(+)
> 
> Are you aware of the changes in c5aba39a041fdaac267fc8c6a2ef745a94a2b0da last year? That was supposed to make this change redundant, and make long paths usable even on versions of Windows older than that.
> 
> // Martin

I hadn't seen that change, but I do think it's still worth signaling our support for long paths explicitly.

> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/fftools/fftools.manifest b/fftools/fftools.manifest
index eaef6cacf1..34124c8298 100644
--- a/fftools/fftools.manifest
+++ b/fftools/fftools.manifest
@@ -5,6 +5,7 @@ 
       <dpiAware xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">true</dpiAware>
       <dpiAwareness xmlns="http://schemas.microsoft.com/SMI/2016/WindowsSettings">PerMonitorV2</dpiAwareness>
       <activeCodePage xmlns="http://schemas.microsoft.com/SMI/2019/WindowsSettings">UTF-8</activeCodePage>
+      <longPathAware xmlns="http://schemas.microsoft.com/SMI/2019/WindowsSettings">true</longPathAware>
     </asmv3:windowsSettings>
   </asmv3:application>
 </assembly>