diff mbox series

[FFmpeg-devel,2/3] avfilter/vf_ssim360: Remove dead code

Message ID AS8P250MB074404CC6018F3CC29FC18AA8FB89@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM
State Accepted
Commit 2732d0507c5ee6961d49212e71717fc4fbc72d16
Headers show
Series [FFmpeg-devel,1/3] avfilter/vf_ssim360: Use correct type in sizeof | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt March 12, 2023, 9:53 p.m. UTC 
Fixes Coverity issue #1520669.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavfilter/vf_ssim360.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Anton Khirnov March 14, 2023, 5:43 a.m. UTC | #1 
Quoting Andreas Rheinhardt (2023-03-12 22:53:44)
> Fixes Coverity issue #1520669.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavfilter/vf_ssim360.c | 4 ----
>  1 file changed, 4 deletions(-)

Looks ok.
diff mbox series

Patch

diff --git a/libavfilter/vf_ssim360.c b/libavfilter/vf_ssim360.c
index f8ce0744f2..5794275c2c 100644
--- a/libavfilter/vf_ssim360.c
+++ b/libavfilter/vf_ssim360.c
@@ -1274,10 +1274,6 @@  static int parse_heatmaps(void *logctx, HeatmapList **proot,
             ret = AVERROR(ENOMEM);
             goto fail;
         }
-        if (!line) {
-            av_freep(&line);
-            break;
-        }
 
         // first value is frame id
         av_strtok(line, ",", &saveptr);