diff mbox series

[FFmpeg-devel] lavfi/vf_vpp_qsv: set the right timestamp for AVERROR_EOF

Message ID 20230317023854.40906-1-haihao.xiang@intel.com
State Accepted
Commit 57afccc0ef8d3024ffb2d1b2d25c9670b9501248
Headers show
Series [FFmpeg-devel] lavfi/vf_vpp_qsv: set the right timestamp for AVERROR_EOF | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished

Commit Message

Xiang, Haihao March 17, 2023, 2:38 a.m. UTC 
From: Haihao Xiang <haihao.xiang@intel.com>

Rescale the timestamp for AVERROR_EOF. This can fix tickets 10261 and
10262.

Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
---
 libavfilter/vf_vpp_qsv.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Rogozhkin, Dmitry V March 18, 2023, 12:37 a.m. UTC | #1 
On Fri, 2023-03-17 at 10:38 +0800, Xiang, Haihao wrote:
> From: Haihao Xiang <haihao.xiang@intel.com>
> 
> Rescale the timestamp for AVERROR_EOF. This can fix tickets 10261 and
> 10262.
> 
> Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
> ---
>  libavfilter/vf_vpp_qsv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c
> index ac77f7bb4b..b4dd7a4191 100644
> --- a/libavfilter/vf_vpp_qsv.c
> +++ b/libavfilter/vf_vpp_qsv.c
> @@ -602,6 +602,7 @@ not_ready:
>      return FFERROR_NOT_READY;
>  
>  eof:
> +    pts = av_rescale_q(pts, inlink->time_base, outlink->time_base);
>      ff_outlink_set_status(outlink, status, pts);
>      return 0;
>  }

This patch works for us and addresses issues reported in 
https://trac.ffmpeg.org/ticket/10261 and 
https://trac.ffmpeg.org/ticket/10262. Please, help to merge.
Xiang, Haihao March 20, 2023, 2:13 a.m. UTC | #2 
On Sa, 2023-03-18 at 00:37 +0000, Rogozhkin, Dmitry V wrote:
> On Fri, 2023-03-17 at 10:38 +0800, Xiang, Haihao wrote:
> > From: Haihao Xiang <haihao.xiang@intel.com>
> > 
> > Rescale the timestamp for AVERROR_EOF. This can fix tickets 10261 and
> > 10262.
> > 
> > Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
> > ---
> >  libavfilter/vf_vpp_qsv.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c
> > index ac77f7bb4b..b4dd7a4191 100644
> > --- a/libavfilter/vf_vpp_qsv.c
> > +++ b/libavfilter/vf_vpp_qsv.c
> > @@ -602,6 +602,7 @@ not_ready:
> >      return FFERROR_NOT_READY;
> >  
> >  eof:
> > +    pts = av_rescale_q(pts, inlink->time_base, outlink->time_base);
> >      ff_outlink_set_status(outlink, status, pts);
> >      return 0;
> >  }
> 
> This patch works for us and addresses issues reported in 
> https://trac.ffmpeg.org/ticket/10261 and 
> https://trac.ffmpeg.org/ticket/10262. Please, help to merge.

Pushed and cherry-picked to release/6.0 branch. 

Thanks
haihao
diff mbox series

Patch

diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c
index ac77f7bb4b..b4dd7a4191 100644
--- a/libavfilter/vf_vpp_qsv.c
+++ b/libavfilter/vf_vpp_qsv.c
@@ -602,6 +602,7 @@  not_ready:
     return FFERROR_NOT_READY;
 
 eof:
+    pts = av_rescale_q(pts, inlink->time_base, outlink->time_base);
     ff_outlink_set_status(outlink, status, pts);
     return 0;
 }