| Message ID | 20230520124233.1512-1-jamrial@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel] avformat/matroskaenc: change default audio codec for Matroska output | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On Sat, May 20, 2023 at 09:42:33AM -0300, James Almer wrote: > Vorbis is not usually supported by Smart TVs, receivers and set top boxes, so > it's not a good idea to have it as the default. > > Signed-off-by: James Almer <jamrial@gmail.com> > --- > libavformat/matroskaenc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) I do have a mixed feeling about this [...]
FFac3 on TVs and devices doesn't write some of the dynamic range control fields and is super quiet on a lot of TVs. I would make AAC the default. Kieran
On 5/20/23 15:51, Kieran Kunhya wrote: > FFac3 on TVs and devices doesn't write some of the dynamic range control > fields and is super quiet on a lot of TVs. I would make AAC the default. > +1 for AAC being the default, considering that it's going to be supported more than probably anything else except perhaps ac3 and mp3. - Leo Izen
diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 41e13b273d..ae05f528e3 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c @@ -3431,8 +3431,7 @@ const FFOutputFormat ff_matroska_muxer = { .p.mime_type = "video/x-matroska", .p.extensions = "mkv", .priv_data_size = sizeof(MatroskaMuxContext), - .p.audio_codec = CONFIG_LIBVORBIS_ENCODER ? - AV_CODEC_ID_VORBIS : AV_CODEC_ID_AC3, + .p.audio_codec = AV_CODEC_ID_AC3, .p.video_codec = CONFIG_LIBX264_ENCODER ? AV_CODEC_ID_H264 : AV_CODEC_ID_MPEG4, .init = mkv_init,
Vorbis is not usually supported by Smart TVs, receivers and set top boxes, so it's not a good idea to have it as the default. Signed-off-by: James Almer <jamrial@gmail.com> --- libavformat/matroskaenc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)