diff mbox

[FFmpeg-devel] lavf/matroska: Support QDMC

Message ID 201703012323.43315.cehoyos@ag.or.at
State Accepted
Commit 1638d956a35c240e4f9ad2d8711dce06bd32838a
Headers show

Commit Message

Carl Eugen Hoyos March 1, 2017, 10:23 p.m. UTC
Hi!

Attached patch allows muxing and demuxing of QDMC in mkv.

Please comment, Carl Eugen
From 8d383886e19dbfd362497144fc9610ecdcedc144 Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos <cehoyos@ag.or.at>
Date: Wed, 1 Mar 2017 23:22:40 +0100
Subject: [PATCH] lavf/matroska: Support QDMC.

---
 libavformat/matroska.c    |    1 +
 libavformat/matroskaenc.c |    1 +
 2 files changed, 2 insertions(+)

Comments

Paul B Mahol March 2, 2017, 10:06 a.m. UTC | #1
On 3/1/17, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote:
> Hi!
>
> Attached patch allows muxing and demuxing of QDMC in mkv.
>
> Please comment, Carl Eugen
>

lgtm
Paul B Mahol March 5, 2017, 12:57 p.m. UTC | #2
On 3/2/17, Paul B Mahol <onemda@gmail.com> wrote:
> On 3/1/17, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote:
>> Hi!
>>
>> Attached patch allows muxing and demuxing of QDMC in mkv.
>>
>> Please comment, Carl Eugen
>>
>
> lgtm
>

Why this is not applied?
Carl Eugen Hoyos March 5, 2017, 1:42 p.m. UTC | #3
2017-03-05 13:57 GMT+01:00 Paul B Mahol <onemda@gmail.com>:
> On 3/2/17, Paul B Mahol <onemda@gmail.com> wrote:
>> On 3/1/17, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote:
>>> Hi!
>>>
>>> Attached patch allows muxing and demuxing of QDMC in mkv.
>>>
>>> Please comment, Carl Eugen
>>>
>>
>> lgtm
>>
>
> Why this is not applied?

I was wondering if we shouldn't fix #3602 first.

Anyway, patch applied.

Thank you, Carl Eugen
diff mbox

Patch

diff --git a/libavformat/matroska.c b/libavformat/matroska.c
index fda96fb..248d7b5 100644
--- a/libavformat/matroska.c
+++ b/libavformat/matroska.c
@@ -48,6 +48,7 @@  const CodecTags ff_mkv_codec_tags[]={
     {"A_PCM/INT/LIT"    , AV_CODEC_ID_PCM_S24LE},
     {"A_PCM/INT/LIT"    , AV_CODEC_ID_PCM_S32LE},
     {"A_PCM/INT/LIT"    , AV_CODEC_ID_PCM_U8},
+    {"A_QUICKTIME/QDMC" , AV_CODEC_ID_QDMC},
     {"A_QUICKTIME/QDM2" , AV_CODEC_ID_QDM2},
     {"A_REAL/14_4"      , AV_CODEC_ID_RA_144},
     {"A_REAL/28_8"      , AV_CODEC_ID_RA_288},
diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
index 7cb8893..21f6e08 100644
--- a/libavformat/matroskaenc.c
+++ b/libavformat/matroskaenc.c
@@ -2528,6 +2528,7 @@  static const AVCodecTag additional_audio_tags[] = {
     { AV_CODEC_ID_PCM_S16BE, 0xFFFFFFFF },
     { AV_CODEC_ID_PCM_S24BE, 0xFFFFFFFF },
     { AV_CODEC_ID_PCM_S32BE, 0xFFFFFFFF },
+    { AV_CODEC_ID_QDMC,      0xFFFFFFFF },
     { AV_CODEC_ID_QDM2,      0xFFFFFFFF },
     { AV_CODEC_ID_RA_144,    0xFFFFFFFF },
     { AV_CODEC_ID_RA_288,    0xFFFFFFFF },