| Message ID | 20170314220201.10148-1-vittorio.giovara@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
2017-03-14 23:02 GMT+01:00 Vittorio Giovara <vittorio.giovara@gmail.com>: > These types better reflect the ones described in the specification and > avoid any platform-specific implementation issues. Sorry if I miss something but could you clarify who the author of this patch is? Thank you, Carl Eugen
On Wed, 15 Mar 2017 10:22:23 +0100 Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote: > Sorry if I miss something but could you clarify who the author of this > patch is? CC'ing as Vittorio is not subscribed to the mailing list. Not that you should have to know that as there was no CC request in this particular message.
On Thu, Mar 16, 2017 at 4:16 PM, Lou Logan <lou@lrcd.com> wrote: > On Wed, 15 Mar 2017 10:22:23 +0100 > Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote: > >> Sorry if I miss something but could you clarify who the author of this >> patch is? > > CC'ing as Vittorio is not subscribed to the mailing list. Not that you > should have to know that as there was no CC request in this particular > message. Hi, I'm not sure I understand the question. I wrote the patch, and I'll mention it's based on one from Michael. Is there some problem with it? Thanks for the CC.
2017-03-16 22:12 GMT+01:00 Vittorio Giovara <vittorio.giovara@gmail.com>: > On Thu, Mar 16, 2017 at 4:16 PM, Lou Logan <lou@lrcd.com> wrote: >> On Wed, 15 Mar 2017 10:22:23 +0100 >> Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote: >> >>> Sorry if I miss something but could you clarify who the author of this >>> patch is? >> >> CC'ing as Vittorio is not subscribed to the mailing list. Not that you >> should have to know that as there was no CC request in this particular >> message. > > Hi, I'm not sure I understand the question. > I wrote the patch, (This surprises me but this is of course possible.) > and I'll mention it's based on one from Michael. But so far you didn't mention it or did you? Note that if your patch is not based on Michael's patch (which the first paragraph in your email implies) then please do not mention that it is based on Michael's patch (and please accept my apologies for a wrong accusation in this case). Carl Eugen
diff --git a/libavformat/dump.c b/libavformat/dump.c index 7514aee7ac..c56895628d 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -339,7 +339,7 @@ static void dump_spherical(void *ctx, AVCodecParameters *par, AVPacketSideData * &l, &t, &r, &b); av_log(ctx, AV_LOG_INFO, "[%zu, %zu, %zu, %zu] ", l, t, r, b); } else if (spherical->projection == AV_SPHERICAL_CUBEMAP) { - av_log(ctx, AV_LOG_INFO, "[pad %zu] ", spherical->padding); + av_log(ctx, AV_LOG_INFO, "[pad %"PRIu32"] ", spherical->padding); } } diff --git a/libavutil/spherical.h b/libavutil/spherical.h index e7fc1d69fb..fd662cf676 100644 --- a/libavutil/spherical.h +++ b/libavutil/spherical.h @@ -164,10 +164,10 @@ typedef struct AVSphericalMapping { * projection type (@ref AV_SPHERICAL_EQUIRECTANGULAR_TILE), * and should be ignored in all other cases. */ - size_t bound_left; ///< Distance from the left edge - size_t bound_top; ///< Distance from the top edge - size_t bound_right; ///< Distance from the right edge - size_t bound_bottom; ///< Distance from the bottom edge + uint32_t bound_left; ///< Distance from the left edge + uint32_t bound_top; ///< Distance from the top edge + uint32_t bound_right; ///< Distance from the right edge + uint32_t bound_bottom; ///< Distance from the bottom edge /** * @} */ @@ -179,7 +179,7 @@ typedef struct AVSphericalMapping { * (@ref AV_SPHERICAL_CUBEMAP), and should be ignored in all other * cases. */ - size_t padding; + uint32_t padding; } AVSphericalMapping; /**
These types better reflect the ones described in the specification and avoid any platform-specific implementation issues. Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com> --- libavformat/dump.c | 2 +- libavutil/spherical.h | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-)