[FFmpeg-devel] avcodec/dnxhd_parser: take into account compressed frame size and skip it

On Tue, Mar 21, 2017 at 03:36:39PM +0100, Paul B Mahol wrote:
> Fixes #6214.
> 
> Signed-off-by: Paul B Mahol <onemda@gmail.com>
> ---
>  libavcodec/dnxhd_parser.c | 65 ++++++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 58 insertions(+), 7 deletions(-)

seems to change fate

Test vsynth1-dnxhd-720p-hr-lb failed. Look at tests/data/fate/vsynth1-dnxhd-720p-hr-lb.err for details.
make: *** [fate-vsynth1-dnxhd-720p-hr-lb] Error 1

[...]

On Tue, Mar 21, 2017 at 11:02 AM, Michael Niedermayer <
michael@niedermayer.cc> wrote:

> On Tue, Mar 21, 2017 at 03:36:39PM +0100, Paul B Mahol wrote:
> > Fixes #6214.
> >
> > Signed-off-by: Paul B Mahol <onemda@gmail.com>
> > ---
> >  libavcodec/dnxhd_parser.c | 65 ++++++++++++++++++++++++++++++
> ++++++++++++-----
> >  1 file changed, 58 insertions(+), 7 deletions(-)
>
> seems to change fate
>
> --- ./tests/ref/vsynth/vsynth1-dnxhd-720p-hr-lb 2017-03-20
> 19:25:54.181895388 +0100
> +++ tests/data/fate/vsynth1-dnxhd-720p-hr-lb    2017-03-21
> 19:01:09.922162852 +0100
> @@ -1,4 +1,4 @@
>  08cbfe9b9f671cdb9dddc9307121d107 *tests/data/fate/vsynth1-dnxhd
> -720p-hr-lb.dnxhd
>  409600 tests/data/fate/vsynth1-dnxhd-720p-hr-lb.dnxhd
> -22eb87f0f8a50278355006fef70073a9 *tests/data/fate/vsynth1-dnxhd
> -720p-hr-lb.out.rawvideo
> -stddev:    7.49 PSNR: 30.63 MAXDIFF:   64 bytes:  7603200/   608256
> +77e510e3538313b1cbafb86ed248d2df *tests/data/fate/vsynth1-dnxhd
> -720p-hr-lb.out.rawvideo
> +stddev:    7.50 PSNR: 30.62 MAXDIFF:   64 bytes:  7603200/   760320
> Test vsynth1-dnxhd-720p-hr-lb failed. Look at
> tests/data/fate/vsynth1-dnxhd-720p-hr-lb.err for details.
> make: *** [fate-vsynth1-dnxhd-720p-hr-lb] Error 1
>
>
it looks to me as that the test is actually incorrect, and has the same
issue as the ticket. only 4 of the 5 frames are getting correctly parsed,
the test will need to be updated.


[...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Never trust a computer, one day, it may think you are the virus. -- Compn
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>

On 3/21/17, Michael Niedermayer <michael@niedermayer.cc> wrote:
> On Tue, Mar 21, 2017 at 03:36:39PM +0100, Paul B Mahol wrote:
>> Fixes #6214.
>>
>> Signed-off-by: Paul B Mahol <onemda@gmail.com>
>> ---
>>  libavcodec/dnxhd_parser.c | 65
>> ++++++++++++++++++++++++++++++++++++++++++-----
>>  1 file changed, 58 insertions(+), 7 deletions(-)
>
> seems to change fate
>
> --- ./tests/ref/vsynth/vsynth1-dnxhd-720p-hr-lb 2017-03-20
> 19:25:54.181895388 +0100
> +++ tests/data/fate/vsynth1-dnxhd-720p-hr-lb    2017-03-21
> 19:01:09.922162852 +0100
> @@ -1,4 +1,4 @@
>  08cbfe9b9f671cdb9dddc9307121d107
> *tests/data/fate/vsynth1-dnxhd-720p-hr-lb.dnxhd
>  409600 tests/data/fate/vsynth1-dnxhd-720p-hr-lb.dnxhd
> -22eb87f0f8a50278355006fef70073a9
> *tests/data/fate/vsynth1-dnxhd-720p-hr-lb.out.rawvideo
> -stddev:    7.49 PSNR: 30.63 MAXDIFF:   64 bytes:  7603200/   608256
> +77e510e3538313b1cbafb86ed248d2df
> *tests/data/fate/vsynth1-dnxhd-720p-hr-lb.out.rawvideo
> +stddev:    7.50 PSNR: 30.62 MAXDIFF:   64 bytes:  7603200/   760320
> Test vsynth1-dnxhd-720p-hr-lb failed. Look at
> tests/data/fate/vsynth1-dnxhd-720p-hr-lb.err for details.
> make: *** [fate-vsynth1-dnxhd-720p-hr-lb] Error 1

This is indeed intended as current parser breaks on generated files.