diff mbox

[FFmpeg-devel,1/2] ffprobe: support skip_samples packet side data information

Message ID 20170325190447.3540-1-jamrial@gmail.com
State Accepted
Commit a044f8df6aff511367ccd075614be00190c3c968
Headers show

Commit Message

James Almer March 25, 2017, 7:04 p.m. UTC 
Signed-off-by: James Almer <jamrial@gmail.com>
---
 ffprobe.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Rostislav Pehlivanov March 25, 2017, 7:25 p.m. UTC | #1 
On 25 March 2017 at 19:04, James Almer <jamrial@gmail.com> wrote:

> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  ffprobe.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/ffprobe.c b/ffprobe.c
> index 4a7ec0ad31..ba27bce823 100644
> --- a/ffprobe.c
> +++ b/ffprobe.c
> @@ -1806,6 +1806,11 @@ static void print_pkt_side_data(WriterContext *w,
>              print_int("yaw", (double) spherical->yaw / (1 << 16));
>              print_int("pitch", (double) spherical->pitch / (1 << 16));
>              print_int("roll", (double) spherical->roll / (1 << 16));
> +        } else if (sd->type == AV_PKT_DATA_SKIP_SAMPLES && sd->size ==
> 10) {
> +            print_int("skip_samples",    AV_RL32(sd->data));
> +            print_int("discard_padding", AV_RL32(sd->data + 4));
> +            print_int("skip_reason",     AV_RL8(sd->data + 8));
> +            print_int("discard_reason",  AV_RL8(sd->data + 9));
>          }
>          writer_print_section_footer(w);
>      }
> --
> 2.12.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

LGTM, would be useful.
James Almer March 26, 2017, 1:43 a.m. UTC | #2 
On 3/25/2017 4:25 PM, Rostislav Pehlivanov wrote:
> On 25 March 2017 at 19:04, James Almer <jamrial@gmail.com> wrote:
> 
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>>  ffprobe.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/ffprobe.c b/ffprobe.c
>> index 4a7ec0ad31..ba27bce823 100644
>> --- a/ffprobe.c
>> +++ b/ffprobe.c
>> @@ -1806,6 +1806,11 @@ static void print_pkt_side_data(WriterContext *w,
>>              print_int("yaw", (double) spherical->yaw / (1 << 16));
>>              print_int("pitch", (double) spherical->pitch / (1 << 16));
>>              print_int("roll", (double) spherical->roll / (1 << 16));
>> +        } else if (sd->type == AV_PKT_DATA_SKIP_SAMPLES && sd->size ==
>> 10) {
>> +            print_int("skip_samples",    AV_RL32(sd->data));
>> +            print_int("discard_padding", AV_RL32(sd->data + 4));
>> +            print_int("skip_reason",     AV_RL8(sd->data + 8));
>> +            print_int("discard_reason",  AV_RL8(sd->data + 9));
>>          }
>>          writer_print_section_footer(w);
>>      }
>> --
>> 2.12.1
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
> 
> LGTM, would be useful.

Pushed, thanks.
diff mbox

Patch

diff --git a/ffprobe.c b/ffprobe.c
index 4a7ec0ad31..ba27bce823 100644
--- a/ffprobe.c
+++ b/ffprobe.c
@@ -1806,6 +1806,11 @@  static void print_pkt_side_data(WriterContext *w,
             print_int("yaw", (double) spherical->yaw / (1 << 16));
             print_int("pitch", (double) spherical->pitch / (1 << 16));
             print_int("roll", (double) spherical->roll / (1 << 16));
+        } else if (sd->type == AV_PKT_DATA_SKIP_SAMPLES && sd->size == 10) {
+            print_int("skip_samples",    AV_RL32(sd->data));
+            print_int("discard_padding", AV_RL32(sd->data + 4));
+            print_int("skip_reason",     AV_RL8(sd->data + 8));
+            print_int("discard_reason",  AV_RL8(sd->data + 9));
         }
         writer_print_section_footer(w);
     }