diff mbox

[FFmpeg-devel] avcodec/utils: document allocation requirement of extradata

Message ID 20180824185329.11832-1-timo@rothenpieler.org
State Accepted
Commit 0c71c6d66f9ae8265158181e5b1cbc5c63525fde
Headers show

Commit Message

Timo Rothenpieler Aug. 24, 2018, 6:53 p.m. UTC 
---
 libavcodec/avcodec.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Michael Niedermayer Aug. 25, 2018, 3:15 p.m. UTC | #1 
On Fri, Aug 24, 2018 at 08:53:29PM +0200, Timo Rothenpieler wrote:
> ---
>  libavcodec/avcodec.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index 31e50d5a94..2c5e78c88d 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -1616,6 +1616,7 @@ typedef struct AVCodecContext {
>       * The allocated memory should be AV_INPUT_BUFFER_PADDING_SIZE bytes larger
>       * than extradata_size to avoid problems if it is read with the bitstream reader.
>       * The bytewise contents of extradata must not depend on the architecture or CPU endianness.
> +     * Must be allocated with the av_malloc() family of functions.
>       * - encoding: Set/allocated/freed by libavcodec.
>       * - decoding: Set/allocated/freed by user.
>       */

LGTM

thx

[...]
Timo Rothenpieler Aug. 25, 2018, 4:31 p.m. UTC | #2 
On 8/25/2018 5:15 PM, Michael Niedermayer wrote:
> On Fri, Aug 24, 2018 at 08:53:29PM +0200, Timo Rothenpieler wrote:
>> ---
>>   libavcodec/avcodec.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
>> index 31e50d5a94..2c5e78c88d 100644
>> --- a/libavcodec/avcodec.h
>> +++ b/libavcodec/avcodec.h
>> @@ -1616,6 +1616,7 @@ typedef struct AVCodecContext {
>>        * The allocated memory should be AV_INPUT_BUFFER_PADDING_SIZE bytes larger
>>        * than extradata_size to avoid problems if it is read with the bitstream reader.
>>        * The bytewise contents of extradata must not depend on the architecture or CPU endianness.
>> +     * Must be allocated with the av_malloc() family of functions.
>>        * - encoding: Set/allocated/freed by libavcodec.
>>        * - decoding: Set/allocated/freed by user.
>>        */
> 
> LGTM
> 
> thx
> 

applied
diff mbox

Patch

diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index 31e50d5a94..2c5e78c88d 100644
--- a/libavcodec/avcodec.h
+++ b/libavcodec/avcodec.h
@@ -1616,6 +1616,7 @@  typedef struct AVCodecContext {
      * The allocated memory should be AV_INPUT_BUFFER_PADDING_SIZE bytes larger
      * than extradata_size to avoid problems if it is read with the bitstream reader.
      * The bytewise contents of extradata must not depend on the architecture or CPU endianness.
+     * Must be allocated with the av_malloc() family of functions.
      * - encoding: Set/allocated/freed by libavcodec.
      * - decoding: Set/allocated/freed by user.
      */