From patchwork Thu Sep 6 17:39:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?U2lncsOtw7B1ciBSZWfDrW5hIFNpZ3Vyw77Ds3JzZMOzdHRpcg==?= X-Patchwork-Id: 10259 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:a02:12c4:0:0:0:0:0 with SMTP id 65-v6csp736754jap; Thu, 6 Sep 2018 10:45:36 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYXLKZeeq/BIYAfKwYg341+AAsJPJ5RBoY9lo63CgKkib15eFZx4PdoKe5ZyPJRexSprDTD X-Received: by 2002:a1c:85cb:: with SMTP id h194-v6mr3092562wmd.54.1536255936043; Thu, 06 Sep 2018 10:45:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536255936; cv=none; d=google.com; s=arc-20160816; b=0UbIsyjEzVTm8DJcyno51pmej9aJbgITBG2JXQB5gUgrR3cWeU0mtIC34/g+xF64Hg 9X1rE3WuVHERAN5/ZEtLnp/VF1betZdL4Xt9Uzo+HQFkJFK/6KLPFEONHD9tUqv0MOLm GgDH6LlAGZ+hZG9usNsArdbNcfZB8MDYxiekoJinxVtSJ/4mfDOBehKOmn5mrsXAGdC5 mPkNsBuuouWai4xTEl9t0pMjyYSF/oipXlr5IIzn3d3UYpuy7hBp+tEgwypjXF8KXOxJ 8ku58O9y0Ekh0Gxn3Zjf+V4b0kzsgYwMhjNSE5YHaEsKcEe9Be1e0USxHxi1oILPaT3L i5ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:to :message-id:date:from:in-reply-to:references:mime-version :dkim-signature:delivered-to; bh=NgsPkN2FbBXZbXSbwZMtLvD6nL3XKQ1BGd1cl/4knjo=; b=y4XryeqvGKh8ecEwUsuXr/rvCvch0T1UGxAO8C2dYLkDzn7D0jXBGek5rj99DtcU/L WTO32cP6vyH5i3f7bDPBoG+k1NMnV6Gmmx/qbGfNCLUDGwsjTS8r9Pkt9eFCyqC2393i +NlJrBmouwyTAM+Q1NI/eobLMATnctPYhLQYpjg+Q1eTbx+LETMujCnPbpsEf/zFsFr1 ql1yhWoF9xWQ03KsQkw8ApJkrzFcyzaLCNjMh43smGlae1zRF8QI1Sv9hQNXI2dZSvhe ehn/cVA0PxRnX4mG7OgiYTItAI4+fsk4dWtnjjW9GLZW4J6BWbgD7EBZ9Picj5uhZ+Kc atGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=sRWQ4kD1; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id d12-v6si5554361wrn.105.2018.09.06.10.45.35; Thu, 06 Sep 2018 10:45:36 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=sRWQ4kD1; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 63E88689B89; Thu, 6 Sep 2018 20:45:26 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5A0DB68036D for ; Thu, 6 Sep 2018 20:45:20 +0300 (EEST) Received: by mail-qk1-f193.google.com with SMTP id z125-v6so7897129qkb.12 for ; Thu, 06 Sep 2018 10:45:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=DEYhWjYesHg1nMwr9jVwOm/ESveY5J3kKaW/KASEts8=; b=sRWQ4kD1OPB5cQ9H4rRTDLg0XrNVKzqahyL4BmC54QM38/+dhJdtFrkdlEp4/l0BH9 iHG1++1PB5mU0JuwHJ7GpdkbPcDcDxZOsNhYCInp1qkKRdeobYIngflL76j27c62E5TP eZJ/eoe1KxqQExMS4ttglDpNa4JYDXEzzFePAWMl13+MdAwwXfDfrCCqzBMmFrIgSYhk FQ6VFlgX2OTyxm+GqH2hs9QlM4hJbSQNuXN74JvDk5fs7NJxNmalt7bcBU2z5VjX2gcF kqtMX5imUUVq8/Gi/gS5RSpSMydJriIKB5L4I6g0FXtAvyiqzJFXAFVsZVioWPsMU2Fs hOdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=DEYhWjYesHg1nMwr9jVwOm/ESveY5J3kKaW/KASEts8=; b=p2XXZIL14qCX+mITi7sxbRRDBUHBl14LpC5LNY72n3wYSXN0mT2bUNPZ5XoExAKXeO bStsSZhXUXQyS/WaDl6sV9qZZZKmwIiAssGyoY9QFakDXP8j/j0BSBTkAX5K3JQ7N1ww pmOsWBiHOUuCMsiGKWv37GwPldJa8tJY4yNpubX48iQ7DrEBZg5RbRyrZDMseEC8kCbG NXb8cbiOyJpF4DIBr2MYHaDwPYJ1bD4hvRdmJyfuZYJ1FVVhXniwKvZ9mOppvrcrL0OH loebp9Z9x8M2lHeEa6L5JY13mgLBGTIpASDO7z9wezp5Mu/3BHmJoRKkQSQkPU8oK5ZS RzaQ== X-Gm-Message-State: APzg51AIsjkwA7ZfNYYU7OsOGCV4FV2GEqu1nm0Ip+PWFCKOibl905uJ WlZhp+gKtp9e11tmigiikc/X1/qr1Z5djcoikHIGOIvQpHfmjg== X-Received: by 2002:a37:b446:: with SMTP id d67-v6mr2975422qkf.104.1536255565111; Thu, 06 Sep 2018 10:39:25 -0700 (PDT) MIME-Version: 1.0 References: <37d688b8-23ff-9aa7-23d8-b90ce66e9452@gmail.com> In-Reply-To: <37d688b8-23ff-9aa7-23d8-b90ce66e9452@gmail.com> From: =?UTF-8?B?U2lncsOtw7B1ciBSZWfDrW5hIFNpZ3Vyw77Ds3JzZMOzdHRpcg==?= Date: Thu, 6 Sep 2018 13:39:13 -0400 Message-ID: To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add reserve free space option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Wed, Sep 5, 2018 at 6:29 PM James Darnley wrote: > > On 2018-09-05 22:52, Sigríður Regína Sigurþórsdóttir wrote: > > + {"reserve_free_space", "Reserve a given amount of space at the > > beginning og the file for unspecified purpose." > > I added the "metadata_header_padding" global option many years ago. Can > you not reuse it for this purpose? Is it not likely to be "metadata" > that another software might fill this with? Thank you for the suggestion. Here is an updated version using the "metadata_header_padding". --- libavformat/matroskaenc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 09a62e1..3d8ec3c 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c @@ -2005,6 +2005,11 @@ static int mkv_write_header(AVFormatContext *s) ret = AVERROR(ENOMEM); goto fail; } + if (s->metadata_header_padding) { + if (s->metadata_header_padding == 1) + s->metadata_header_padding++; + put_ebml_void(pb, s->metadata_header_padding); + } if ((pb->seekable & AVIO_SEEKABLE_NORMAL) && mkv->reserve_cues_space) { mkv->cues_pos = avio_tell(pb); if (mkv->reserve_cues_space == 1)