From patchwork Tue Oct 9 13:32:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: joshdk@ob-encoder.com X-Patchwork-Id: 10564 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:ab0:73d2:0:0:0:0:0 with SMTP id m18csp4911483uaq; Tue, 9 Oct 2018 06:32:21 -0700 (PDT) X-Google-Smtp-Source: ACcGV63hlfZftJO8WChun6kueXcczciHuPycP4YlJh8/HMa6gCD4RnDjMBigTYGBi+brsQRkOqag X-Received: by 2002:adf:df88:: with SMTP id z8-v6mr15938430wrl.113.1539091941074; Tue, 09 Oct 2018 06:32:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539091941; cv=none; d=google.com; s=arc-20160816; b=x8gMRvQVqNblnnUcQNlpvaDbNvLCxCuEz4/wlchKyzY9/dz/qsaW+URTdLiwhDK5kP 08VTRqSb3fQh2hXkirc8zjo8Pi1IkMZaGFS9RI9MBJX5sTp0ENOdbLt4Rw1td3MQSWCq xLGwY5fSwQV6Aa9wynBkVaVg9HDM+SvHlcsJfUZVTeYWwcafL+Phvf9ud/f6o3hJYSbL H2V5b/8Vy2dGJFQqdGIBLC8uMsOi9HxKaxA/BzqLRyKv22M2ZbYJiVCOMTXAOgTiA32G dOFtE5TCG2xIfW7eIukeRBXCnZILh/RWaD/5XpI/qHKDzH7SJu/9jtQhYZApbkoC+tZr YeyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to; bh=JwL270yEx3caveuS3v5jit72zeEkolA63ZI0S8hhb6o=; b=isJMJtEz9/ZgDOmLMSt81ACcIf3K0xWc9uq64i1FlkEhTUah5F/DMLnSxRWP80IW4M TIGdp+BhM4NFsXN86sSXqsqTYmHtX3LvkVQ5QJVoVVP0gtfMG7f2BohJDiiUgsa69dnR WUyJOa0+QmF8IJnCpkFhQPomWe0QSdr3Pntw6JfrUVfy0UNYf4gs9GzRjkT+c/IxVxVV 1yYlY9m0XG5tpVIa6A9UGQ6GaMimDdEBkFcXj7od+TUCJJ57o5NY9MnVa9n96kX+q/8g pdwSDEWWu602UvJ3SjiHDSF8mBUbrXqf0ufGq1BP4areUc2dSjNO+0MD7U1O/lt4aBkM pWWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@ob-encoder-com.20150623.gappssmtp.com header.s=20150623 header.b=vxxmUqzm; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id v3-v6si14400016wrt.142.2018.10.09.06.32.20; Tue, 09 Oct 2018 06:32:21 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@ob-encoder-com.20150623.gappssmtp.com header.s=20150623 header.b=vxxmUqzm; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C0F7068A19A; Tue, 9 Oct 2018 16:31:56 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 14FA1689E51 for ; Tue, 9 Oct 2018 16:31:51 +0300 (EEST) Received: by mail-wr1-f48.google.com with SMTP id 61-v6so1854371wrb.6 for ; Tue, 09 Oct 2018 06:32:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ob-encoder-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jcxq54jCf5kTjVXQYKQr3lKMA7TsFkIkH+dQEiRiHas=; b=vxxmUqzmQF0ZOh3Jh76sTEQ/eHQyYjan27oJRH9PQ8L17/kjkR+t6FBTTX01Pqi89n 9Di5B6jiB9sTmmgGa21HRyAFUjCGpEojYrl1ZVZ8cMZN/gkKAmFHD9kAaWYHbatAjiRw L5mQU+aU5USErXcIgYmP12wzQUOzbNLw1vu5ib5Z85AlBX0L3p2EMkv7z3835ViCx8ED mNrt51LpTFB/3jCuXAHndQiPbdGvW2Vt1axYKp040MVuULD9UwbfkixEa9brp8rGVbB9 QW3SiFvxTkFVHXsZ/ZnPomfy+gTgagrF9ilep/b1U+Bsdzvoj8WeDcrnn1RjUgcE8jAw XBgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jcxq54jCf5kTjVXQYKQr3lKMA7TsFkIkH+dQEiRiHas=; b=umNuOtdYv7E6QWDqIHNlvLGg1rUPvBLLf2VN46XT/tuCHTzaTqMrtOF1ky7Csf58w9 mt6DoZxVtruVy4AInv/vgOE4rjBj3rVcXok8HPTt/PS8aXES25A6NdcfrQN4NTQqttjM rg93WUvX8EroO7REoFVqibYzW2EZDAUao4jWzxjvURTuuYZwLvYOouZTQ8KRT73pYCjp qKZBTbuMTwJuV7rsKGrd0Xc+gIr+RfUnE83LHyvoqIDpFvJXfc009hjizAQAqLwOjLkj mBzUKcs43c4Pd6vlEkC0gL+qX+m4giHQJO0c7e3mef3BRIGcEhX5q+fwvts6c0sfGWKS /AiQ== X-Gm-Message-State: ABuFfoiB6oZVeHRqUIdz/GueIkSzxTXjoxpN1P2D75UUbkVC5Dxjo7Je VlZjC4se88gS6EUVb7sQ2QwFuxD2HZk= X-Received: by 2002:adf:c88b:: with SMTP id k11-v6mr20012798wrh.6.1539091932339; Tue, 09 Oct 2018 06:32:12 -0700 (PDT) Received: from localhost.localdomain (cpc107625-sotn16-2-0-cust150.15-1.cable.virginm.net. [81.104.78.151]) by smtp.gmail.com with ESMTPSA id e133-v6sm18206731wma.42.2018.10.09.06.32.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Oct 2018 06:32:11 -0700 (PDT) From: joshdk@ob-encoder.com X-Google-Original-From: joshdk@obe.tv To: ffmpeg-devel@ffmpeg.org Date: Tue, 9 Oct 2018 14:32:03 +0100 Message-Id: <20181009133204.29686-3-joshdk@obe.tv> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181009133204.29686-1-joshdk@obe.tv> References: <20181009133204.29686-1-joshdk@obe.tv> Subject: [FFmpeg-devel] [PATCH 2/3] lavf/timecode: document SMPTE struct X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Devin Heitmueller MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Devin Heitmueller There are a number of different binary representations in which SMPTE timecodes can use. Make clear that the specific representation that ffmpeg refers to corresponds to the DV video spec, which is SMPTE S314M:2005 for standard definition video and ST 370-2013 for high definition video. --- libavutil/timecode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/timecode.c b/libavutil/timecode.c index 60077ba0c0..5b2bf85caa 100644 --- a/libavutil/timecode.c +++ b/libavutil/timecode.c @@ -117,6 +117,7 @@ static unsigned bcd2uint(uint8_t bcd) char *av_timecode_make_smpte_tc_string(char *buf, uint32_t tcsmpte, int prevent_df) { + /* See SMPTE ST 314M-2005 Sec 4.4.2.2.1 "Time code pack (TC)" */ unsigned hh = bcd2uint(tcsmpte & 0x3f); // 6-bit hours unsigned mm = bcd2uint(tcsmpte>>8 & 0x7f); // 7-bit minutes unsigned ss = bcd2uint(tcsmpte>>16 & 0x7f); // 7-bit seconds