From patchwork Sat Oct 6 17:30:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Thompson X-Patchwork-Id: 10600 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:ab0:73d2:0:0:0:0:0 with SMTP id m18csp1785709uaq; Sat, 6 Oct 2018 10:30:15 -0700 (PDT) X-Google-Smtp-Source: ACcGV61aYRoIU78mHvcS7t36JCqXJ57H3bx84jOqYU8DvrnQ3PX9u9Lt0Ppl7EMUIzPmqKk8kvDD X-Received: by 2002:adf:83c3:: with SMTP id 61-v6mr11203894wre.5.1538847015193; Sat, 06 Oct 2018 10:30:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538847015; cv=none; d=google.com; s=arc-20160816; b=hpBzpDjOtk3d/TLEjSvWXN0gKR5wHvFLxXciHAC6ho9oQeFkxm6Snd6VAl1gCrempr Kic3cg9GzMNamQkR5Wb7AJTx63csrm6VjVaiypDBeL5xYs4C9q/jXvCl1RmrB2R+jIfI +nirNw0VFukCFWJFXlNbltApfA3trNck6Lg4uQsvg6WDZ6r/ruYUj0jDORz5agly6s+r kxJQ05owhroB+Yz6XhAaYE7Phuox2oBASno1rHUClcwfyDj3yhjpNUDwYRL4Wdd1+s2D 2zwrCzj5Uep24N1yp/Tn/DDVQ7DLaHIJxfqKr8QSxUljPg9SziR6oIPH3VsVa95X/9en 0KgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:dkim-signature :delivered-to; bh=RQu6yMiGMn6CYzkTkoeQ6f1V9X/H1HVyKv9Sqn5QAmo=; b=bKeTl2eJKKhlUGOLPdhGobSpLNpyfzdNHgIkY/DKNJFOaL7Q5t/oNxc39O3Dx1Q2gc QPbCRn69nCoobNlVSy8s1NcnS9Y6vgUBI10Fg8vtXUjdlkyLDruIFRvtJYLCtWQ921L+ d5Iqx8JzvNHdcX2NAxQO/VAANI/xNjUR7GaskNj3mXG6kE3CxphD4q8BuJH9g0NO28WH UNcA+z8YcoD1MFmsOkJf6AYq8tEhBTEhUd+nrgPIQgjRMIj5EeuVU8/++aOHEHDvsfiz EwnlyrE4DjBnQtN1rBVsLXwjxgq9gvkMdl3GvGluIEZqT6lBQGKrPJECuUvtWiNH+zUn Mh6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@jkqxz-net.20150623.gappssmtp.com header.s=20150623 header.b="KAD/HkWi"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 60-v6si10023968wrd.441.2018.10.06.10.30.14; Sat, 06 Oct 2018 10:30:15 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@jkqxz-net.20150623.gappssmtp.com header.s=20150623 header.b="KAD/HkWi"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 367DA68A281; Sat, 6 Oct 2018 20:29:52 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5B0446899C8 for ; Sat, 6 Oct 2018 20:29:45 +0300 (EEST) Received: by mail-wr1-f48.google.com with SMTP id q5-v6so16538732wrw.12 for ; Sat, 06 Oct 2018 10:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=PYoC6iiAaiig4xu3n7RhRVC5dW3ug5EVBjvQesEMcO8=; b=KAD/HkWii2nuRNw9R+Dltz/aZCzLp74LFiejaYvWlwfd2/XL726J8EZ2PhAjTIQjGs K8JvrKGYdvO4eFAu7JURYVmjtDFK+7qjdhiuONvZFQAd7LsPH71UBN7lBKQTaM2lApB3 c75OCT47CXngJWb4JRjeNydvdx3G9yI3VyYrFCaG43h3uAyKwDpwFMJ5TRlRpaSNedVi 1AtYnZJn8W6OsoDWVGt6rwcTY1/qykJCTztSbfkIr2ENE2WSQfSozjEvAxyk1UYxBMtY NgFhppNID71YWnMXmYcNH/jB5KIHUzCzOVVaCTno0HzhlaNakEhSNqnCeL+SrphP5uPI VG4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PYoC6iiAaiig4xu3n7RhRVC5dW3ug5EVBjvQesEMcO8=; b=tlDZXf9K8mOdHHnkLveZCGYr7JSMKFsr7m44elI5NJdRXhrV4zbBHxOUU1l9rbJHcd 5wOFNKzLVj109I5UfGPPRV1Fu0wyDsLgg9q667sBWGUQx0/bIKlNjNWmJcT5RY6CokV/ w3b1otM/uYHQGq7jYZGTsrC4GRLTvooqjKYuW6mZ4ebuteg8js78fYLTHBvLExWMVMVi wzipuRBaCHbEYzwFDP5i2mDTtT70UNzqESECS5vdBOjpuZEAPG8Tuw4qNDv7GvVxK/L9 Y+RPzgF17H3+rpvqnJ7rvchDZ1mX2uiBs8OzFwsrHFKELSm7wJT8wDR61LMETGBCu1JL hX4A== X-Gm-Message-State: ABuFfoiv1ObkrWqLqnL7ygYOjttoTd6v9q2TcDEzHd2BVDsO7cCw6FtC pVf3jPeboJzUNq2t15i+7ZgeldFeeBU= X-Received: by 2002:adf:c513:: with SMTP id q19-v6mr9288831wrf.46.1538847005578; Sat, 06 Oct 2018 10:30:05 -0700 (PDT) Received: from [192.168.0.4] (cpc91242-cmbg18-2-0-cust650.5-4.cable.virginm.net. [82.8.130.139]) by smtp.gmail.com with ESMTPSA id k63-v6sm5203031wmd.46.2018.10.06.10.30.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 06 Oct 2018 10:30:05 -0700 (PDT) To: ffmpeg-devel@ffmpeg.org References: <20181004230947.9658-1-sw@jkqxz.net> From: Mark Thompson Message-ID: <08e754fc-7c09-f2eb-df41-17de241dc788@jkqxz.net> Date: Sat, 6 Oct 2018 18:30:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Subject: [FFmpeg-devel] [PATCH] configure: Add missing IVF muxer BSF dependency X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" --- On 05/10/18 00:53, James Almer wrote: > On 10/4/2018 8:09 PM, Mark Thompson wrote: >> --- >> configure | 10 +++++++--- >> 1 file changed, 7 insertions(+), 3 deletions(-) >> >> diff --git a/configure b/configure >> index 85d5dd5962..cbd52e641b 100755 >> --- a/configure >> +++ b/configure >> @@ -3173,26 +3173,30 @@ eac3_demuxer_select="ac3_parser" >> f4v_muxer_select="mov_muxer" >> fifo_muxer_deps="threads" >> flac_demuxer_select="flac_parser" >> +h264_muxer_select="h264_mp4toannexb_bsf" >> hds_muxer_select="flv_muxer" >> +hevc_muxer_select="hevc_mp4toannexb_bsf" >> hls_muxer_select="mpegts_muxer" >> hls_muxer_suggest="gcrypt openssl" >> image2_alias_pix_demuxer_select="image2_demuxer" >> image2_brender_pix_demuxer_select="image2_demuxer" >> ipod_muxer_select="mov_muxer" >> ismv_muxer_select="mov_muxer" >> +ivf_muxer_select="vp9_superframe_bsf" >> +latm_muxer_select="aac_adtstoasc_bsf" >> matroska_audio_muxer_select="matroska_muxer" >> matroska_demuxer_select="iso_media riffdec" >> matroska_demuxer_suggest="bzlib lzo zlib" >> -matroska_muxer_select="iso_media riffenc" >> +matroska_muxer_select="iso_media riffenc aac_adtstoasc_bsf vp9_superframe_bsf" >> mmf_muxer_select="riffenc" >> mov_demuxer_select="iso_media riffdec" >> mov_demuxer_suggest="zlib" >> -mov_muxer_select="iso_media riffenc rtpenc_chain" >> +mov_muxer_select="iso_media riffenc rtpenc_chain aac_adtstoasc_bsf" >> mp3_demuxer_select="mpegaudio_parser" >> mp3_muxer_select="mpegaudioheader" >> mp4_muxer_select="mov_muxer" >> mpegts_demuxer_select="iso_media" >> -mpegts_muxer_select="adts_muxer latm_muxer" >> +mpegts_muxer_select="adts_muxer latm_muxer h264_mp4toannexb_bsf hevc_mp4toannexb_bsf" >> mpegtsraw_demuxer_select="mpegts_demuxer" >> mxf_d10_muxer_select="mxf_muxer" >> mxf_opatom_muxer_select="mxf_muxer" > > I don't think enabling any of the *_mp4toannexb_bsf or aac_adtstoasc_bsf > is a good idea for mov, matroska, mpegts and similar. Nothing says > whoever is configuring/building ffmpeg wants to mux such codecs into > those containers, so why force enable bsfs they don't care about? > latm, h264 and hevc are the exception, seeing they require the bsfs to > actually work, and at least the latter two don't seem to reject any > packet you pass to them. > > vp9_superframe_bsf is a different story since that one prevents muxing > invalid bitstreams, and should indeed be always enabled. Hmm, yeah. Being prompted by the visible problem in ivfenc I didn't really think this through properly. While they aren't a hard requirement, it seems to me that for h264 and hevc it might be a good idea to have this dependency? I agree it's not helpful on the others, since they are generally not used. Updated patch with just the IVF muxer enclosing. Thanks, - Mark --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 85d5dd5962..705d5caa44 100755 --- a/configure +++ b/configure @@ -3180,6 +3180,7 @@ image2_alias_pix_demuxer_select="image2_demuxer" image2_brender_pix_demuxer_select="image2_demuxer" ipod_muxer_select="mov_muxer" ismv_muxer_select="mov_muxer" +ivf_muxer_select="vp9_superframe_bsf" matroska_audio_muxer_select="matroska_muxer" matroska_demuxer_select="iso_media riffdec" matroska_demuxer_suggest="bzlib lzo zlib"