From patchwork Wed Oct 3 21:03:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Rice X-Patchwork-Id: 10603 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:ab0:73d2:0:0:0:0:0 with SMTP id m18csp78452uaq; Wed, 3 Oct 2018 14:04:00 -0700 (PDT) X-Google-Smtp-Source: ACcGV636hR0atKXv3cFfjFbdMNK3Q8nyuHCvo3KJgK5A5b5xRgapgaqbiABvIhDboYFVZtlyIHUc X-Received: by 2002:a5d:52ce:: with SMTP id r14-v6mr2493927wrv.123.1538600640110; Wed, 03 Oct 2018 14:04:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538600640; cv=none; d=google.com; s=arc-20160816; b=bfSYKm1tbQowEYAgMAmWswLMj4ksb9fqVPK7PXIysLEjsgs2fMyh4ptiIfPVnEJZda h/RNsct6/TWacvSc6mERZnnB0kyk2OpbC/dKxnWqCDUqWUTXlNuzyEHtfajeBZSCQWkq iYd2VrNbtMOgYMjJUlbwqWvIFSXCnh+QKw6wAXDeAbRL2N3+SKuaD5+oQ2hYvN9+0iZ0 on7ylcHuOzPa0YNBBBHT0yUOdktpkKBs4mBtKGbVc/a5oiw2sLa9E/V8xRUpCBjF5XoX fg4pKxcKqXkSFreCbZa/QH431f/4a4YGAyGD0j8nY2NvGBWObWIi+rZj7rmt+NkGZpYw HkgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:to:date:message-id:mime-version:from :delivered-to; bh=0feUbEIzfblCZH413KRtagKGDkQSV1W8OpyftSYr1k4=; b=xaJ1A48BUCAALw4YQsHL28cEc9FHxOyCA/BM+V+cHLUUnKqqZ0x6JWc4rsba+7/08H De3WZHQVFYaGZz1Ro6o0/r4wiRrgYkLExGen6meSltDjq+JrGnXm0JdEqT1SVwGSSacl 3Cw92uEweY80LDJNDIk6BlkJnFUxinw6mmtapd0GyZKbyHtDSzH8wB+IeyYRXITCS6jI 3hC3lWmMokv5awDtp4XorRh+WjY6OP93z2b8mCPksaZYDovNo/7732PUlJJA9nxBaykj Mo6qpfmH6z0ax85WNvgzIMd23vGdg434Mu4FaS/70V+NsawcNIjbuk9u0t1VNPbfapur kXpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id r6-v6si1355445wrj.11.2018.10.03.14.03.59; Wed, 03 Oct 2018 14:04:00 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F063868A457; Thu, 4 Oct 2018 00:03:38 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from server172-3.web-hosting.com (server172-3.web-hosting.com [68.65.122.111]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E5E3B68A0BC for ; Thu, 4 Oct 2018 00:03:31 +0300 (EEST) Received: from [146.96.19.240] (port=44353 helo=[10.10.201.39]) by server172.web-hosting.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g7oJC-001zQB-2i for ffmpeg-devel@ffmpeg.org; Wed, 03 Oct 2018 17:03:50 -0400 From: Dave Rice Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Message-Id: <1C10744D-B083-455C-9236-EFC6ABFA1676@dericed.com> Date: Wed, 3 Oct 2018 17:03:49 -0400 To: FFmpeg development discussions and patches X-Mailer: Apple Mail (2.3273) X-OutGoing-Spam-Status: No, score=0.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server172.web-hosting.com X-AntiAbuse: Original Domain - ffmpeg.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - dericed.com X-Get-Message-Sender-Via: server172.web-hosting.com: authenticated_id: dave@dericed.com X-Authenticated-Sender: server172.web-hosting.com: dave@dericed.com X-Source: X-Source-Args: X-Source-Dir: X-From-Rewrite: unmodified, already matched Subject: [FFmpeg-devel] [PATCHv2 1/2] ffplay: options to specify window position X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Thanks Marton for comments. Here is a revision to the first patch. From 3fe6a9e5279a280af9a06843621737ddc44529cc Mon Sep 17 00:00:00 2001 From: Dave Rice Date: Mon, 1 Oct 2018 17:07:44 -0400 Subject: [PATCHv2 1/2] ffplay: options to specify window position --- doc/ffplay.texi | 4 ++++ fftools/ffplay.c | 6 +++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/ffplay.texi b/doc/ffplay.texi index dcb86ce13c..a3da2cd570 100644 --- a/doc/ffplay.texi +++ b/doc/ffplay.texi @@ -74,6 +74,10 @@ as 100. Force format. @item -window_title @var{title} Set window title (default is the input filename). +@item -screen_left @var{title} +Set the x position for the left of the window (default is a centered window). +@item -screen_top @var{title} +Set the y position for the top of the window (default is a centered window). @item -loop @var{number} Loops movie playback times. 0 means forever. @item -showmode @var{mode} diff --git a/fftools/ffplay.c b/fftools/ffplay.c index e375a32ec2..6cc59b4d33 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -314,6 +314,8 @@ static int default_width = 640; static int default_height = 480; static int screen_width = 0; static int screen_height = 0; +static int left = SDL_WINDOWPOS_CENTERED; +static int top = SDL_WINDOWPOS_CENTERED; static int audio_disable; static int video_disable; static int subtitle_disable; @@ -1346,7 +1348,7 @@ static int video_open(VideoState *is) SDL_SetWindowTitle(window, window_title); SDL_SetWindowSize(window, w, h); - SDL_SetWindowPosition(window, SDL_WINDOWPOS_CENTERED, SDL_WINDOWPOS_CENTERED); + SDL_SetWindowPosition(window, left, top); if (is_full_screen) SDL_SetWindowFullscreen(window, SDL_WINDOW_FULLSCREEN_DESKTOP); SDL_ShowWindow(window); @@ -3602,6 +3604,8 @@ static const OptionDef options[] = { { "framedrop", OPT_BOOL | OPT_EXPERT, { &framedrop }, "drop frames when cpu is too slow", "" }, { "infbuf", OPT_BOOL | OPT_EXPERT, { &infinite_buffer }, "don't limit the input buffer size (useful with realtime streams)", "" }, { "window_title", OPT_STRING | HAS_ARG, { &window_title }, "set window title", "window title" }, + { "left", OPT_INT | HAS_ARG | OPT_EXPERT, { &left }, "set the x position for the left of the window", "x pos" }, + { "top", OPT_INT | HAS_ARG | OPT_EXPERT, { &top }, "set the y position for the top of the window", "y pos" }, #if CONFIG_AVFILTER { "vf", OPT_EXPERT | HAS_ARG, { .func_arg = opt_add_vfilter }, "set video filters", "filter_graph" }, { "af", OPT_STRING | HAS_ARG, { &afilters }, "set audio filters", "filter_graph" },