[FFmpeg-devel] avcodec/wmaprodec: improve WMAPRO/XMA gapless output

Submitted by Michael Niedermayer on Oct. 6, 2018, 7:39 p.m.

Details

Message ID 20181006193940.GM26838@michaelspb
State New
Headers show

Commit Message

Michael Niedermayer Oct. 6, 2018, 7:39 p.m.
On Sat, Oct 06, 2018 at 04:53:31PM +0200, Banana M. wrote:
> > Is it intended that this doesnt list a human name ?
> > (its no problem but jb tends to be unhappy if there are no names in the
> log
> > so i try to ask people if they really intend to not list their name or if
> > its a unintended mistake)
> 
> It's the nick/mail I use in github and other places, it's correct :)
> 
> 
> > this will need some change to
> > TEST    wmapro-ism
> > stddev:    0.00 PSNR:143.22 MAXDIFF:    1 bytes:   884736/   879952
> > size: |884736 - 879952| >= 0
> > Test wmapro-ism failed. Look at tests/data/fate/wmapro-ism.err for
> details.
> > make: *** [fate-wmapro-ism] Error 1
> 
> I've run the tests but I thought fixes would need changes in the
> (restricted) FATE suite server.
> 
> If somebody could explain how to fix the test or point to some doc, but I
> think some more experienced dev should take care of it.

you can avoid the failure with:
changing the reference file is not possible as that would break previous
checkouts. We can of course add a new reference with a new filename and
use that.
If someone posts a new file and people want it updated, i can upload it
but we should make really sure that this is the final one and would no
need future changes. In fact the file we have currently should not have
been a file from ffmpeg but from the "reference" decoder. Iam not sure
where it came from ...
But if it was a proper reference then bug fixes should reduce differences
not inncrease them ...
 


> 
> I plan to refine WMAPRO output in some cases (once I investigate), so this
> will change again later anyway.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Patch hide | download patch | download mbox

diff --git a/tests/fate/wma.mak b/tests/fate/wma.mak
index 12a8fa989a..bc530998e8 100644
--- a/tests/fate/wma.mak
+++ b/tests/fate/wma.mak
@@ -11,6 +11,7 @@  fate-wmapro-5.1: SIZE_TOLERANCE = 24576
 FATE_WMAPRO-$(call DEMDEC, MOV, WMAPRO) += fate-wmapro-ism
 fate-wmapro-ism: CMD = pcm -i $(TARGET_SAMPLES)/isom/vc1-wmapro.ism -vn
 fate-wmapro-ism: REF = $(SAMPLES)/isom/vc1-wmapro.pcm
+fate-wmapro-ism: SIZE_TOLERANCE = 4784
 
 $(FATE_WMAPRO-yes): CMP = oneoff