From patchwork Sat Oct 6 19:39:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 10620 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:ab0:73d2:0:0:0:0:0 with SMTP id m18csp1878351uaq; Sat, 6 Oct 2018 12:39:51 -0700 (PDT) X-Google-Smtp-Source: ACcGV62u41/BXO+zyjK0Bl8nw1yq6WeiJlKjiwuU2d5T1jUN0pksGgFvGXe0kMk0nFrCm8KWdNcX X-Received: by 2002:adf:8382:: with SMTP id 2-v6mr11578347wre.13.1538854791682; Sat, 06 Oct 2018 12:39:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538854791; cv=none; d=google.com; s=arc-20160816; b=t8bIVPt7vQ6ZJN8jsrp6GslCSglbA5Kj3VRLpNpzleUFgppHEkI3gu2M6di49xoj54 ERLes9jmPPLqBD6/IUNTPFB0ASfgW5Yi0HPmbld0MzsK+mdZ46yaTrjRHKXZO5frWNxJ 6BQGFYhAFCussbSRH+QZvRTqf6FlgoWoR3zSWvHgXKS1TfxFdCyhKFmPlGPJHKCeCEVb B/+LGnXe9kgcPX8l5SunFxoeFchhlQjcpW0HhzZ2CxI8QpMeEhmw+juaM3lbSeaP0XmZ oMFeXRSIR1/hTMIXjPnI9W6J60jY2rfeJDUII6MW7mqqZHkskzFNOFOpcdhx8NucskCW eo5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :in-reply-to:mime-version:references:message-id:to:from:date :delivered-to; bh=GJyB/NbeJK+ClVJt6O1sDDwFT3Nv2kl8KFJHHE2cuCk=; b=jw45VSt3YdHJEX5exfF1ionp9kfY68Bsk6r8QQ2ca5bOCUCjU4riHaYL5sg8v02Jx8 4iXlWI0Zk0tiNh784+OyGi4ZITIHiX3cMRRayZgBjYocfmR9VeIuhGQZzlHSWKsof5M4 ooPDA7IMN1QlHbR4UyETK7G9lkSFLSzSPsgjGWYbLmKw77vpnhckfdQu+dgB4ZNZf8EM 3Ahe7twAWxhrfXIhtLZcLXo68uztjnM3ySIq4jn/7W+rc8Vg6UnvuO5YTah4/CQCPnIM PGvVojSCp8smOC6DHTS0EMliMsS3/42otnDZm1ZJoRTnIx/CgWKcBPDG5PkRcd8JRLCY qcmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id m16-v6si8743512wrn.341.2018.10.06.12.39.50; Sat, 06 Oct 2018 12:39:51 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1CAB0689FC4; Sat, 6 Oct 2018 22:39:28 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 35727689A6F for ; Sat, 6 Oct 2018 22:39:21 +0300 (EEST) X-Originating-IP: 213.47.41.20 Received: from localhost (213-47-41-20.cable.dynamic.surfer.at [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id BA09A60002 for ; Sat, 6 Oct 2018 19:39:41 +0000 (UTC) Date: Sat, 6 Oct 2018 21:39:40 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20181006193940.GM26838@michaelspb> References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve WMAPRO/XMA gapless output X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Sat, Oct 06, 2018 at 04:53:31PM +0200, Banana M. wrote: > > Is it intended that this doesnt list a human name ? > > (its no problem but jb tends to be unhappy if there are no names in the > log > > so i try to ask people if they really intend to not list their name or if > > its a unintended mistake) > > It's the nick/mail I use in github and other places, it's correct :) > > > > this will need some change to > > TEST wmapro-ism > > stddev: 0.00 PSNR:143.22 MAXDIFF: 1 bytes: 884736/ 879952 > > size: |884736 - 879952| >= 0 > > Test wmapro-ism failed. Look at tests/data/fate/wmapro-ism.err for > details. > > make: *** [fate-wmapro-ism] Error 1 > > I've run the tests but I thought fixes would need changes in the > (restricted) FATE suite server. > > If somebody could explain how to fix the test or point to some doc, but I > think some more experienced dev should take care of it. you can avoid the failure with: changing the reference file is not possible as that would break previous checkouts. We can of course add a new reference with a new filename and use that. If someone posts a new file and people want it updated, i can upload it but we should make really sure that this is the final one and would no need future changes. In fact the file we have currently should not have been a file from ffmpeg but from the "reference" decoder. Iam not sure where it came from ... But if it was a proper reference then bug fixes should reduce differences not inncrease them ... > > I plan to refine WMAPRO output in some cases (once I investigate), so this > will change again later anyway. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel diff --git a/tests/fate/wma.mak b/tests/fate/wma.mak index 12a8fa989a..bc530998e8 100644 --- a/tests/fate/wma.mak +++ b/tests/fate/wma.mak @@ -11,6 +11,7 @@ fate-wmapro-5.1: SIZE_TOLERANCE = 24576 FATE_WMAPRO-$(call DEMDEC, MOV, WMAPRO) += fate-wmapro-ism fate-wmapro-ism: CMD = pcm -i $(TARGET_SAMPLES)/isom/vc1-wmapro.ism -vn fate-wmapro-ism: REF = $(SAMPLES)/isom/vc1-wmapro.pcm +fate-wmapro-ism: SIZE_TOLERANCE = 4784 $(FATE_WMAPRO-yes): CMP = oneoff