From patchwork Sun Oct 7 21:02:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marton Balint X-Patchwork-Id: 10623 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:ab0:73d2:0:0:0:0:0 with SMTP id m18csp2888360uaq; Sun, 7 Oct 2018 14:02:44 -0700 (PDT) X-Google-Smtp-Source: ACcGV62YDtBR6DjeiaRfihVc2JU9j6tEPwJEK/LBWz1WkhxyGMWx0Tq1zh1RE2ira5VvaVGfbXjT X-Received: by 2002:a5d:6785:: with SMTP id v5-v6mr14054588wru.245.1538946164226; Sun, 07 Oct 2018 14:02:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538946164; cv=none; d=google.com; s=arc-20160816; b=SfrDElccaRssT8HbtTET51pBFUezGx3oMUmRA0t6f8wA+mf8DyrWnON+4BQhAfOBZa A8UKBWVjfkf42hN7k8B0vHdPzOdVGjgfUBW06LkLXpYR0CbvTORQmpXJ+j73DOSvkuH2 bGUwJKm6Us/2rT2YYxBtPcSgzILh4midZTRTvZw41zq+mdTIf/t5fddA7+LAcJAhoYUs W3ZAuxjR+JqCFBWPYEruesKHVJzNXbodFvtyT7eE0zWKa7LDy1PF8dCpxDaYu9kYHgar rhr6/rEc5TX/839Ff8/cf/ka+MivwC0Km1HWoM+3V/JOQ9K6IMLxTWY0+iqtztlSMPdD dV6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to; bh=4/ztPtLZJWuipMl4YkkrYWeMadrObwH/P8aNuX3EFxg=; b=zWnCroaV/5hSCyjWMzOEAKXSgNUmwMpYzz6j8k2Ylr9eMuy2sFkSmvLG1KSUud1PTp tDOFBmELvLAvacE2b1JxArkpVQDqtAZ/4oIyUHwWoWmBQ3vaJMHEV91yVjY6DmYLpeOa Zci3dPZoSY1I/GcsxIGxwQ5a0mQenGlSDRBeiny9iKLbtFwSwf3L7XgDSasLfwWKjGNf cUHeGqsgdmIxUwfVQBQrc9Bf7p8qeOzUfEJKaA6DSTYbLJIvjcc+qgpIEQJmesVNNfwl gToVhh9vZkuJ1pUNZ/9oxvSCo3hhi/5j9om4sHx7y1ajJJZKRRqbMFK0BIG+azOT2602 7mWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id l10-v6si3815847wmh.138.2018.10.07.14.02.43; Sun, 07 Oct 2018 14:02:44 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5F188689F62; Mon, 8 Oct 2018 00:02:20 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8B87A689CCB for ; Mon, 8 Oct 2018 00:02:13 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id DAF3EE19C5; Sun, 7 Oct 2018 23:02:34 +0200 (CEST) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nkSpy_ySFhJ9; Sun, 7 Oct 2018 23:02:33 +0200 (CEST) Received: from bluegene.passwd.hu (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id BB7F5E19BF; Sun, 7 Oct 2018 23:02:33 +0200 (CEST) From: Marton Balint To: ffmpeg-devel@ffmpeg.org Date: Sun, 7 Oct 2018 23:02:26 +0200 Message-Id: <20181007210228.16822-1-cus@passwd.hu> X-Mailer: git-send-email 2.16.4 Subject: [FFmpeg-devel] [PATCH 1/3] avfilter/f_cue: always check the return value of ff_inlink_consume_frame X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Marton Balint MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Fixes Coverity CID 1439936. Signed-off-by: Marton Balint --- libavfilter/f_cue.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavfilter/f_cue.c b/libavfilter/f_cue.c index 9cf710c6d2..b48dfc9d49 100644 --- a/libavfilter/f_cue.c +++ b/libavfilter/f_cue.c @@ -51,7 +51,9 @@ static int activate(AVFilterContext *ctx) } if (s->status == 1) { if (pts - s->first_pts < s->preroll) { - ff_inlink_consume_frame(inlink, &frame); + int ret = ff_inlink_consume_frame(inlink, &frame); + if (ret < 0) + return ret; return ff_filter_frame(outlink, frame); } s->first_pts = pts; @@ -70,7 +72,9 @@ static int activate(AVFilterContext *ctx) s->status++; } if (s->status == 4) { - ff_inlink_consume_frame(inlink, &frame); + int ret = ff_inlink_consume_frame(inlink, &frame); + if (ret < 0) + return ret; return ff_filter_frame(outlink, frame); } }