[FFmpeg-devel,V5,2/2] lavf/vc1test: add rcv to vc1test demuxer extensions

Submitted by Jun Zhao on Oct. 17, 2018, 12:18 a.m.

Details

Message ID 1539735538-15714-3-git-send-email-mypopydev@gmail.com
State New
Headers show

Commit Message

Jun Zhao Oct. 17, 2018, 12:18 a.m.
rcv is commonly used as extension for vc1 test stream files.

Signed-off-by: Jun Zhao <jun.zhao@intel.com>
---
 libavformat/vc1test.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Michael Niedermayer Oct. 22, 2018, 8:39 p.m.
On Wed, Oct 17, 2018 at 08:18:58AM +0800, Jun Zhao wrote:
> rcv is commonly used as extension for vc1 test stream files.
> 
> Signed-off-by: Jun Zhao <jun.zhao@intel.com>
> ---
>  libavformat/vc1test.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/libavformat/vc1test.c b/libavformat/vc1test.c
> index 64a45cd..d445709 100644
> --- a/libavformat/vc1test.c
> +++ b/libavformat/vc1test.c
> @@ -122,5 +122,6 @@ AVInputFormat ff_vc1t_demuxer = {
>      .read_probe     = vc1t_probe,
>      .read_header    = vc1t_read_header,
>      .read_packet    = vc1t_read_packet,
> +    .extensions     = "rcv",
>      .flags          = AVFMT_GENERIC_INDEX,

what is the advantage to add this here ? the demuxer has a probe function ...

does this fix some issue ?

thx

[...]
mypopy@gmail.com Oct. 23, 2018, 12:47 a.m.
On Tue, Oct 23, 2018 at 4:39 AM Michael Niedermayer
<michael@niedermayer.cc> wrote:
>
> On Wed, Oct 17, 2018 at 08:18:58AM +0800, Jun Zhao wrote:
> > rcv is commonly used as extension for vc1 test stream files.
> >
> > Signed-off-by: Jun Zhao <jun.zhao@intel.com>
> > ---
> >  libavformat/vc1test.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/libavformat/vc1test.c b/libavformat/vc1test.c
> > index 64a45cd..d445709 100644
> > --- a/libavformat/vc1test.c
> > +++ b/libavformat/vc1test.c
> > @@ -122,5 +122,6 @@ AVInputFormat ff_vc1t_demuxer = {
> >      .read_probe     = vc1t_probe,
> >      .read_header    = vc1t_read_header,
> >      .read_packet    = vc1t_read_packet,
> > +    .extensions     = "rcv",
> >      .flags          = AVFMT_GENERIC_INDEX,
>
> what is the advantage to add this here ? the demuxer has a probe function ...
>
> does this fix some issue ?
>
> thx
>
I think give a " .extensions" will help some guys as a tip like the
other demuxer, which have both the probe function and extensions
field.

Patch hide | download patch | download mbox

diff --git a/libavformat/vc1test.c b/libavformat/vc1test.c
index 64a45cd..d445709 100644
--- a/libavformat/vc1test.c
+++ b/libavformat/vc1test.c
@@ -122,5 +122,6 @@  AVInputFormat ff_vc1t_demuxer = {
     .read_probe     = vc1t_probe,
     .read_header    = vc1t_read_header,
     .read_packet    = vc1t_read_packet,
+    .extensions     = "rcv",
     .flags          = AVFMT_GENERIC_INDEX,
 };