From patchwork Tue Oct 23 11:58:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zachary Zhou X-Patchwork-Id: 10757 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id E115644A6F8 for ; Tue, 23 Oct 2018 15:00:30 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8A13168A61E; Tue, 23 Oct 2018 15:00:02 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 832CB68A60F for ; Tue, 23 Oct 2018 14:59:55 +0300 (EEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2018 05:00:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,416,1534834800"; d="scan'208";a="101891175" Received: from u18-skl-zz.sh.intel.com ([10.239.159.29]) by orsmga001.jf.intel.com with ESMTP; 23 Oct 2018 05:00:20 -0700 From: Zachary Zhou To: ffmpeg-devel@ffmpeg.org Date: Tue, 23 Oct 2018 19:58:52 +0800 Message-Id: <20181023115852.17983-1-zachary.zhou@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [FFmpeg-devel] [PATCH] tests/checkasm/Makefile: fix 'make fate' error when enable vaapi X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: zachary.zhou@intel.com MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Reproduce the issue: $ ./configure --enable-libmfx --enable-vaapi --enable-shared --samples=fate-suite/ $ make fate LD tests/checkasm/checkasm /usr/bin/x86_64-linux-gnu-ld: libavutil/libavutil.a(hwcontext_vaapi.o): undefined reference to symbol 'XDisplayName' //usr/lib/x86_64-linux-gnu/libX11.so.6: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status tests/checkasm/Makefile:71: recipe for target 'tests/checkasm/checkasm' failed make: *** [tests/checkasm/checkasm] Error 1 --- tests/checkasm/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/checkasm/Makefile b/tests/checkasm/Makefile index 9484acbbd7..d4827dc816 100644 --- a/tests/checkasm/Makefile +++ b/tests/checkasm/Makefile @@ -66,6 +66,7 @@ OBJDIRS += $(CHECKASMDIRS) tests/checkasm/checkasm.o: CFLAGS += -Umain CHECKASM := tests/checkasm/checkasm$(EXESUF) +EXTRALIBS += -lX11 $(CHECKASM): $(CHECKASMOBJS) $(FF_STATIC_DEP_LIBS) $(LD) $(LDFLAGS) $(LDEXEFLAGS) $(LD_O) $(CHECKASMOBJS) $(FF_STATIC_DEP_LIBS) $(EXTRALIBS-avcodec) $(EXTRALIBS-avfilter) $(EXTRALIBS-avformat) $(EXTRALIBS-avutil) $(EXTRALIBS-swresample) $(EXTRALIBS)