[FFmpeg-devel] doc/fate.texi: Mention that samples should be uploaded before pushing dependant commits

Submitted by Michael Niedermayer on Oct. 23, 2018, 9:38 p.m.

Details

Message ID 20181023213834.20347-1-michael@niedermayer.cc
State New
Headers show

Commit Message

Michael Niedermayer Oct. 23, 2018, 9:38 p.m.
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 doc/fate.texi | 2 ++
 1 file changed, 2 insertions(+)

Comments

Gyan Oct. 24, 2018, 5:04 a.m.
On Wed, Oct 24, 2018 at 3:09 AM Michael Niedermayer <michael@niedermayer.cc>
wrote:

> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  doc/fate.texi | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/doc/fate.texi b/doc/fate.texi
> index a352994230..9ca77f7772 100644
> --- a/doc/fate.texi
> +++ b/doc/fate.texi
> @@ -155,6 +155,8 @@ space on each client, network bandwidth and so on
> benefit from smaller test case
>  Also keep in mind older checkouts use existing sample files, that means in
>  practice generally do not replace, remove or overwrite files as it likely
> would
>  break older checkouts or releases.
> +Also all needed samples for a commit should be uploaded before the commit
> is
> +pushed. Ideally 24h before.
>

Nit: merge the 2nd sentence into the first.

Also, dependant -> dependent.

Gyan
Michael Niedermayer Oct. 31, 2018, 12:41 a.m.
On Wed, Oct 24, 2018 at 10:34:39AM +0530, Gyan wrote:
> On Wed, Oct 24, 2018 at 3:09 AM Michael Niedermayer <michael@niedermayer.cc>
> wrote:
> 
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  doc/fate.texi | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/doc/fate.texi b/doc/fate.texi
> > index a352994230..9ca77f7772 100644
> > --- a/doc/fate.texi
> > +++ b/doc/fate.texi
> > @@ -155,6 +155,8 @@ space on each client, network bandwidth and so on
> > benefit from smaller test case
> >  Also keep in mind older checkouts use existing sample files, that means in
> >  practice generally do not replace, remove or overwrite files as it likely
> > would
> >  break older checkouts or releases.
> > +Also all needed samples for a commit should be uploaded before the commit
> > is
> > +pushed. Ideally 24h before.
> >
> 
> Nit: merge the 2nd sentence into the first.

can you suggest a exact wording for that ?
The sentance seems already a bit long to me and describing a slightly
different area of potential issues


> 
> Also, dependant -> dependent.

locally fixed

thx

[...]
Gyan Oct. 31, 2018, 10:22 a.m.
On Wed, Oct 31, 2018 at 6:11 AM Michael Niedermayer <michael@niedermayer.cc>
wrote:

> On Wed, Oct 24, 2018 at 10:34:39AM +0530, Gyan wrote:
> > On Wed, Oct 24, 2018 at 3:09 AM Michael Niedermayer
> <michael@niedermayer.cc>
> > wrote:
>
>


> > > +Also all needed samples for a commit should be uploaded before the
> commit
> > > is
> > > +pushed. Ideally 24h before.
> > >
> >
> > Nit: merge the 2nd sentence into the first.
>
> can you suggest a exact wording for that ?
> The sentance seems already a bit long to me and describing a slightly
> different area of potential issues
>

 "Also all needed samples for a commit should be uploaded, ideally 24
hours, before the push."

But no strong opinion here.

Gyan
Michael Niedermayer Oct. 31, 2018, 12:24 p.m.
On Wed, Oct 31, 2018 at 03:52:34PM +0530, Gyan wrote:
> On Wed, Oct 31, 2018 at 6:11 AM Michael Niedermayer <michael@niedermayer.cc>
> wrote:
> 
> > On Wed, Oct 24, 2018 at 10:34:39AM +0530, Gyan wrote:
> > > On Wed, Oct 24, 2018 at 3:09 AM Michael Niedermayer
> > <michael@niedermayer.cc>
> > > wrote:
> >
> >
> 
> 
> > > > +Also all needed samples for a commit should be uploaded before the
> > commit
> > > > is
> > > > +pushed. Ideally 24h before.
> > > >
> > >
> > > Nit: merge the 2nd sentence into the first.
> >
> > can you suggest a exact wording for that ?
> > The sentance seems already a bit long to me and describing a slightly
> > different area of potential issues
> >
> 
>  "Also all needed samples for a commit should be uploaded, ideally 24
> hours, before the push."

ahh ok, i misunderstood what you meant

will apply with this change

thanks

[...]

Patch hide | download patch | download mbox

diff --git a/doc/fate.texi b/doc/fate.texi
index a352994230..9ca77f7772 100644
--- a/doc/fate.texi
+++ b/doc/fate.texi
@@ -155,6 +155,8 @@  space on each client, network bandwidth and so on benefit from smaller test case
 Also keep in mind older checkouts use existing sample files, that means in
 practice generally do not replace, remove or overwrite files as it likely would
 break older checkouts or releases.
+Also all needed samples for a commit should be uploaded before the commit is
+pushed. Ideally 24h before.
 
 @example
 #First update your local samples copy: