[FFmpeg-devel] vp9_parser: set profile in AVCodecContext

Submitted by chcunningham@chromium.org on Oct. 24, 2018, 1:16 a.m.

Details

Message ID 20181024011602.180496-1-chcunningham@chromium.org
State New
Headers show

Commit Message

chcunningham@chromium.org Oct. 24, 2018, 1:16 a.m.
---
 libavcodec/vp9_parser.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

James Almer Oct. 24, 2018, 1:19 a.m.
On 10/23/2018 10:16 PM, chcunningham wrote:
> ---
>  libavcodec/vp9_parser.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libavcodec/vp9_parser.c b/libavcodec/vp9_parser.c
> index 9531f34a32..b6b621198b 100644
> --- a/libavcodec/vp9_parser.c
> +++ b/libavcodec/vp9_parser.c
> @@ -43,6 +43,8 @@ static int parse(AVCodecParserContext *ctx,
>      profile |= get_bits1(&gb) << 1;
>      if (profile == 3) profile += get_bits1(&gb);
>  
> +    avctx->profile = profile;
> +
>      if (get_bits1(&gb)) {
>          keyframe = 0;
>      } else {
> 

I already sent a patch for this earlier this month.
https://patchwork.ffmpeg.org/patch/10602/
chcunningham@chromium.org Oct. 24, 2018, 6:09 p.m.
On Tue, Oct 23, 2018 at 6:28 PM James Almer <jamrial@gmail.com> wrote:

> On 10/23/2018 10:16 PM, chcunningham wrote:
> > ---
> >  libavcodec/vp9_parser.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/libavcodec/vp9_parser.c b/libavcodec/vp9_parser.c
> > index 9531f34a32..b6b621198b 100644
> > --- a/libavcodec/vp9_parser.c
> > +++ b/libavcodec/vp9_parser.c
> > @@ -43,6 +43,8 @@ static int parse(AVCodecParserContext *ctx,
> >      profile |= get_bits1(&gb) << 1;
> >      if (profile == 3) profile += get_bits1(&gb);
> >
> > +    avctx->profile = profile;
> > +
> >      if (get_bits1(&gb)) {
> >          keyframe = 0;
> >      } else {
> >
>
> I already sent a patch for this earlier this month.
> https://patchwork.ffmpeg.org/patch/10602/
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


And yours is much more complete. Ignore this one.

Patch hide | download patch | download mbox

diff --git a/libavcodec/vp9_parser.c b/libavcodec/vp9_parser.c
index 9531f34a32..b6b621198b 100644
--- a/libavcodec/vp9_parser.c
+++ b/libavcodec/vp9_parser.c
@@ -43,6 +43,8 @@  static int parse(AVCodecParserContext *ctx,
     profile |= get_bits1(&gb) << 1;
     if (profile == 3) profile += get_bits1(&gb);
 
+    avctx->profile = profile;
+
     if (get_bits1(&gb)) {
         keyframe = 0;
     } else {