| Message ID | 20181104201315.10588-1-jamrial@gmail.com |
|---|---|
| State | Accepted |
| Commit | 89a0d33e3a53e8edefd734b131a7035d13052947 |
| Headers | show |
On 04/11/18 20:13, James Almer wrote: > buffer_delay_length_minus_1 is five bits long, meaning decode_buffer_delay and > encoder_buffer_delay can have values up to 32 bits long. > > Signed-off-by: James Almer <jamrial@gmail.com> > --- > See https://0x0.st/sIv-.ivf > > libavcodec/cbs_av1.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/cbs_av1.h b/libavcodec/cbs_av1.h > index b66a09c389..614a0bf108 100644 > --- a/libavcodec/cbs_av1.h > +++ b/libavcodec/cbs_av1.h > @@ -87,8 +87,8 @@ typedef struct AV1RawSequenceHeader { > uint8_t seq_level_idx[AV1_MAX_OPERATING_POINTS]; > uint8_t seq_tier[AV1_MAX_OPERATING_POINTS]; > uint8_t decoder_model_present_for_this_op[AV1_MAX_OPERATING_POINTS]; > - uint8_t decoder_buffer_delay[AV1_MAX_OPERATING_POINTS]; > - uint8_t encoder_buffer_delay[AV1_MAX_OPERATING_POINTS]; > + uint32_t decoder_buffer_delay[AV1_MAX_OPERATING_POINTS]; > + uint32_t encoder_buffer_delay[AV1_MAX_OPERATING_POINTS]; > uint8_t low_delay_mode_flag[AV1_MAX_OPERATING_POINTS]; > uint8_t initial_display_delay_present_for_this_op[AV1_MAX_OPERATING_POINTS]; > uint8_t initial_display_delay_minus_1[AV1_MAX_OPERATING_POINTS]; > Yep; LGTM. Thanks, - Mark
On 11/4/2018 9:32 PM, Mark Thompson wrote: > On 04/11/18 20:13, James Almer wrote: >> buffer_delay_length_minus_1 is five bits long, meaning decode_buffer_delay and >> encoder_buffer_delay can have values up to 32 bits long. >> >> Signed-off-by: James Almer <jamrial@gmail.com> >> --- >> See https://0x0.st/sIv-.ivf >> >> libavcodec/cbs_av1.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavcodec/cbs_av1.h b/libavcodec/cbs_av1.h >> index b66a09c389..614a0bf108 100644 >> --- a/libavcodec/cbs_av1.h >> +++ b/libavcodec/cbs_av1.h >> @@ -87,8 +87,8 @@ typedef struct AV1RawSequenceHeader { >> uint8_t seq_level_idx[AV1_MAX_OPERATING_POINTS]; >> uint8_t seq_tier[AV1_MAX_OPERATING_POINTS]; >> uint8_t decoder_model_present_for_this_op[AV1_MAX_OPERATING_POINTS]; >> - uint8_t decoder_buffer_delay[AV1_MAX_OPERATING_POINTS]; >> - uint8_t encoder_buffer_delay[AV1_MAX_OPERATING_POINTS]; >> + uint32_t decoder_buffer_delay[AV1_MAX_OPERATING_POINTS]; >> + uint32_t encoder_buffer_delay[AV1_MAX_OPERATING_POINTS]; >> uint8_t low_delay_mode_flag[AV1_MAX_OPERATING_POINTS]; >> uint8_t initial_display_delay_present_for_this_op[AV1_MAX_OPERATING_POINTS]; >> uint8_t initial_display_delay_minus_1[AV1_MAX_OPERATING_POINTS]; >> > > Yep; LGTM. > > Thanks, > > - Mark Pushed.
diff --git a/libavcodec/cbs_av1.h b/libavcodec/cbs_av1.h index b66a09c389..614a0bf108 100644 --- a/libavcodec/cbs_av1.h +++ b/libavcodec/cbs_av1.h @@ -87,8 +87,8 @@ typedef struct AV1RawSequenceHeader { uint8_t seq_level_idx[AV1_MAX_OPERATING_POINTS]; uint8_t seq_tier[AV1_MAX_OPERATING_POINTS]; uint8_t decoder_model_present_for_this_op[AV1_MAX_OPERATING_POINTS]; - uint8_t decoder_buffer_delay[AV1_MAX_OPERATING_POINTS]; - uint8_t encoder_buffer_delay[AV1_MAX_OPERATING_POINTS]; + uint32_t decoder_buffer_delay[AV1_MAX_OPERATING_POINTS]; + uint32_t encoder_buffer_delay[AV1_MAX_OPERATING_POINTS]; uint8_t low_delay_mode_flag[AV1_MAX_OPERATING_POINTS]; uint8_t initial_display_delay_present_for_this_op[AV1_MAX_OPERATING_POINTS]; uint8_t initial_display_delay_minus_1[AV1_MAX_OPERATING_POINTS];
buffer_delay_length_minus_1 is five bits long, meaning decode_buffer_delay and encoder_buffer_delay can have values up to 32 bits long. Signed-off-by: James Almer <jamrial@gmail.com> --- See https://0x0.st/sIv-.ivf libavcodec/cbs_av1.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)