From patchwork Mon Nov 5 14:52:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Thompson X-Patchwork-Id: 10935 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id CEC5844C9AA for ; Mon, 5 Nov 2018 16:52:57 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4619E68A882; Mon, 5 Nov 2018 16:52:29 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9264068A80F for ; Mon, 5 Nov 2018 16:52:22 +0200 (EET) Received: by mail-wm1-f66.google.com with SMTP id l66-v6so2516144wml.2 for ; Mon, 05 Nov 2018 06:52:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=cRbq5JVEt5uFqWOlB5/49SrHDA9e1cVKwU++LtoyeQk=; b=vEjAuHkksFPO/NNpumehMQf4wF3ooND1Z98iAs50cmYpNO2k8T8wlMis6pEaa+oU8c nAYeuCkU052xkIwx0la3/8MksXg8/H8t85SzjEbLg+j4VLv8qZxNtEZZa4ypWdZU3nVv gjHJHBUkPVRg2jLT25+ZtMjn3ZstpPSLGokscEIGpfLscVRMwKV4ckbRZOkjkurOClsx qzRU/my0zIrkXtALemfgi9Ch0AqwMnYA+tHvIMI7Wc7U7veSm9u1Qv7gZgM411+HxcG3 3FPvAQwoOoifJggg/aDZyr4iFwdquMT6lF6bE77Qw/8RLfiwiYHHjRkOkdJET6WpZeDG 6rdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cRbq5JVEt5uFqWOlB5/49SrHDA9e1cVKwU++LtoyeQk=; b=LmFVHGMYWuKalZhSbv9Jqfw1Nzm6qRPHVoTW3vEdw1uGfJE/nFxMKvdcYPZGMsaC1k u/sccenfwhAyLGostPElxSfcHLkUNxaUDKez9s/moIoTxuIpzUXyQ7OSOY4mN8+jX7E9 ZRWiwz0tG34Omg5lNcyws060m3tjZY95dpYu1I5YYbGb09vlnW8MTv9dhx5NyiKXrlzS jMJPVz6T9iKv+4/aLAG6AczLfvjVj1doXoRKkh2MT+uPxIYIsbEURfX0mq1Mp1KtOpPv PUhF+3rGiLTM5M+4rXmxu4ZNVxekQpygfoZHUup3KhVCarpRU/iE9E9DyaTh6pIXpwcV ehyQ== X-Gm-Message-State: AGRZ1gLzW5afJh5+/uIe+Cs9ZSgAaKyCyDjN4I1DwZ6K+emFUe9JoAif P0zJeG2xlq9lS9qhYf5KsgH4W57T26E= X-Google-Smtp-Source: AJdET5dC7/zO5dwNurPNIfdpYZ63rVRZRA9seudv9C4skEfkiPxNGk8A67pQD8+Av2iKt3E7TJJrXg== X-Received: by 2002:a1c:88cc:: with SMTP id k195-v6mr6258214wmd.84.1541429575710; Mon, 05 Nov 2018 06:52:55 -0800 (PST) Received: from rywe.jkqxz.net (cpc91242-cmbg18-2-0-cust650.5-4.cable.virginm.net. [82.8.130.139]) by smtp.gmail.com with ESMTPSA id j189-v6sm3066847wmf.18.2018.11.05.06.52.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Nov 2018 06:52:55 -0800 (PST) From: Mark Thompson To: ffmpeg-devel@ffmpeg.org Date: Mon, 5 Nov 2018 14:52:46 +0000 Message-Id: <20181105145246.1157-3-sw@jkqxz.net> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181105145246.1157-1-sw@jkqxz.net> References: <20181105145246.1157-1-sw@jkqxz.net> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 3/3] libaomenc: Drop unused noise-sensitivity option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" --- On 28/10/18 21:02, Carl Eugen Hoyos wrote: > 2018-10-28 21:08 GMT+01:00, Mark Thompson : >> --- >> This was in the 4.0 release, unfortunately (and did nothing there as well). > > If it has never worked, it can be removed imo. Sure, here is a new version. Thanks, - Mark libavcodec/libaomenc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index c5458766cb..4cad053a48 100644 --- a/libavcodec/libaomenc.c +++ b/libavcodec/libaomenc.c @@ -71,7 +71,6 @@ typedef struct AOMEncoderContext { int crf; int static_thresh; int drop_threshold; - int noise_sensitivity; uint64_t sse[4]; int have_sse; /**< true if we have pending sse[] */ uint64_t frame_number; @@ -980,7 +979,6 @@ static const AVOption options[] = { { "crf", "Select the quality for constant quality mode", offsetof(AOMContext, crf), AV_OPT_TYPE_INT, {.i64 = -1}, -1, 63, VE }, { "static-thresh", "A change threshold on blocks below which they will be skipped by the encoder", OFFSET(static_thresh), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, INT_MAX, VE }, { "drop-threshold", "Frame drop threshold", offsetof(AOMContext, drop_threshold), AV_OPT_TYPE_INT, {.i64 = 0 }, INT_MIN, INT_MAX, VE }, - { "noise-sensitivity", "Noise sensitivity", OFFSET(noise_sensitivity), AV_OPT_TYPE_INT, {.i64 = 0 }, 0, 4, VE}, { "tiles", "Tile columns x rows", OFFSET(tile_cols), AV_OPT_TYPE_IMAGE_SIZE, { .str = NULL }, 0, 0, VE }, { "tile-columns", "Log2 of number of tile columns to use", OFFSET(tile_cols_log2), AV_OPT_TYPE_INT, {.i64 = -1}, -1, 6, VE}, { "tile-rows", "Log2 of number of tile rows to use", OFFSET(tile_rows_log2), AV_OPT_TYPE_INT, {.i64 = -1}, -1, 6, VE},