| Message ID | 20181114012134.10407-1-jeebjp@gmail.com |
|---|---|
| State | Accepted |
| Commit | b31a4be15f568c12be32dca87f066416e6adc8ad |
| Headers | show |
On 11/14/18, Jan Ekström <jeebjp@gmail.com> wrote: > Internally in ISOBMFF the FLAC-in-ISOBMFF draft uses the "fLaC" > as the identifier for FLACSampleEntry, but what the browsers > seem to eat for MPEG-DASH manifests is plain "flac". > > Verified by auri_ on IRC to play with the major browsers. > --- > libavformat/dashenc.c | 1 + > 1 file changed, 1 insertion(+) > lgtm
2018-11-14 2:21 GMT+01:00, Jan Ekström <jeebjp@gmail.com>: > Internally in ISOBMFF the FLAC-in-ISOBMFF draft uses the "fLaC" > as the identifier for FLACSampleEntry, but what the browsers > seem to eat for MPEG-DASH manifests is plain "flac". Does this patch also answer the recent discussion about specifications vs real-world tests? Carl Eugen
On Wed, Nov 14, 2018, 17:22 Carl Eugen Hoyos <ceffmpeg@gmail.com wrote: > 2018-11-14 2:21 GMT+01:00, Jan Ekström <jeebjp@gmail.com>: > > Internally in ISOBMFF the FLAC-in-ISOBMFF draft uses the "fLaC" > > as the identifier for FLACSampleEntry, but what the browsers > > seem to eat for MPEG-DASH manifests is plain "flac". > > Does this patch also answer the recent discussion about > specifications vs real-world tests? > No. The ISOBMFF side is followed properly, and nobody cared to test flac until now with dash manifests. The default code path utilizes the ISOBMFF identifier for dash manifest entries, which matches things such as avc/hevc/aac etc. Not to mention that there doesn't seem to be a spec for the dash manifest side of things for flac. At all. It just seems to follow the mime type. So no, this is not the same thing. At all. Jan >
On Wed, Nov 14, 2018 at 11:55 AM Paul B Mahol <onemda@gmail.com> wrote: > > On 11/14/18, Jan Ekström <jeebjp@gmail.com> wrote: > > Internally in ISOBMFF the FLAC-in-ISOBMFF draft uses the "fLaC" > > as the identifier for FLACSampleEntry, but what the browsers > > seem to eat for MPEG-DASH manifests is plain "flac". > > > > Verified by auri_ on IRC to play with the major browsers. > > --- > > libavformat/dashenc.c | 1 + > > 1 file changed, 1 insertion(+) > > > > lgtm Thanks. Applied with an improved commit message that I think explains the situation with regards to unavailability of a specification for this value utilized in the MPEG-DASH manifest. Jan
diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index f8b3d106d5..d151921175 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -143,6 +143,7 @@ static struct codec_string { { AV_CODEC_ID_VP9, "vp9" }, { AV_CODEC_ID_VORBIS, "vorbis" }, { AV_CODEC_ID_OPUS, "opus" }, + { AV_CODEC_ID_FLAC, "flac" }, { 0, NULL } };