[FFmpeg-devel,1/4] avformat/concatdec: set seekable flag after opening the last file

Submitted by Marton Balint on Nov. 22, 2018, 12:39 a.m.

Details

Message ID 20181122003907.12088-1-cus@passwd.hu
State New
Headers show

Commit Message

Marton Balint Nov. 22, 2018, 12:39 a.m.
After finishing the last file all durations and start times should be known.

Signed-off-by: Marton Balint <cus@passwd.hu>
---
 libavformat/concatdec.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Marton Balint Dec. 2, 2018, 12:11 a.m.
On Thu, 22 Nov 2018, Marton Balint wrote:

> After finishing the last file all durations and start times should be known.
>
> Signed-off-by: Marton Balint <cus@passwd.hu>
> ---
> libavformat/concatdec.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c
> index bbe13136fa..a5883ec66e 100644
> --- a/libavformat/concatdec.c
> +++ b/libavformat/concatdec.c
> @@ -525,6 +525,7 @@ static int open_next_file(AVFormatContext *avf)
>
>     if (++fileno >= cat->nb_files) {
>         cat->eof = 1;
> +        cat->seekable = 1;
>         return AVERROR_EOF;
>     }
>     return open_file(avf, fileno);
> -- 
> 2.16.4

Ping for the series...

Thanks,
Marton
Marton Balint Dec. 8, 2018, 11:15 p.m.
On Sun, 2 Dec 2018, Marton Balint wrote:

>
>
> On Thu, 22 Nov 2018, Marton Balint wrote:
>
>> After finishing the last file all durations and start times should be 
> known.
>>
>> Signed-off-by: Marton Balint <cus@passwd.hu>
>> ---
>> libavformat/concatdec.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c
>> index bbe13136fa..a5883ec66e 100644
>> --- a/libavformat/concatdec.c
>> +++ b/libavformat/concatdec.c
>> @@ -525,6 +525,7 @@ static int open_next_file(AVFormatContext *avf)
>>
>>     if (++fileno >= cat->nb_files) {
>>         cat->eof = 1;
>> +        cat->seekable = 1;
>>         return AVERROR_EOF;
>>     }
>>     return open_file(avf, fileno);
>> -- 
>> 2.16.4
>
> Ping for the series...

Will apply soon.

Regards,
Marton
Nicolas George Dec. 8, 2018, 11:17 p.m.
Marton Balint (2018-12-09):
> Will apply soon.

Sorry, I was busy and it slipped my mind.

I will try hard to have a careful look tomorrow.

Regards,
Nicolas George Dec. 9, 2018, 11:21 a.m.
Marton Balint (2018-11-22):
> After finishing the last file all durations and start times should be known.
> 
> Signed-off-by: Marton Balint <cus@passwd.hu>
> ---
>  libavformat/concatdec.c | 1 +
>  1 file changed, 1 insertion(+)

Ok in principle. I would be more comfortable if some kind of consistency
test were added to check the "should", but I do not consider blocking.

Regards,

Patch hide | download patch | download mbox

diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c
index bbe13136fa..a5883ec66e 100644
--- a/libavformat/concatdec.c
+++ b/libavformat/concatdec.c
@@ -525,6 +525,7 @@  static int open_next_file(AVFormatContext *avf)
 
     if (++fileno >= cat->nb_files) {
         cat->eof = 1;
+        cat->seekable = 1;
         return AVERROR_EOF;
     }
     return open_file(avf, fileno);